jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 06:50:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: Avoid plain printf in auth/superuser-t

Browse Source 
If we're reporting an error, we should be printing to stderr. If we're
printing informational data, we should be using diag() to try to avoid
interfering with the TAP data. Change all printf() calls into one of
those two options.

Change-Id: I2e0d577e0c32efa539ed486190dbaca23bd0487f
Reviewed-on: https://gerrit.openafs.org/14866
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
This commit is contained in:
Andrew Deason 2021-11-23 15:56:49 -06:00 committed by Benjamin Kaduk
parent 7448cd159d
commit 7cfbb087b9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/auth/superuser-t.c
View File

@ -204,7 +204,7 @@ startClient(char *configPath)
/* Start a connection to our test service with it */
he = gethostbyname("localhost");
if (!he) {
printf("Couldn't look up server hostname");
fprintf(stderr, "Couldn't look up server hostname");
exit(1);
}
@ -417,7 +417,7 @@ int main(int argc, char **argv)
startClient(argv[2]);
exit(0);
} else {
printf("Bad option %s\n", argv[1]);
fprintf(stderr, "Bad option %s\n", argv[1]);
exit(1);
}
}
@ -438,7 +438,7 @@ int main(int argc, char **argv)
goto out;
}
printf("Config directory is %s\n", dirname);
diag("Config directory is %s\n", dirname);
serverPid = fork();
if (serverPid == -1) {
sysbail("fork");