From 82b3760c4ff71f9315c3e2d07c35b2ebd7ba6942 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Sun, 24 Feb 2013 10:45:41 +0000 Subject: [PATCH] butc: Remove dead assignment We never use the value of mvFlag once the string has been restored, so don't bother reseting it. Caught by clang-analyzer Change-Id: I12db6957c9b8ec3bb9c43f10d9e9754d4afa3ed7 Reviewed-on: http://gerrit.openafs.org/9248 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: BuildBot --- src/butc/tcmain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/butc/tcmain.c b/src/butc/tcmain.c index 885d44c4e6..f5f1e94475 100644 --- a/src/butc/tcmain.c +++ b/src/butc/tcmain.c @@ -288,10 +288,9 @@ stringNowReplace(char *logFile, char *deviceName) *pos = '_'; strcat(logFile, deviceName); /* now put back deviceName to the way it was */ - if (mvFlag) { - mvFlag = 0; + if (mvFlag) deviceName -= devPrefLen; - } + strcpy(deviceName, storeDevice); return (0);