From 85e29294eef44fcc52b0583c70debcae452e829d Mon Sep 17 00:00:00 2001 From: Derrick Brashear Date: Wed, 4 Aug 2010 09:00:58 -0400 Subject: [PATCH] discon getparentvcache leak fix don't leak an unref'd vcache pointer if we are returning an error (EAGAIN). thanks to Simon Wilkinson for catching this. Change-Id: I40c5aa0fd50e1f2c76b09ba073a7109bca706d8c Reviewed-on: http://gerrit.openafs.org/2511 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/afs/afs_disconnected.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/afs/afs_disconnected.c b/src/afs/afs_disconnected.c index db244bf3d6..46a665c9d1 100644 --- a/src/afs/afs_disconnected.c +++ b/src/afs/afs_disconnected.c @@ -531,8 +531,10 @@ afs_GetParentVCache(struct vcache *avc, int deleted, struct VenusFid *afid, } end: - if (code && *adp) + if (code && *adp) { afs_PutVCache(*adp); + *adp = NULL; + } return code; }