From 860c34ba938602387f78c10c2f548fb8a523a9cd Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Tue, 19 Feb 2013 15:43:29 +0000 Subject: [PATCH] ptserver: Don't ignore ubik_Write failures If we can't write to the ubik database, then that's a bad thing. Don't ignore it. Caught by clang-analyzer Change-Id: I08b57a74405cc563c6141251fd3d433b2904ea0e Reviewed-on: http://gerrit.openafs.org/9176 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear --- src/ptserver/ptutils.c | 2 ++ src/ptserver/utils.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/src/ptserver/ptutils.c b/src/ptserver/ptutils.c index 144d07af3e..b877694156 100644 --- a/src/ptserver/ptutils.c +++ b/src/ptserver/ptutils.c @@ -445,6 +445,8 @@ CreateEntry(struct ubik_trans *at, char aname[PR_MAXNAMELEN], afs_int32 *aid, af /* write updated entry for group */ code = pr_Write(at, 0, pos, ¢ry, sizeof(centry)); + if (code) + return PRDBFAIL; /* Now add the new user entry to the database */ tentry.creator = creator; diff --git a/src/ptserver/utils.c b/src/ptserver/utils.c index 732f585e28..60de04719c 100644 --- a/src/ptserver/utils.c +++ b/src/ptserver/utils.c @@ -479,6 +479,8 @@ RemoveFromIDHash(struct ubik_trans *tt, afs_int32 aid, afs_int32 *loc) /* ??? i return PRDBFAIL; bentry.nextID = tentry.nextID; code = pr_WriteEntry(tt, 0, trail, &bentry); + if (code) + return PRDBFAIL; } *loc = current; return PRSUCCESS; @@ -557,6 +559,8 @@ RemoveFromNameHash(struct ubik_trans *tt, char *aname, afs_int32 *loc) return PRDBFAIL; bentry.nextName = tentry.nextName; code = pr_WriteEntry(tt, 0, trail, &bentry); + if (code) + return PRDBFAIL; } *loc = current; return PRSUCCESS;