volser: set error, not code, before rfail

The rfail cleanup handler overwrites 'code' ~unconditionally, but
does use an existing 'error' value if present.  Since the intent
is to return failure to the caller, preserve the code in the error
variable and do so.

FIXES 131897

Change-Id: I25db2f9ad75a5b856626d39d35f97a09f26bd7a9
Reviewed-on: http://gerrit.openafs.org/12108
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
This commit is contained in:
Benjamin Kaduk 2015-11-22 13:24:43 -06:00
parent 2f3b27ac47
commit 888fc16db5

View File

@ -4067,7 +4067,7 @@ UV_ReleaseVolume(afs_uint32 afromvol, afs_uint32 afromserver,
code = CheckTrans(fromconn, &fromtid, afrompart, &orig_status);
if (code) {
code = ENOENT;
error = ENOENT;
goto rfail;
}