jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 07:20:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

volser: add more logs for failures during restore

Browse Source 
In the current version of the volserver, some failures during volume
restores are not logged. In order to help debugging, this commit
introduces extra logs for possible failures during this process, so we
guarantee that an error at any point during the restore causes a
message to be logged.

Change-Id: I3647155aeb3f10316d9d7fecb5b126efc909f7b4
Reviewed-on: https://gerrit.openafs.org/13252
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
This commit is contained in:
Marcio Barbosa 2018-08-11 15:51:05 -04:00 committed by Benjamin Kaduk
parent 7c27365ea2
commit 89b50fdec9
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/volser/dumpstuff.c
View File

@ -1265,8 +1265,11 @@ RestoreVolume(struct rx_call *call, Volume * avp, int incremental,
Log("1 Volser: RestoreVolume: Volume header missing from dump; not restored\n");
return VOLSERREAD_DUMPERROR;
}
if (ReadVolumeHeader(iodp, &vol) == VOLSERREAD_DUMPERROR)
if (ReadVolumeHeader(iodp, &vol) == VOLSERREAD_DUMPERROR) {
Log("1 Volser: RestoreVolume: Error reading volume header (id: %u); aborted\n",
V_id(vp));
return VOLSERREAD_DUMPERROR;
}
if (!delo)
delo = ProcessIndex(vp, vLarge, &b1, &s1, 0);
@ -1288,6 +1291,8 @@ RestoreVolume(struct rx_call *call, Volume * avp, int incremental,
tdelo = delo;
while (1) {
if (ReadVnodes(iodp, vp, 0, b1, s1, b2, s2, tdelo)) {
Log("1 Volser: RestoreVolume: Error reading vnodes (id: %u); aborted\n",
V_id(vp));
error = VOLSERREAD_DUMPERROR;
goto clean;
}
@ -1296,6 +1301,8 @@ RestoreVolume(struct rx_call *call, Volume * avp, int incremental,
break;
if (ReadVolumeHeader(iodp, &vol) == VOLSERREAD_DUMPERROR) {
Log("1 Volser: RestoreVolume: Error reading volume header (id: %u); aborted\n",
V_id(vp));
error = VOLSERREAD_DUMPERROR;
goto out;
}