jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 15:30:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows: warnings on kernel builds

Browse Source 
I turned some new warning (by virtue of a more modern compiler) and
threw up a few hundred.  This checked supresses them:

- Mostly remove variables which are never used
- Make unused parameters UNREFERENCED_PARAMETER
- Initialize a couple of variables which were either forgotton or
  the compiler wasn't smart enough to notice were initialized.

Also strip out some extraneous tabs which had crept in.

Change-Id: Iee261ad8a7338bb5d8fde2d7229bbbbbd5af39ae
Reviewed-on: http://gerrit.openafs.org/8812
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
This commit is contained in:
Rod Widdowson 2012-12-21 16:17:34 +00:00 committed by Jeffrey Altman
parent cf150252b6
commit 8a4094e9ff
29 changed files with 120 additions and 195 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/WINNT/afsrdr/kernel/lib/AFSBTreeSupport.cpp
View File

@ -45,7 +45,6 @@ AFSLocateCaseSensitiveDirEntry( IN AFSDirectoryCB *RootNode,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirectoryCB *pEntry = NULL;
AFSDirectoryCB *pCurrentEntry = NULL;
pCurrentEntry = RootNode;
@ -164,7 +163,6 @@ AFSLocateCaseInsensitiveDirEntry( IN AFSDirectoryCB *RootNode,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirectoryCB *pEntry = NULL;
AFSDirectoryCB *pCurrentEntry = NULL;
pCurrentEntry = RootNode;
@ -880,7 +878,6 @@ AFSLocateShortNameDirEntry( IN AFSDirectoryCB *RootNode,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirectoryCB *pEntry = NULL;
AFSDirectoryCB *pCurrentEntry = NULL;
pCurrentEntry = RootNode;
@ -1256,7 +1253,6 @@ AFSLocateHashEntry( IN AFSBTreeEntry *TopNode,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSBTreeEntry *pEntry = NULL;
AFSBTreeEntry *pCurrentEntry = NULL;
pCurrentEntry = TopNode;

2
src/WINNT/afsrdr/kernel/lib/AFSCleanup.cpp
View File

@ -54,7 +54,7 @@ NTSTATUS
AFSCleanup( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = NULL;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);

3
src/WINNT/afsrdr/kernel/lib/AFSClose.cpp
View File

@ -54,9 +54,8 @@ NTSTATUS
AFSClose( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
ULONG ulRequestType = 0;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSFcb *pFcb = NULL;
AFSDeviceExt *pDeviceExt = NULL;

3
src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp
View File

@ -1860,7 +1860,6 @@ AFSUpdateFileInformation( IN AFSFileID *ParentFid,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSFileUpdateCB stUpdateCB;
ULONG ulResultLen = 0;
AFSFileUpdateResultCB *pUpdateResultCB = NULL;
@ -3037,7 +3036,6 @@ AFSNotifyPipeTransceive( IN AFSCcb *Ccb,
ULONG ulResultLen = 0;
MDL *pInputMdl = NULL, *pOutputMdl = NULL;
void *pInputSystemBuffer = NULL, *pOutputSystemBuffer = NULL;
ULONG ulBufferLength = OutputLength;
AFSPipeIORequestCB *pIoRequest = NULL;
__Enter
@ -3325,7 +3323,6 @@ AFSIsExtentRequestQueued( IN AFSFileID *FileID,
{
BOOLEAN bRequestQueued = FALSE;
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
AFSCommSrvcCB *pCommSrvc = NULL;
AFSPoolEntry *pPoolEntry = NULL;

21
src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp
View File

@ -56,7 +56,7 @@ NTSTATUS
AFSCreate( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;
FILE_OBJECT *pFileObject = NULL;
@ -138,14 +138,14 @@ AFSCommonCreate( IN PDEVICE_OBJECT DeviceObject,
AFSDeviceExt *pDeviceExt = NULL;
BOOLEAN bOpenTargetDirectory = FALSE, bReleaseVolume = FALSE;
PACCESS_MASK pDesiredAccess = NULL;
UNICODE_STRING uniComponentName, uniPathName, uniRootFileName, uniParsedFileName;
UNICODE_STRING uniComponentName, uniRootFileName, uniParsedFileName;
UNICODE_STRING uniSubstitutedPathName;
UNICODE_STRING uniRelativeName;
AFSNameArrayHdr *pNameArray = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSDirectoryCB *pParentDirectoryCB = NULL, *pDirectoryCB = NULL;
ULONG ulParseFlags = 0;
GUID stAuthGroup;
GUID stAuthGroup = {0};
ULONG ulNameProcessingFlags = 0;
BOOLEAN bOpenedReparsePoint = FALSE;
LONG lCount;
@ -1708,10 +1708,7 @@ AFSProcessCreate( IN PIRP Irp,
PFILE_OBJECT pFileObject = NULL;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
ULONG ulOptions = 0;
ULONG ulShareMode = 0;
ULONG ulAccess = 0;
ULONG ulAttributes = 0;
LARGE_INTEGER liAllocationSize = {0,0};
BOOLEAN bFileCreated = FALSE, bReleaseFcb = FALSE, bAllocatedCcb = FALSE;
PACCESS_MASK pDesiredAccess = NULL;
USHORT usShareAccess;
@ -2226,7 +2223,7 @@ AFSOpenTargetDirectory( IN PIRP Irp,
OUT AFSFcb **Fcb,
OUT AFSCcb **Ccb)
{
UNREFERENCED_PARAMETER(VolumeCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
PFILE_OBJECT pFileObject = NULL;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
@ -2234,7 +2231,7 @@ AFSOpenTargetDirectory( IN PIRP Irp,
USHORT usShareAccess;
BOOLEAN bAllocatedCcb = FALSE;
BOOLEAN bReleaseFcb = FALSE;
AFSObjectInfoCB *pParentObject = NULL, *pTargetObject = NULL;
AFSObjectInfoCB *pParentObject = NULL;
UNICODE_STRING uniTargetName;
LONG lCount;
@ -2495,14 +2492,14 @@ AFSProcessOpen( IN PIRP Irp,
OUT AFSFcb **Fcb,
OUT AFSCcb **Ccb)
{
UNREFERENCED_PARAMETER(VolumeCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
PFILE_OBJECT pFileObject = NULL;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
PACCESS_MASK pDesiredAccess = NULL;
USHORT usShareAccess;
BOOLEAN bAllocatedCcb = FALSE, bReleaseFcb = FALSE;
ULONG ulAdditionalFlags = 0, ulOptions = 0;
ULONG ulOptions = 0;
AFSFileOpenCB stOpenCB;
AFSFileOpenResultCB stOpenResultCB;
ULONG ulResultLen = 0;
@ -3022,14 +3019,13 @@ AFSProcessOverwriteSupersede( IN PDEVICE_OBJECT DeviceObject,
OUT AFSFcb **Fcb,
OUT AFSCcb **Ccb)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
PFILE_OBJECT pFileObject = NULL;
LARGE_INTEGER liZero = {0,0};
BOOLEAN bReleasePaging = FALSE, bReleaseFcb = FALSE;
ULONG ulAttributes = 0;
LARGE_INTEGER liTime;
ULONG ulCreateDisposition = 0;
BOOLEAN bAllocatedCcb = FALSE;
BOOLEAN bUserMapped = FALSE;
@ -3478,7 +3474,6 @@ AFSOpenIOCtlFcb( IN PIRP Irp,
PFILE_OBJECT pFileObject = NULL;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
BOOLEAN bReleaseFcb = FALSE, bAllocatedCcb = FALSE;
UNICODE_STRING uniFullFileName;
AFSPIOCtlOpenCloseRequestCB stPIOCtlOpen;
AFSFileID stFileID;
AFSObjectInfoCB *pParentObjectInfo = NULL;

4
src/WINNT/afsrdr/kernel/lib/AFSDevControl.cpp
View File

@ -54,10 +54,10 @@ NTSTATUS
AFSDevControl( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;
ULONG ulIoControlCode;
ULONG ulIoControlCode = 0;
__try
{

16
src/WINNT/afsrdr/kernel/lib/AFSDirControl.cpp
View File

@ -54,11 +54,9 @@ NTSTATUS
AFSDirControl( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
ULONG ulRequestType = 0;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSFcb *pFcb = NULL;
__try
{
@ -120,21 +118,18 @@ AFSQueryDirectory( IN PIRP Irp)
AFSFcb *pFcb = NULL;
AFSCcb *pCcb = NULL;
BOOLEAN bInitialQuery = FALSE;
ULONG ulIndex;
PUCHAR pBuffer;
ULONG ulUserBufferLength;
PUNICODE_STRING puniArgFileName = NULL;
UNICODE_STRING uniTmpMaskName;
UNICODE_STRING uniDirUniBuf;
WCHAR wchMaskBuffer[ 4];
FILE_INFORMATION_CLASS FileInformationClass;
ULONG ulFileIndex, ulDOSFileIndex;
ULONG ulFileIndex;
BOOLEAN bRestartScan;
BOOLEAN bReturnSingleEntry;
BOOLEAN bIndexSpecified;
ULONG ulNextEntry = 0;
ULONG ulLastEntry = 0;
BOOLEAN bDoCase;
PFILE_DIRECTORY_INFORMATION pDirInfo;
PFILE_FULL_DIR_INFORMATION pFullDirInfo;
PFILE_BOTH_DIR_INFORMATION pBothDirInfo;
@ -144,7 +139,6 @@ AFSQueryDirectory( IN PIRP Irp)
AFSDirectoryCB *pDirEntry = NULL;
BOOLEAN bReleaseMain = FALSE;
BOOLEAN bReleaseFcb = FALSE;
ULONG ulTargetFileType = AFS_FILE_TYPE_UNKNOWN;
AFSFileInfoCB stFileInfo;
AFSObjectInfoCB *pObjectInfo = NULL;
ULONG ulAdditionalAttributes = 0;
@ -614,7 +608,6 @@ AFSQueryDirectory( IN PIRP Irp)
{
ULONG ulBytesRemainingInBuffer;
int rc;
ulAdditionalAttributes = 0;
@ -1936,10 +1929,9 @@ BOOLEAN
AFSNotifyReportChangeCallback( IN void *NotifyContext,
IN void *FilterContext)
{
UNREFERENCED_PARAMETER(NotifyContext);
UNREFERENCED_PARAMETER(FilterContext);
BOOLEAN bReturn = TRUE;
AFSCcb *pDirCcb = (AFSCcb *)NotifyContext;
AFSCcb *pNotifyCcb = (AFSCcb *)FilterContext;
__Enter
{

4
src/WINNT/afsrdr/kernel/lib/AFSEa.cpp
View File

@ -54,7 +54,7 @@ NTSTATUS
AFSQueryEA( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_EAS_NOT_SUPPORTED;
IO_STACK_LOCATION *pIrpSp;
@ -100,7 +100,7 @@ NTSTATUS
AFSSetEA( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_EAS_NOT_SUPPORTED;
IO_STACK_LOCATION *pIrpSp;

30
src/WINNT/afsrdr/kernel/lib/AFSExtentsSupport.cpp
View File

@ -40,8 +40,10 @@
#define AFS_MAX_FCBS_TO_DROP 10
static ULONG ExtentsMasks[AFS_NUM_EXTENT_LISTS] = AFS_EXTENTS_MASKS;
#if AFS_VALIDATE_EXTENTS
static VOID VerifyExtentsLists(AFSFcb *Fcb);
static AFSExtent *DirtyExtentFor(PLIST_ENTRY le);
#endif
LIST_ENTRY *
AFSEntryForOffset( IN AFSFcb *Fcb,
@ -157,10 +159,8 @@ AFSTearDownFcbExtents( IN AFSFcb *Fcb,
AFSReleaseExtentsCB *pRelease = NULL;
BOOLEAN locked = FALSE;
NTSTATUS ntStatus;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
GUID *pAuthGroup = AuthGroup;
GUID stAuthGroup;
LONG lCount;
__Enter
{
@ -411,8 +411,6 @@ AFSDeleteFcbExtents( IN AFSFcb *Fcb)
size_t sz;
BOOLEAN locked = FALSE;
NTSTATUS ntStatus;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
LONG lCount;
__Enter
{
@ -757,7 +755,7 @@ BOOLEAN AFSDoExtentsMapRegion(IN AFSFcb *Fcb,
// *LastExtent as output is either the extent which
// contains the Offset, or the last one which doesn't
//
AFSExtent *entry;
AFSExtent *entry = NULL;
AFSExtent *newEntry;
BOOLEAN retVal = FALSE;
@ -845,7 +843,6 @@ AFSRequestExtentsAsync( IN AFSFcb *Fcb,
LARGE_INTEGER liAlignedOffset;
ULONG ulAlignedLength = 0;
BOOLEAN bRegionMapped = FALSE;
ULONGLONG ullProcessId = (ULONGLONG)PsGetCurrentProcessId();
__Enter
{
@ -1595,11 +1592,9 @@ AFSReleaseSpecifiedExtents( IN AFSReleaseFileExtentsCB *Extents,
{
AFSExtent *pExtent;
LIST_ENTRY *le;
LIST_ENTRY *leNext;
ULONG ulExtentCount = 0;
NTSTATUS ntStatus = STATUS_SUCCESS;
BOOLEAN bReleaseAll = FALSE;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
LONG lCount;
__Enter
@ -1809,6 +1804,7 @@ AFSFcb*
AFSFindFcbToClean(ULONG IgnoreTime, AFSFcb *LastFcb, BOOLEAN Block)
{
UNREFERENCED_PARAMETER(IgnoreTime);
AFSFcb *pFcb = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSDeviceExt *pRDRDeviceExt = NULL;
@ -2220,7 +2216,6 @@ AFSProcessReleaseFileExtents( IN PIRP Irp)
{
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
PFILE_OBJECT pFileObject = pIrpSp->FileObject;
AFSFcb *pFcb = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSDeviceExt *pDevExt;
@ -2722,7 +2717,6 @@ AFSFlushExtents( IN AFSFcb *Fcb,
{
AFSNonPagedFcb *pNPFcb = Fcb->NPFcb;
AFSExtent *pExtent, *pNextExtent;
LIST_ENTRY *le;
AFSReleaseExtentsCB *pRelease = NULL;
ULONG count = 0;
ULONG initialDirtyCount = 0;
@ -2731,8 +2725,6 @@ AFSFlushExtents( IN AFSFcb *Fcb,
ULONG sz = 0;
NTSTATUS ntStatus = STATUS_SUCCESS;
LARGE_INTEGER liLastFlush;
AFSExtent *pDirtyListHead = NULL, *pDirtyListTail = NULL;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
GUID *pAuthGroup = AuthGroup;
GUID stAuthGroup;
LONG lCount;
@ -2981,7 +2973,7 @@ try_exit:
lCount = InterlockedDecrement( &Fcb->Specific.File.QueuedFlushCount);
ASSERT( lCount >= 0);
ASSERT( lCount >= 0);
if( lCount == 0)
{
@ -3026,14 +3018,12 @@ AFSReleaseExtentsWithFlush( IN AFSFcb *Fcb,
LIST_ENTRY *le;
AFSReleaseExtentsCB *pRelease = NULL;
ULONG count = 0;
ULONG initialDirtyCount = 0;
BOOLEAN bExtentsLocked = FALSE;
ULONG total = 0;
ULONG sz = 0;
NTSTATUS ntStatus = STATUS_SUCCESS;
LARGE_INTEGER liLastFlush;
ULONG ulRemainingExtentLength = 0;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
GUID *pAuthGroup = AuthGroup;
GUID stAuthGroup;
LONG lCount;
@ -3291,14 +3281,12 @@ AFSReleaseCleanExtents( IN AFSFcb *Fcb,
LIST_ENTRY *le;
AFSReleaseExtentsCB *pRelease = NULL;
ULONG count = 0;
ULONG initialDirtyCount = 0;
BOOLEAN bExtentsLocked = FALSE;
ULONG total = 0;
ULONG sz = 0;
NTSTATUS ntStatus = STATUS_SUCCESS;
LARGE_INTEGER liLastFlush;
ULONG ulRemainingExtentLength = 0;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
GUID *pAuthGroup = AuthGroup;
GUID stAuthGroup;
@ -3719,6 +3707,7 @@ NextExtent(AFSExtent *Extent, ULONG SkipList)
return ExtentFor(Extent->Lists[SkipList].Flink, SkipList);
}
#if AFS_VALIDATE_EXTENTS
static AFSExtent *DirtyExtentFor(PLIST_ENTRY le)
{
@ -3780,6 +3769,7 @@ static VOID VerifyExtentsLists(AFSFcb *Fcb)
}
#endif
}
#endif
void
AFSTrimExtents( IN AFSFcb *Fcb,
@ -3793,8 +3783,6 @@ AFSTrimExtents( IN AFSFcb *Fcb,
NTSTATUS ntStatus = STATUS_SUCCESS;
LARGE_INTEGER liAlignedOffset = {0,0};
AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
LONG lCount;
__Enter
{
@ -3956,10 +3944,6 @@ AFSTrimSpecifiedExtents( IN AFSFcb *Fcb,
LIST_ENTRY *le;
AFSExtent *pExtent;
AFSFileExtentCB *pFileExtents = Result;
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
LONG lCount;
__Enter
{

2
src/WINNT/afsrdr/kernel/lib/AFSFSControl.cpp
View File

@ -43,6 +43,7 @@ AFSFSControl( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;
@ -727,6 +728,7 @@ AFSProcessShareFsCtrl( IN IRP *Irp,
IN AFSCcb *Ccb)
{
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
ULONG ulOutputBufferLen = 0, ulInputBufferLen;

13
src/WINNT/afsrdr/kernel/lib/AFSFcbSupport.cpp
View File

@ -55,13 +55,9 @@ AFSInitFcb( IN AFSDirectoryCB *DirEntry)
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSFcb *pFcb = NULL;
AFSNonPagedFcb *pNPFcb = NULL;
IO_STATUS_BLOCK stIoSb = {0,0};
USHORT usFcbLength = 0;
ULONGLONG ullIndex = 0;
AFSDirEnumEntry *pDirEnumCB = NULL;
AFSObjectInfoCB *pObjectInfo = NULL, *pParentObjectInfo = NULL;
AFSVolumeCB *pVolumeCB = NULL;
@ -372,14 +368,13 @@ AFSInitVolume( IN GUID *AuthGroup,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STATUS_BLOCK stIoStatus = {0,0};
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSNonPagedVolumeCB *pNonPagedVcb = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSNonPagedObjectInfoCB *pNonPagedObject = NULL;
ULONGLONG ullIndex = 0;
BOOLEAN bReleaseLocks = FALSE;
AFSVolumeInfoCB stVolumeInformation;
AFSVolumeInfoCB stVolumeInformation = {0};
AFSNonPagedDirectoryCB *pNonPagedDirEntry = NULL;
LONG lCount;
@ -903,11 +898,10 @@ AFSInitRootFcb( IN ULONGLONG ProcessID,
IN AFSVolumeCB *VolumeCB)
{
UNREFERENCED_PARAMETER(ProcessID);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSFcb *pFcb = NULL;
AFSNonPagedFcb *pNPFcb = NULL;
IO_STATUS_BLOCK stIoStatus = {0,0};
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
__Enter
{
@ -1029,9 +1023,6 @@ void
AFSRemoveRootFcb( IN AFSFcb *RootFcb)
{
AFSDirectoryCB *pCurrentDirEntry = NULL;
AFSVolumeCB *pVolumeCB = RootFcb->ObjectInformation->VolumeCB;
if( RootFcb->NPFcb != NULL)
{

50
src/WINNT/afsrdr/kernel/lib/AFSFileInfo.cpp
View File

@ -55,15 +55,13 @@ AFSQueryFileInfo( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
ULONG ulRequestType = 0;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSFcb *pFcb = NULL;
AFSCcb *pCcb = NULL;
PFILE_OBJECT pFileObject;
BOOLEAN bReleaseMain = FALSE;
LONG lLength;
LONG lLength = 0;
FILE_INFORMATION_CLASS stFileInformationClass;
GUID stAuthGroup;
PVOID pBuffer;
@ -509,12 +507,11 @@ AFSSetFileInfo( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSFcb *pFcb = NULL;
AFSCcb *pCcb = NULL;
BOOLEAN bCompleteRequest = TRUE;
FILE_INFORMATION_CLASS FileInformationClass;
BOOLEAN bCanQueueRequest = FALSE;
PFILE_OBJECT pFileObject = NULL;
@ -1027,6 +1024,7 @@ AFSQueryInternalInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
NTSTATUS ntStatus = STATUS_SUCCESS;
if( *Length >= sizeof( FILE_INTERNAL_INFORMATION))
@ -1054,6 +1052,8 @@ AFSQueryEaInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(DirectoryCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
RtlZeroMemory( Buffer,
@ -1082,6 +1082,7 @@ AFSQueryPositionInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
@ -1111,6 +1112,8 @@ AFSQueryAccess( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
if( *Length >= sizeof( FILE_ACCESS_INFORMATION))
@ -1139,6 +1142,8 @@ AFSQueryMode( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
if( *Length >= sizeof( FILE_MODE_INFORMATION))
@ -1167,6 +1172,8 @@ AFSQueryAlignment( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
if( *Length >= sizeof( FILE_ALIGNMENT_INFORMATION))
@ -1195,6 +1202,7 @@ AFSQueryNameInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(DirectoryCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
ULONG ulCopyLength = 0;
ULONG cchCopied = 0;
@ -1337,6 +1345,7 @@ AFSQueryShortNameInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
NTSTATUS ntStatus = STATUS_BUFFER_TOO_SMALL;
ULONG ulCopyLength = 0;
@ -1550,9 +1559,9 @@ AFSQueryStreamInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
NTSTATUS ntStatus = STATUS_BUFFER_TOO_SMALL;
ULONG ulCopyLength = 0;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
if( *Length >= FIELD_OFFSET( FILE_STREAM_INFORMATION, StreamName))
{
@ -1621,7 +1630,6 @@ AFSQueryAttribTagInfo( IN PIRP Irp,
{
NTSTATUS ntStatus = STATUS_BUFFER_TOO_SMALL;
ULONG ulCopyLength = 0;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSFcb *pFcb = NULL;
AFSCcb *pCcb = NULL;
@ -1735,9 +1743,9 @@ AFSQueryRemoteProtocolInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(DirectoryCB);
NTSTATUS ntStatus = STATUS_BUFFER_TOO_SMALL;
ULONG ulCopyLength = 0;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
if( *Length >= sizeof( FILE_REMOTE_PROTOCOL_INFORMATION))
{
@ -1772,6 +1780,7 @@ AFSQueryPhysicalNameInfo( IN PIRP Irp,
IN OUT PLONG Length)
{
UNREFERENCED_PARAMETER(DirectoryCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
ULONG ulCopyLength = 0;
ULONG cchCopied = 0;
@ -2207,17 +2216,15 @@ AFSSetFileLinkInfo( IN PIRP Irp)
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
IO_STATUS_BLOCK stIoSb = {0,0};
PFILE_LINK_INFORMATION pFileLinkInfo = NULL;
PFILE_OBJECT pSrcFileObj = NULL;
PFILE_OBJECT pTargetFileObj = pIrpSp->Parameters.SetFile.FileObject;
AFSFcb *pSrcFcb = NULL, *pTargetDcb = NULL, *pTargetFcb = NULL;
AFSFcb *pSrcFcb = NULL, *pTargetDcb = NULL;
AFSCcb *pSrcCcb = NULL, *pTargetDirCcb = NULL;
AFSObjectInfoCB *pSrcObject = NULL, *pTargetObject = NULL;
AFSObjectInfoCB *pSrcObject = NULL;
AFSObjectInfoCB *pSrcParentObject = NULL, *pTargetParentObject = NULL;
UNICODE_STRING uniSourceName, uniTargetName;
UNICODE_STRING uniFullTargetName, uniTargetParentName;
UNICODE_STRING uniShortName;
BOOLEAN bCommonParent = FALSE;
AFSDirectoryCB *pTargetDirEntry = NULL;
AFSDirectoryCB *pNewTargetDirEntry = NULL;
@ -2225,7 +2232,6 @@ AFSSetFileLinkInfo( IN PIRP Irp)
BOOLEAN bTargetEntryExists = FALSE;
LONG lCount;
BOOLEAN bReleaseTargetDirLock = FALSE;
AFSFileID stNewFid;
ULONG ulNotificationAction = 0, ulNotifyFilter = 0;
__Enter
@ -2576,7 +2582,6 @@ AFSSetRenameInfo( IN PIRP Irp)
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
IO_STATUS_BLOCK stIoSb = {0,0};
AFSFcb *pSrcFcb = NULL, *pTargetDcb = NULL, *pTargetFcb = NULL;
AFSCcb *pSrcCcb = NULL, *pTargetDirCcb = NULL;
PFILE_OBJECT pSrcFileObj = pIrpSp->FileObject;
@ -2589,9 +2594,9 @@ AFSSetRenameInfo( IN PIRP Irp)
AFSDirectoryCB *pTargetDirEntry = NULL;
ULONG ulTargetCRC = 0;
BOOLEAN bTargetEntryExists = FALSE;
AFSObjectInfoCB *pSrcObject = NULL, *pTargetObject = NULL;
AFSObjectInfoCB *pSrcObject = NULL;
AFSObjectInfoCB *pSrcParentObject = NULL, *pTargetParentObject = NULL;
AFSFileID stNewFid, stTmpTargetFid;
AFSFileID stNewFid;
ULONG ulNotificationAction = 0, ulNotifyFilter = 0;
UNICODE_STRING uniFullTargetName;
BOOLEAN bCommonParent = FALSE;
@ -3324,6 +3329,7 @@ NTSTATUS
AFSSetPositionInfo( IN PIRP Irp,
IN AFSDirectoryCB *DirectoryCB)
{
UNREFERENCED_PARAMETER(DirectoryCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
PFILE_POSITION_INFORMATION pBuffer;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
@ -3339,6 +3345,7 @@ NTSTATUS
AFSSetAllocationInfo( IN PIRP Irp,
IN AFSDirectoryCB *DirectoryCB)
{
UNREFERENCED_PARAMETER(DirectoryCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
PFILE_ALLOCATION_INFORMATION pBuffer;
BOOLEAN bReleasePaging = FALSE;
@ -3546,6 +3553,7 @@ NTSTATUS
AFSSetEndOfFileInfo( IN PIRP Irp,
IN AFSDirectoryCB *DirectoryCB)
{
UNREFERENCED_PARAMETER(DirectoryCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
PFILE_END_OF_FILE_INFORMATION pBuffer;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
@ -3757,9 +3765,9 @@ AFSProcessShareSetInfo( IN IRP *Irp,
IN AFSCcb *Ccb)
{
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
ULONG ulOutputBufferLen = 0, ulInputBufferLen;
FILE_INFORMATION_CLASS ulFileInformationClass;
void *pPipeInfo = NULL;
@ -3828,9 +3836,9 @@ AFSProcessShareQueryInfo( IN IRP *Irp,
IN AFSCcb *Ccb)
{
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
ULONG ulOutputBufferLen = 0, ulInputBufferLen;
FILE_INFORMATION_CLASS ulFileInformationClass;
void *pPipeInfo = NULL;
@ -3902,6 +3910,8 @@ AFSProcessPIOCtlQueryInfo( IN IRP *Irp,
IN OUT LONG *Length)
{
UNREFERENCED_PARAMETER(Fcb);
UNREFERENCED_PARAMETER(Ccb);
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
FILE_INFORMATION_CLASS ulFileInformationClass;

1
src/WINNT/afsrdr/kernel/lib/AFSFlushBuffers.cpp
View File

@ -43,6 +43,7 @@ AFSFlushBuffers( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
PFILE_OBJECT pFileObject = pIrpSp->FileObject;

68
src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp
View File

@ -56,6 +56,7 @@ AFSExceptionFilter( IN CHAR *FunctionString,
IN PEXCEPTION_POINTERS ExceptPtrs)
{
UNREFERENCED_PARAMETER(Code);
PEXCEPTION_RECORD ExceptRec;
PCONTEXT Context;
@ -363,7 +364,6 @@ AFSLockSystemBuffer( IN PIRP Irp,
IN ULONG Length)
{
NTSTATUS Status = STATUS_SUCCESS;
void *pAddress = NULL;
if( Irp->MdlAddress != NULL)
@ -423,7 +423,7 @@ AFSLockSystemBuffer( IN PIRP Irp,
void *
AFSLockUserBuffer( IN void *UserBuffer,
IN ULONG BufferLength,
OUT MDL ** Mdl)
OUT MDL ** Mdl)
{
NTSTATUS ntStatus = STATUS_SUCCESS;
@ -543,7 +543,6 @@ AFSUnmapServiceMappedBuffer( IN void *MappedBuffer,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
void *pMappedBuffer = NULL;
AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
KAPC stApcState;
@ -630,8 +629,8 @@ AFSDefaultDispatch( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_INVALID_DEVICE_REQUEST;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSCompleteRequest( Irp,
ntStatus);
@ -646,7 +645,6 @@ AFSInitializeGlobalDirectoryEntries()
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirectoryCB *pDirNode = NULL;
ULONG ulEntryLength = 0;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSObjectInfoCB *pObjectInfoCB = NULL;
AFSNonPagedDirectoryCB *pNonPagedDirEntry = NULL;
LONG lCount;
@ -911,10 +909,6 @@ AFSInitDirEntry( IN AFSObjectInfoCB *ParentObjectInfo,
AFSDirectoryCB *pDirNode = NULL;
NTSTATUS ntStatus = STATUS_SUCCESS;
ULONG ulEntryLength = 0;
AFSDirEnumEntry *pDirEnumCB = NULL;
AFSFileID stTargetFileID;
AFSFcb *pVcb = NULL;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSObjectInfoCB *pObjectInfoCB = NULL;
BOOLEAN bAllocatedObjectCB = FALSE;
ULONGLONG ullIndex = 0;
@ -1303,7 +1297,6 @@ AFSEvaluateNode( IN GUID *AuthGroup,
IN AFSDirectoryCB *DirEntry)
{
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirEnumEntry *pDirEntry = NULL;
UNICODE_STRING uniTargetName;
@ -1425,7 +1418,6 @@ AFSValidateSymLink( IN GUID *AuthGroup,
IN AFSDirectoryCB *DirEntry)
{
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirEnumEntry *pDirEntry = NULL;
UNICODE_STRING uniTargetName;
@ -1910,12 +1902,8 @@ AFSInvalidateCache( IN AFSInvalidateCacheCB *InvalidateCB)
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSFcb *pDcb = NULL, *pFcb = NULL, *pNextFcb = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSFcb *pTargetDcb = NULL;
AFSDeviceExt *pDevExt = (AFSDeviceExt *) AFSRDRDeviceObject->DeviceExtension;
AFSDirectoryCB *pCurrentDirEntry = NULL;
BOOLEAN bIsChild = FALSE;
ULONGLONG ullIndex = 0;
AFSObjectInfoCB *pObjectInfo = NULL;
LONG lCount;
@ -2473,8 +2461,6 @@ AFSInvalidateVolume( IN AFSVolumeCB *VolumeCB,
AFSObjectInfoCB *pCurrentObject = NULL;
AFSObjectInfoCB *pNextObject = NULL;
LONG lCount;
AFSFcb *pFcb = NULL;
ULONG ulFilter = 0;
__Enter
{
@ -3067,9 +3053,6 @@ AFSVerifyEntry( IN GUID *AuthGroup,
case AFS_FILE_TYPE_DIRECTORY:
{
AFSFcb *pCurrentFcb = NULL;
AFSDirectoryCB *pCurrentDirEntry = NULL;
//
// For a directory or root entry flush the content of
// the directory enumeration.
@ -3213,8 +3196,6 @@ AFSSetVolumeState( IN AFSVolumeStatusCB *VolumeStatus)
AFSDeviceExt *pDevExt = (AFSDeviceExt *) AFSRDRDeviceObject->DeviceExtension;
ULONGLONG ullIndex = 0;
AFSVolumeCB *pVolumeCB = NULL;
AFSFcb *pFcb = NULL;
AFSObjectInfoCB *pCurrentObject = NULL;
LONG lCount;
__Enter
@ -3334,7 +3315,6 @@ AFSValidateDirectoryCache( IN AFSObjectInfoCB *ObjectInfo,
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
BOOLEAN bAcquiredLock = FALSE;
AFSDirectoryCB *pCurrentDirEntry = NULL, *pNextDirEntry = NULL;
AFSFcb *pFcb = NULL;
__Enter
{
@ -4186,8 +4166,6 @@ AFSValidateEntry( IN AFSDirectoryCB *DirEntry,
case AFS_FILE_TYPE_DIRECTORY:
{
AFSDirectoryCB *pCurrentDirEntry = NULL;
if( pObjectInfo->DataVersion.QuadPart != pDirEnumEntry->DataVersion.QuadPart)
{
@ -4323,7 +4301,7 @@ AFSInitializeSpecialShareNameList()
pObjectInfoCB->ObjectReferenceCount = 1;
pObjectInfoCB->FileType = AFS_FILE_TYPE_SPECIAL_SHARE_NAME;
pObjectInfoCB->FileType = (ULONG) AFS_FILE_TYPE_SPECIAL_SHARE_NAME;
ulEntryLength = sizeof( AFSDirectoryCB) +
uniShareName.Length;
@ -4409,7 +4387,7 @@ AFSInitializeSpecialShareNameList()
pObjectInfoCB->ObjectReferenceCount = 1;
pObjectInfoCB->FileType = AFS_FILE_TYPE_SPECIAL_SHARE_NAME;
pObjectInfoCB->FileType = (ULONG) AFS_FILE_TYPE_SPECIAL_SHARE_NAME;
ulEntryLength = sizeof( AFSDirectoryCB) +
uniShareName.Length;
@ -5061,11 +5039,6 @@ AFSPopulateNameArray( IN AFSNameArrayHdr *NameArray,
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSNameArrayCB *pCurrentElement = NULL;
UNICODE_STRING uniComponentName, uniRemainingPath;
AFSObjectInfoCB *pCurrentObject = NULL;
ULONG ulTotalCount = 0;
ULONG ulIndex = 0;
USHORT usLength = 0;
LONG lCount;
__Enter
@ -5160,11 +5133,6 @@ AFSPopulateNameArrayFromRelatedArray( IN AFSNameArrayHdr *NameArray,
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSNameArrayCB *pCurrentElement = NULL, *pCurrentRelatedElement = NULL;
UNICODE_STRING uniComponentName, uniRemainingPath;
AFSObjectInfoCB *pObjectInfo = NULL;
ULONG ulTotalCount = 0;
ULONG ulIndex = 0;
USHORT usLength = 0;
LONG lCount;
__Enter
@ -5325,7 +5293,7 @@ AFSInsertNextElement( IN AFSNameArrayHdr *NameArray,
&DirectoryCB->NameInformation.FileName,
DirectoryCB->ObjectInformation->FileType);
if( NameArray->Count == NameArray->MaxElementCount)
if( NameArray->Count == (LONG) NameArray->MaxElementCount)
{
AFSDbgLogMsg( AFS_SUBSYSTEM_NAME_ARRAY_PROCESSING,
@ -5798,6 +5766,8 @@ AFSVerifyVolume( IN ULONGLONG ProcessId,
IN AFSVolumeCB *VolumeCB)
{
UNREFERENCED_PARAMETER(ProcessId);
UNREFERENCED_PARAMETER(VolumeCB);
NTSTATUS ntStatus = STATUS_SUCCESS;
@ -5834,7 +5804,7 @@ AFSInitPIOCtlDirectoryCB( IN AFSObjectInfoCB *ObjectInfo)
pObjectInfoCB->ObjectReferenceCount = 1;
pObjectInfoCB->FileType = AFS_FILE_TYPE_PIOCTL;
pObjectInfoCB->FileType = (ULONG) AFS_FILE_TYPE_PIOCTL;
pObjectInfoCB->FileAttributes = FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM;
@ -5959,8 +5929,8 @@ AFSRetrieveFileAttributes( IN AFSDirectoryCB *ParentDirectoryCB,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirEnumEntry *pDirEntry = NULL, *pLastDirEntry = NULL;
UNICODE_STRING uniFullPathName;
AFSDirEnumEntry *pDirEntry = NULL;
UNICODE_STRING uniFullPathName = {0};
AFSNameArrayHdr *pNameArray = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSDirectoryCB *pDirectoryEntry = NULL, *pParentDirEntry = NULL;
@ -6717,8 +6687,8 @@ AFSEvaluateRootEntry( IN AFSDirectoryCB *DirectoryCB,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirEnumEntry *pDirEntry = NULL, *pLastDirEntry = NULL;
UNICODE_STRING uniFullPathName;
AFSDirEnumEntry *pDirEntry = NULL;
UNICODE_STRING uniFullPathName = {0};
AFSNameArrayHdr *pNameArray = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSDirectoryCB *pDirectoryEntry = NULL, *pParentDirEntry = NULL;
@ -7403,7 +7373,6 @@ AFSReadCacheFile( IN void *ReadBuffer,
PIRP pIrp = NULL;
KEVENT kEvent;
PIO_STACK_LOCATION pIoStackLocation = NULL;
AFSDeviceExt *pRdrDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
DEVICE_OBJECT *pTargetDeviceObject = NULL;
FILE_OBJECT *pCacheFileObject = NULL;
@ -7544,6 +7513,8 @@ AFSIrpComplete( IN PDEVICE_OBJECT DeviceObject,
IN PVOID Context)
{
UNREFERENCED_PARAMETER(Irp);
UNREFERENCED_PARAMETER(DeviceObject);
KEVENT *pEvent = (KEVENT *)Context;
KeSetEvent( pEvent,
@ -7772,6 +7743,7 @@ AFSUnwindFileInfo( IN AFSFcb *Fcb,
IN AFSCcb *Ccb)
{
UNREFERENCED_PARAMETER(Fcb);
if( Ccb->FileUnwindInfo.FileAttributes != (ULONG)-1)
{
Ccb->DirectoryCB->ObjectInformation->FileAttributes = Ccb->FileUnwindInfo.FileAttributes;
@ -7836,7 +7808,7 @@ AFSValidateDirList( IN AFSObjectInfoCB *ObjectInfo)
pCurrentDirEntry = (AFSDirectoryCB *)pCurrentDirEntry->ListEntry.fLink;
}
if( ulCount != ObjectInfo->Specific.Directory.DirectoryNodeCount)
if( ulCount != (ULONG) ObjectInfo->Specific.Directory.DirectoryNodeCount)
{
AFSPrint("AFSValidateDirList Count off Calc: %d Stored: %d\n",
@ -8107,6 +8079,8 @@ AFSDefaultLogMsg( IN ULONG Subsystem,
...)
{
UNREFERENCED_PARAMETER(Subsystem);
UNREFERENCED_PARAMETER(Level);
NTSTATUS ntStatus = STATUS_SUCCESS;
va_list va_args;
char chDebugBuffer[ 256];
@ -8140,7 +8114,6 @@ AFSGetObjectStatus( IN AFSGetStatusInfoCB *GetStatusInfo,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSFcb *pFcb = NULL;
AFSVolumeCB *pVolumeCB = NULL;
AFSDeviceExt *pDevExt = (AFSDeviceExt *) AFSRDRDeviceObject->DeviceExtension;
AFSObjectInfoCB *pObjectInfo = NULL;
@ -8974,8 +8947,6 @@ AFSRetrieveParentPath( IN UNICODE_STRING *FullFileName,
OUT UNICODE_STRING *ParentPath)
{
USHORT usIndex = 0;
*ParentPath = *FullFileName;
//
@ -9110,7 +9081,6 @@ AFSPerformObjectInvalidate( IN AFSObjectInfoCB *ObjectInfo,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STATUS_BLOCK stIoStatus;
LIST_ENTRY *le;
AFSExtent *pEntry;
ULONG ulProcessCount = 0;

2
src/WINNT/afsrdr/kernel/lib/AFSInit.cpp
View File

@ -60,7 +60,6 @@ DriverEntry( PDRIVER_OBJECT DriverObject,
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt;
ULONG ulTimeIncrement = 0;
UNICODE_STRING uniDeviceName;
ULONG ulIndex = 0;
UNICODE_STRING uniRoutine;
@ -301,6 +300,7 @@ void
AFSUnload( IN PDRIVER_OBJECT DriverObject)
{
UNREFERENCED_PARAMETER(DriverObject);
if( AFSGlobalRoot != NULL)
{

1
src/WINNT/afsrdr/kernel/lib/AFSInternalDevControl.cpp
View File

@ -43,6 +43,7 @@ AFSInternalDevControl( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_NOT_IMPLEMENTED;
IO_STACK_LOCATION *pIrpSp;

10
src/WINNT/afsrdr/kernel/lib/AFSIoSupport.cpp
View File

@ -52,6 +52,7 @@ AFSGetExtents( IN AFSFcb *Fcb,
OUT ULONG *ExtentCount,
OUT ULONG *RunCount)
{
UNREFERENCED_PARAMETER(Fcb);
NTSTATUS ntStatus = STATUS_SUCCESS;
ULONG extentsCount = 0, runCount = 0;
AFSExtent *pEndExtent = NULL;
@ -104,6 +105,7 @@ AFSSetupIoRun( IN PDEVICE_OBJECT CacheDevice,
IN AFSExtent *From,
IN OUT ULONG *RunCount)
{
UNREFERENCED_PARAMETER(MasterIrp);
//
// Do all the work which we can prior to firing off the IRP
// (allocate them, calculate offsets and so on)
@ -114,8 +116,7 @@ AFSSetupIoRun( IN PDEVICE_OBJECT CacheDevice,
ULONG ulReadOffset;
ULONG ulCurrRun = 0;
AFSExtent *pExtent = From;
AFSExtent *pNextExtent;
PMDL *pMDL;
AFSExtent *pNextExtent = NULL;
BOOLEAN done = FALSE;
NTSTATUS ntStatus = STATUS_SUCCESS;
@ -245,6 +246,7 @@ CompletionFunction(IN PDEVICE_OBJECT DeviceObject,
PIRP Irp,
PVOID Context)
{
UNREFERENCED_PARAMETER(DeviceObject);
AFSGatherIo *pGather = (AFSGatherIo *) Context;
AFSCompleteIo( pGather, Irp->IoStatus.Status);
@ -273,7 +275,6 @@ AFSStartIos( IN PFILE_OBJECT CacheFileObject,
IN OUT AFSGatherIo *Gather)
{
AFSDeviceExt *pRdrDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
PIO_STACK_LOCATION pIoStackLocation = NULL;
PIRP pIrp;
NTSTATUS ntStatus = STATUS_SUCCESS;
@ -401,8 +402,7 @@ AFSProcessExtentRun( IN PVOID SystemBuffer,
ULONG ulOffset = 0;
ULONG ulCurrRun = 0;
AFSExtent *pExtent = From;
AFSExtent *pNextExtent;
PMDL *pMDL;
AFSExtent *pNextExtent = NULL;
BOOLEAN done = FALSE;
NTSTATUS ntStatus = STATUS_SUCCESS;

2
src/WINNT/afsrdr/kernel/lib/AFSLockControl.cpp
View File

@ -43,8 +43,8 @@ AFSLockControl( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
ULONG ulRequestType = 0;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSFcb *pFcb = NULL;
AFSCcb *pCcb = NULL;

9
src/WINNT/afsrdr/kernel/lib/AFSNameSupport.cpp
View File

@ -2063,9 +2063,9 @@ AFSCreateDirEntry( IN GUID *AuthGroup,
IN OUT AFSDirectoryCB **DirEntry)
{
UNREFERENCED_PARAMETER(FileName);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDirectoryCB *pDirNode = NULL, *pExistingDirNode = NULL;
UNICODE_STRING uniShortName;
LARGE_INTEGER liFileSize = {0,0};
LONG lCount;
@ -2745,7 +2745,7 @@ AFSParseName( IN PIRP Irp,
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
UNICODE_STRING uniFullName, uniComponentName, uniRemainingPath;
ULONG ulCRC = 0;
AFSDirectoryCB *pDirEntry = NULL, *pShareDirEntry = NULL, *pTargetDirEntry = NULL;
AFSDirectoryCB *pDirEntry = NULL;
USHORT usIndex = 0, usDriveIndex = 0;
AFSCcb *pRelatedCcb = NULL;
AFSNameArrayHdr *pNameArray = NULL, *pRelatedNameArray = NULL;
@ -3851,7 +3851,6 @@ AFSCheckCellName( IN GUID *AuthGroup,
NTSTATUS ntStatus = STATUS_SUCCESS;
UNICODE_STRING uniName;
AFSDirEnumEntry *pDirEnumEntry = NULL;
AFSDeviceExt *pDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
AFSDirHdr *pDirHdr = &AFSGlobalRoot->ObjectInformation.Specific.Directory.DirectoryNodeHdr;
AFSDirectoryCB *pDirNode = NULL;
UNICODE_STRING uniDirName, uniTargetName;
@ -4131,8 +4130,6 @@ AFSBuildMountPointTarget( IN GUID *AuthGroup,
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDevExt = (AFSDeviceExt *) AFSRDRDeviceObject->DeviceExtension;
AFSDirEnumEntry *pDirEntry = NULL;
AFSDirectoryCB *pDirNode = NULL;
UNICODE_STRING uniDirName, uniTargetName;
ULONGLONG ullIndex = 0;
AFSVolumeCB *pVolumeCB = NULL;
AFSFileID stTargetFileID;
@ -4399,8 +4396,6 @@ AFSBuildRootVolume( IN GUID *AuthGroup,
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDevExt = (AFSDeviceExt *) AFSRDRDeviceObject->DeviceExtension;
AFSDirectoryCB *pDirNode = NULL;
UNICODE_STRING uniDirName, uniTargetName;
ULONGLONG ullIndex = 0;
AFSVolumeCB *pVolumeCB = NULL;
LONG lCount;

8
src/WINNT/afsrdr/kernel/lib/AFSNetworkProviderSupport.cpp
View File

@ -47,7 +47,6 @@ AFSAddConnection( IN AFSNetworkProviderConnectionCB *ConnectCB,
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSProviderConnectionCB *pConnection = NULL, *pLastConnection = NULL;
UNICODE_STRING uniRemoteName;
USHORT usIndex = 0;
AFSDeviceExt *pRDRDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
__Enter
@ -1184,7 +1183,7 @@ AFSLocateEnumRootEntry( IN UNICODE_STRING *RemoteName)
{
AFSProviderConnectionCB *pConnection = NULL;
UNICODE_STRING uniServerName, uniRemoteName = *RemoteName;
UNICODE_STRING uniRemoteName = *RemoteName;
AFSDeviceExt *pRDRDevExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
__Enter
@ -1228,13 +1227,10 @@ AFSEnumerateConnection( IN OUT AFSNetworkProviderConnectionCB *ConnectCB,
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
ULONG ulCRC = 0, ulCopiedLength = 0;
AFSDirectoryCB *pShareDirEntry = NULL;
AFSDirectoryCB *pDirEntry = NULL, *pTargetDirEntry = NULL;
ULONG ulIndex = 0;
BOOLEAN bContinueProcessing = TRUE;
AFSFileInfoCB stFileInformation;
LONG lCount;
__Enter
@ -1494,7 +1490,7 @@ AFSGetConnectionInfo( IN AFSNetworkProviderConnectionCB *ConnectCB,
try_return( ntStatus = STATUS_DEVICE_NOT_READY);
}
uniFullName = uniRemoteName;
uniFullName = uniRemoteName;
if( uniRemoteName.Buffer[ 0] == L'\\' &&
uniRemoteName.Buffer[ 1] == L'\\')

2
src/WINNT/afsrdr/kernel/lib/AFSQuota.cpp
View File

@ -43,6 +43,7 @@ AFSQueryQuota( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;
@ -78,6 +79,7 @@ AFSSetQuota( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;

13
src/WINNT/afsrdr/kernel/lib/AFSRead.cpp
View File

@ -45,11 +45,10 @@ AFSCachedRead( IN PDEVICE_OBJECT DeviceObject,
IN LARGE_INTEGER StartingByte,
IN ULONG ByteCount)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
PFILE_OBJECT pFileObject = pIrpSp->FileObject;
AFSFcb *pFcb = (AFSFcb *)pFileObject->FsContext;
AFSCcb *pCcb = (AFSCcb *)pFileObject->FsContext2;
BOOLEAN bSynchronousIo = BooleanFlagOn( pFileObject->Flags, FO_SYNCHRONOUS_IO);
VOID *pSystemBuffer = NULL;
ULONG ulCurrentIO = 0, ulTotalLen = ByteCount;
@ -196,7 +195,6 @@ AFSNonCachedRead( IN PDEVICE_OBJECT DeviceObject,
PFILE_OBJECT pFileObject = pIrpSp->FileObject;
AFSFcb *pFcb = (AFSFcb *)pFileObject->FsContext;
AFSCcb *pCcb = (AFSCcb *)pFileObject->FsContext2;
BOOLEAN bSynchronousIo = IoIsOperationSynchronous(Irp);
VOID *pSystemBuffer = NULL;
BOOLEAN bPagingIo = BooleanFlagOn( Irp->Flags, IRP_PAGING_IO);
BOOLEAN bLocked = FALSE;
@ -206,12 +204,10 @@ AFSNonCachedRead( IN PDEVICE_OBJECT DeviceObject,
ULONG extentsCount = 0, runCount = 0;
AFSExtent *pStartExtent = NULL;
AFSExtent *pIgnoreExtent = NULL;
BOOLEAN bExtentsMapped = FALSE;
BOOLEAN bCompleteIrp = TRUE;
ULONG ulReadByteCount;
ULONG ulByteCount;
AFSDeviceExt *pDevExt = (AFSDeviceExt *)DeviceObject->DeviceExtension;
ULONG ulRequestCount = 0;
LARGE_INTEGER liCurrentTime, liLastRequestTime;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
PFILE_OBJECT pCacheFileObject = NULL;
@ -772,6 +768,7 @@ AFSRead( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
__try
@ -812,6 +809,7 @@ AFSCommonRead( IN PDEVICE_OBJECT DeviceObject,
IN HANDLE OnBehalfOf)
{
UNREFERENCED_PARAMETER(OnBehalfOf);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt;
IO_STACK_LOCATION *pIrpSp;
@ -823,11 +821,9 @@ AFSCommonRead( IN PDEVICE_OBJECT DeviceObject,
BOOLEAN bPagingIo = FALSE;
BOOLEAN bNonCachedIo = FALSE;
BOOLEAN bCompleteIrp = TRUE;
BOOLEAN bMapped;
PFILE_OBJECT pFileObject = NULL;
LARGE_INTEGER liStartingByte;
ULONG ulByteCount;
VOID *pSystemBuffer = NULL;
pIrpSp = IoGetCurrentIrpStackLocation( Irp);
pDeviceExt = (AFSDeviceExt *)DeviceObject->DeviceExtension;
@ -1331,6 +1327,7 @@ AFSIOCtlRead( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSPIOCtlIORequestCB stIORequestCB;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
@ -1468,8 +1465,8 @@ AFSShareRead( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSPIOCtlIORequestCB stIORequestCB;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSFcb *pFcb = NULL;
AFSCcb *pCcb = NULL;

2
src/WINNT/afsrdr/kernel/lib/AFSSecurity.cpp
View File

@ -43,6 +43,7 @@ AFSSetSecurity( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;
@ -77,6 +78,7 @@ AFSQuerySecurity( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
PIO_STACK_LOCATION pIrpSp;
PMDL pUserBufferMdl = NULL;

1
src/WINNT/afsrdr/kernel/lib/AFSShutdown.cpp
View File

@ -43,6 +43,7 @@ AFSShutdown( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;

2
src/WINNT/afsrdr/kernel/lib/AFSSystemControl.cpp
View File

@ -42,7 +42,7 @@ NTSTATUS
AFSSystemControl( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;

6
src/WINNT/afsrdr/kernel/lib/AFSVolumeInfo.cpp
View File

@ -43,10 +43,10 @@ AFSQueryVolumeInfo( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDeviceExt = (AFSDeviceExt *)AFSRDRDeviceObject->DeviceExtension;
IO_STACK_LOCATION *pIrpSp;
FS_INFORMATION_CLASS FsInformationClass;
FS_INFORMATION_CLASS FsInformationClass = FileFsMaximumInformation;
void *pBuffer = NULL;
ULONG ulLength = 0;
BOOLEAN bReleaseResource = FALSE;
@ -249,6 +249,7 @@ AFSSetVolumeInfo( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STACK_LOCATION *pIrpSp;
@ -416,6 +417,7 @@ AFSQueryFsAttributeInfo( IN AFSVolumeInfoCB *VolumeInfo,
IN PFILE_FS_ATTRIBUTE_INFORMATION Buffer,
IN OUT PULONG Length)
{
UNREFERENCED_PARAMETER(VolumeInfo);
NTSTATUS ntStatus = STATUS_SUCCESS;
RtlZeroMemory( Buffer,

11
src/WINNT/afsrdr/kernel/lib/AFSWorker.cpp
View File

@ -948,6 +948,7 @@ void
AFSPrimaryVolumeWorkerThread( IN PVOID Context)
{
UNREFERENCED_PARAMETER(Context);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSWorkQueueContext *pPoolContext = (AFSWorkQueueContext *)&AFSGlobalRoot->VolumeWorkerContext;
AFSDeviceExt *pControlDeviceExt = NULL;
@ -955,13 +956,11 @@ AFSPrimaryVolumeWorkerThread( IN PVOID Context)
LARGE_INTEGER DueTime;
LONG TimeOut;
KTIMER Timer;
BOOLEAN bFoundOpenEntry = FALSE;
AFSObjectInfoCB *pCurrentObject = NULL, *pNextObject = NULL, *pCurrentChildObject = NULL;
AFSDirectoryCB *pCurrentDirEntry = NULL, *pNextDirEntry = NULL;
BOOLEAN bReleaseVolumeLock = FALSE;
AFSVolumeCB *pVolumeCB = NULL, *pNextVolume = NULL;
AFSFcb *pFcb = NULL;
LONG lFileType;
LARGE_INTEGER liCurrentTime;
BOOLEAN bVolumeObject = FALSE;
BOOLEAN bFcbBusy = FALSE;
@ -1676,7 +1675,6 @@ AFSVolumeWorkerThread( IN PVOID Context)
AFSWorkQueueContext *pPoolContext = (AFSWorkQueueContext *)&pVolumeCB->VolumeWorkerContext;
AFSDeviceExt *pControlDeviceExt = NULL;
AFSDeviceExt *pRDRDeviceExt = NULL;
BOOLEAN exitThread = FALSE;
LARGE_INTEGER DueTime;
LONG TimeOut;
KTIMER Timer;
@ -1914,7 +1912,6 @@ AFSWorkItem *
AFSRemoveWorkItem()
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSWorkItem *pWorkItem = NULL;
AFSDeviceExt *pDevExt = NULL;
LONG lCount;
@ -1973,7 +1970,6 @@ AFSWorkItem *
AFSRemoveIOWorkItem()
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSWorkItem *pWorkItem = NULL;
AFSDeviceExt *pDevExt = NULL;
LONG lCount;
@ -2033,7 +2029,6 @@ AFSQueueWorkerRequest( IN AFSWorkItem *WorkItem)
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDevExt = NULL;
BOOLEAN bWait = BooleanFlagOn( WorkItem->RequestFlags, AFS_SYNCHRONOUS_REQUEST);
//
@ -2064,7 +2059,6 @@ AFSQueueIOWorkerRequest( IN AFSWorkItem *WorkItem)
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDevExt = NULL;
BOOLEAN bWait = BooleanFlagOn( WorkItem->RequestFlags, AFS_SYNCHRONOUS_REQUEST);
//
@ -2095,7 +2089,6 @@ AFSQueueWorkerRequestAtHead( IN AFSWorkItem *WorkItem)
{
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSDeviceExt *pDevExt = NULL;
BOOLEAN bWait = BooleanFlagOn( WorkItem->RequestFlags, AFS_SYNCHRONOUS_REQUEST);
//
@ -2256,7 +2249,7 @@ try_exit:
lCount = InterlockedDecrement( &Fcb->Specific.File.QueuedFlushCount);
ASSERT( lCount >= 0);
ASSERT( lCount >= 0);
if( lCount == 0)
{

22
src/WINNT/afsrdr/kernel/lib/AFSWrite.cpp
View File

@ -74,6 +74,7 @@ AFSWrite( IN PDEVICE_OBJECT LibDeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(LibDeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
__try
@ -114,7 +115,6 @@ AFSCommonWrite( IN PDEVICE_OBJECT DeviceObject,
BOOLEAN bCompleteIrp = TRUE;
BOOLEAN bLockOK;
HANDLE hCallingUser = OnBehalfOf;
ULONG ulExtensionLength = 0;
BOOLEAN bRetry = FALSE;
ULONGLONG ullProcessId = (ULONGLONG)PsGetCurrentProcessId();
@ -720,6 +720,7 @@ AFSIOCtlWrite( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSPIOCtlIORequestCB stIORequestCB;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
@ -870,7 +871,6 @@ AFSNonCachedWrite( IN PDEVICE_OBJECT DeviceObject,
BOOLEAN bPagingIo = BooleanFlagOn( Irp->Flags, IRP_PAGING_IO);
BOOLEAN bLocked = FALSE;
BOOLEAN bCompleteIrp = TRUE;
BOOLEAN bExtentsMapped = FALSE;
AFSGatherIo *pGatherIo = NULL;
AFSIoRun *pIoRuns = NULL;
AFSIoRun stIoRuns[AFS_MAX_STACK_IO_RUNS];
@ -883,7 +883,6 @@ AFSNonCachedWrite( IN PDEVICE_OBJECT DeviceObject,
AFSCcb *pCcb = (AFSCcb *)pFileObject->FsContext2;
BOOLEAN bSynchronousFo = BooleanFlagOn( pFileObject->Flags, FO_SYNCHRONOUS_IO);
AFSDeviceExt *pDevExt = (AFSDeviceExt *)DeviceObject->DeviceExtension;
ULONG ulRequestCount = 0;
LARGE_INTEGER liCurrentTime, liLastRequestTime;
AFSDeviceExt *pControlDevExt = (AFSDeviceExt *)AFSControlDeviceObject->DeviceExtension;
PFILE_OBJECT pCacheFileObject = NULL;
@ -1368,13 +1367,13 @@ try_exit:
Irp->IoStatus.Information > 0)
{
if ( !bLocked)
{
if ( !bLocked)
{
AFSAcquireShared( &pFcb->NPFcb->Specific.File.ExtentsResource,
TRUE);
bLocked = TRUE;
}
AFSAcquireShared( &pFcb->NPFcb->Specific.File.ExtentsResource,
TRUE);
bLocked = TRUE;
}
//
// Since this is dirty we can mark the extents dirty now.
@ -1465,15 +1464,14 @@ AFSCachedWrite( IN PDEVICE_OBJECT DeviceObject,
IN ULONG ByteCount,
IN BOOLEAN ForceFlush)
{
UNREFERENCED_PARAMETER(DeviceObject);
PVOID pSystemBuffer = NULL;
NTSTATUS ntStatus = STATUS_SUCCESS;
IO_STATUS_BLOCK iosbFlush;
IO_STACK_LOCATION *pIrpSp = IoGetCurrentIrpStackLocation( Irp);
PFILE_OBJECT pFileObject = pIrpSp->FileObject;
AFSFcb *pFcb = (AFSFcb *)pFileObject->FsContext;
AFSCcb *pCcb = (AFSCcb *)pFileObject->FsContext2;
BOOLEAN bSynchronousFo = BooleanFlagOn( pFileObject->Flags, FO_SYNCHRONOUS_IO);
BOOLEAN bMapped = FALSE;
ULONG ulCurrentIO = 0, ulTotalLen = ByteCount;
PMDL pCurrentMdl = Irp->MdlAddress;
LARGE_INTEGER liCurrentOffset;
@ -1778,8 +1776,8 @@ AFSShareWrite( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp)
{
UNREFERENCED_PARAMETER(DeviceObject);
NTSTATUS ntStatus = STATUS_SUCCESS;
AFSPIOCtlIORequestCB stIORequestCB;
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
AFSFcb *pFcb = NULL;
AFSCcb *pCcb = NULL;

3
src/WINNT/afsrdr/kernel/lib/Include/AFSCommon.h
View File

@ -512,6 +512,7 @@ AFSProcessExtentRun( IN PVOID SystemBuffer,
// AFSClose.cpp Prototypes
//
NTSTATUS
AFSClose( IN PDEVICE_OBJECT DeviceObject,
IN PIRP Irp);
@ -1100,7 +1101,7 @@ AFSLockSystemBuffer( IN PIRP Irp,
void *
AFSLockUserBuffer( IN void *UserBuffer,
IN ULONG BufferLength,
OUT MDL ** Mdl);
OUT MDL ** Mdl);
void *
AFSMapToService( IN PIRP Irp,