jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 15:30:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libadmin/vos/vosutils.c: mask out sign-extension

Browse Source 
Right-shifting a signed int by 24 bits can produce a value outside of
0..0xff due to sign-extension.  As a result, in AddressMatch(), the
first bPattern!=255 check can never succeed.  Fix by masking with 255
before comparison.

Change-Id: Idb0b4c176ff120c7cf0e03a935ebfdca51084bbd
Reviewed-on: http://gerrit.openafs.org/8884
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
This commit is contained in:
Nickolai Zeldovich 2013-01-05 23:45:59 -05:00 committed by Jeffrey Altman
parent bd850e5b98
commit 8e8e3c26b8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libadmin/vos/vosutils.c
View File

@ -568,8 +568,8 @@ AddressMatch(int addrTest, int addrPattern)
int bPattern;
/* Test the high byte */
bTest = addrTest >> 24;
bPattern = addrPattern >> 24;
bTest = (addrTest >> 24) & 255;
bPattern = (addrPattern >> 24) & 255;
if ((bTest != bPattern) && (bPattern != 255)) {
return FALSE;
}