jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fs: Still print fid for 'getfid' if GetCell fails

Browse Source 
Currently, 'fs getfid' fails if we cannot get the cell for the given
file via GetCell(). This GetCell call was added in commit d390df097c (fs
getfid output changed for consistency with Windows implementation) to be
more similar to the WINNT 'fs getfid', but the WINNT 'fs getfid' still
prints the fid if getting the cell fails (and has since it was
introduced in commit 5520747790 (windows-fs-getfid-20090511)).

GetCell() shouldn't normally fail if getting the fid succeeded, but in
case it does, don't prevent us from printing the fid. Change 'fs
getfid' to just say the cell is "unknown-cell" and keep going.

Change-Id: Idd4727304061e1ec4eeddd98bd9eaab5de96e2b6
Reviewed-on: https://gerrit.openafs.org/15585
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
This commit is contained in:
Andrew Deason 2023-09-29 16:46:14 -05:00
parent cad39264b6
commit 93036c852d
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/venus/fs.c
View File

@ -4294,12 +4294,7 @@ GetFidCmd(struct cmd_syndesc *as, void *arock)
code = GetCell(ti->data, cell);
}
if (code) {
if (errno == ENOENT)
fprintf(stderr, "%s: no such cell as '%s'\n", pn, ti->data);
else
Die(errno, ti->data);
error = 1;
goto next_item;
strlcpy(cell, "unknown-cell", sizeof(cell));
}
printf("File %s (%u.%u.%u) located in cell %s\n",