diff --git a/CODING b/CODING index 0881c98e38..6a1af05659 100644 --- a/CODING +++ b/CODING @@ -262,7 +262,6 @@ libadmin/kas/afs_kasAdmin.c: strict-proto : ubik_Call nonsense libadmin/samples/rxstat_query_peer.c : all : util_RPCStatsStateGet types libadmin/samples/rxstat_query_process.c : all : util_RPCStatsStateGet types libadmin/test/client.c : all : util_RPCStatsStateGet types -rxkad/ticket5.c : all : v5gen.c has set-but-unused variables ubik/ubikclient.c : strict-protos : ubik_Call volser/vol-dump.c : format : afs_sfsize_t diff --git a/src/rxkad/Makefile.in b/src/rxkad/Makefile.in index 9ecf4e4b28..8f60b9e3d8 100644 --- a/src/rxkad/Makefile.in +++ b/src/rxkad/Makefile.in @@ -81,8 +81,6 @@ liboafs_rxkad.la: liboafs_rxkad.la.sym $(LT_objs) $(LT_deps) librxkad_pic.la: $(LT_objs) $(LT_LDLIB_pic) $(LT_objs) -CFLAGS_ticket5.lo = @CFLAGS_NOERROR@ - crc.lo: crc.c ${INCLS} crypt_conn.lo: crypt_conn.c fcrypt.h private_data.h ${INCLS} fcrypt.lo: fcrypt.c fcrypt.h sboxes.h rxkad.h rxkad_prototypes.h diff --git a/src/rxkad/ticket5.c b/src/rxkad/ticket5.c index 5a53163273..7b8eb5082d 100644 --- a/src/rxkad/ticket5.c +++ b/src/rxkad/ticket5.c @@ -198,7 +198,7 @@ tkt_DecodeTicket5(char *ticket, afs_int32 ticket_len, Ticket t5; /* Must free */ EncTicketPart decr_part; /* Must free */ int code; - size_t siz, plainsiz; + size_t siz, plainsiz = 0; int v5_serv_kvno; char *v5_comp0, *v5_comp1, *c; const struct krb_convert *p; @@ -536,7 +536,7 @@ tkt_MakeTicket5(char *ticket, int *ticketLen, int enctype, int *kvno, { EncTicketPart data; EncryptedData encdata; - char *buf, *encodebuf; + unsigned char *buf, *encodebuf; size_t encodelen, allocsiz; heim_general_string carray[2]; int code; @@ -599,7 +599,7 @@ tkt_MakeTicket5(char *ticket, int *ticketLen, int enctype, int *kvno, goto cleanup; } tl=*ticketLen; - code = encode_EncryptedData(ticket + *ticketLen - 1, *ticketLen, &encdata, &tl); + code = encode_EncryptedData((unsigned char *)ticket + *ticketLen - 1, *ticketLen, &encdata, &tl); if (code == 0) { *kvno=RXKAD_TKT_TYPE_KERBEROS_V5_ENCPART_ONLY; /*