jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-21 00:10:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmd: Use strl* rather than strn* to avoid overrun

Browse Source 
The NName function was using strncat(a, b, sizeof(a)), which doesn't
work as you would expect if 'a' already contains data. To avoid the
potential buffer overflow, switch to just using strlcat.

Caught by clang-analyzer

Change-Id: Idd2c630c07a93b27e8d629339589aa6686290eae
Reviewed-on: http://gerrit.openafs.org/7092
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
This commit is contained in:
Simon Wilkinson 2012-03-31 06:58:01 -04:00 committed by Derrick Brashear
parent b5ebfec329
commit 9a007a9df4
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cmd/cmd.c
View File

@ -42,9 +42,8 @@ NName(char *a1, char *a2)
if (strlen(a1) == 0) {
return "";
} else {
strncpy(tbuffer, a1, sizeof(tbuffer));
strncat(tbuffer, a2, sizeof(tbuffer));
tbuffer[sizeof(tbuffer)-1]='\0';
strlcpy(tbuffer, a1, sizeof(tbuffer));
strlcat(tbuffer, a2, sizeof(tbuffer));
return tbuffer;
}
}