jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 07:20:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vos: Avoid LWP stack overflow error on SIGINT

Browse Source 
vsproc's method of longjmp'ing out of a signal handler can thoroughly
confuse LWP. At the very least, the information on our stack becomes
incorrect, since we're no longer using the stack supplied by LWP. At the
very least, we seem to (almost) always fail the sanity check checking
for stack overflow. To prevent the test from happening, NULL the stack
pointer before the longjmp so we can attempt recovery.

FIXES 33360

Change-Id: Ie910cb1cc8564ac119c3b751fd8295bf312a3ce7
Reviewed-on: http://gerrit.openafs.org/1559
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Andrew Deason 2010-03-10 14:15:58 -06:00 committed by Derrick Brashear
parent bf2d0db680
commit 9af8d46e77
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/volser/vsprocs.c
View File

@ -1146,8 +1146,16 @@ int interrupt = 0;
static void *
do_interrupt(void * unused)
{
if (interrupt)
if (interrupt) {
#ifndef AFS_PTHREAD_ENV
/* Avoid LWP from getting confused that our stack has suddenly
* changed. This will avoid some sanity checks, but until a better way
* is found, the only alternative is always crashing and burning on at
* least the stack-overflow check. */
lwp_cpptr->stack = NULL;
#endif
longjmp(env, 0);
}
fprintf(STDOUT, "\nSIGINT handler: vos move operation in progress\n");
fprintf(STDOUT,