jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 23:10:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

windows-afsd-volume-ref-leak-20070202

Browse Source 
When looking up a volume by ID or Name, if the volume server data requires
refreshing and the UpdateVolume operation failed, do not leak the refCount.
This commit is contained in:
Jeffrey Altman 2007-02-02 15:43:07 +00:00
parent 38d6f48507
commit ab294cfdc5
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/WINNT/afsd/cm_volume.c
View File

@ -373,7 +373,7 @@ long cm_GetVolumeByID(cm_cell_t *cellp, long volumeID, cm_user_t *userp,
{
cm_volume_t *volp;
char volNameString[100];
long code;
long code = 0;
lock_ObtainWrite(&cm_volumeLock);
for(volp = cm_data.allVolumesp; volp; volp=volp->nextp) {
@ -393,17 +393,18 @@ long cm_GetVolumeByID(cm_cell_t *cellp, long volumeID, cm_user_t *userp,
if (volp) {
lock_ObtainMutex(&volp->mx);
code = 0;
if (volp->flags & CM_VOLUMEFLAG_RESET) {
code = cm_UpdateVolume(cellp, userp, reqp, volp);
if (code == 0) {
if (code == 0)
volp->flags &= ~CM_VOLUMEFLAG_RESET;
}
}
else
code = 0;
lock_ReleaseMutex(&volp->mx);
if (code == 0)
if (code == 0)
*outVolpp = volp;
else
cm_PutVolume(volp);
return code;
}
@ -419,11 +420,8 @@ long cm_GetVolumeByName(struct cm_cell *cellp, char *volumeNamep,
long flags, cm_volume_t **outVolpp)
{
cm_volume_t *volp;
long code;
long code = 0;
/* initialize this */
code = 0;
lock_ObtainWrite(&cm_volumeLock);
for (volp = cm_data.allVolumesp; volp; volp=volp->nextp) {
if (cellp == volp->cellp && strcmp(volumeNamep, volp->namep) == 0) {
@ -480,6 +478,9 @@ long cm_GetVolumeByName(struct cm_cell *cellp, char *volumeNamep,
if (code == 0)
*outVolpp = volp;
else
cm_PutVolume(volp);
lock_ReleaseMutex(&volp->mx);
return code;
}