From ab866c821a705d7911e0ff8ac987249efdc63435 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Mon, 10 Oct 2011 19:01:26 -0500 Subject: [PATCH] dir: Remove double release in FindBlobs When DRead() fails, we DRelease the entrybuf, then break. However, this break takes us to the end of the function, where we promptly DRelease again, causing a double free Change-Id: I5a0293990e01376525d8adae25477c64e2cc93ad Reviewed-on: http://gerrit.openafs.org/5655 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/dir/dir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/dir/dir.c b/src/dir/dir.c index 9e31cee4a5..521145b195 100644 --- a/src/dir/dir.c +++ b/src/dir/dir.c @@ -235,7 +235,6 @@ FindBlobs(dir_file_t dir, int nblobs) /* read the page in. */ if (DRead(dir, i, &pagebuf) != 0) { - DRelease(&headerbuf, 1); break; } pp = (struct PageHeader *)pagebuf.data;