jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

FBSD: Cast afs_symlink target to char*

Browse Source 
FreeBSD commit 1493c2ee62b8cbd8dbe70670b9108b4b9c36e032 (Make
vop_symlink take a const target path.) changed the 'target' argument
of vop_symlink to be a 'const char*' (from 'char*'). This causes a
warning:

    .../src/afs/FBSD/osi_vnodeops.c:1099:44: error: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
            afs_symlink(VTOAFS(dvp), name, ap->a_vap, ap->a_target, NULL,
                                                      ^~~~~~~~~~~~
    .../src/afs/afs_prototypes.h:1328:37: note: passing argument to parameter 'atargetName' here
                           struct vattr *attrs, char *atargetName,

Just cast to 'char*' explicitly to get rid of the warning.

Ideally we would change afs_symlink() to accept a 'const char*', but
that involves a lot of changes to cross-platform code; keep things
simple for now.

Change-Id: Iaa2d18a3168827c45908d44328f90425c9d1cb12
Reviewed-on: https://gerrit.openafs.org/15171
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
This commit is contained in:
Andrew Deason 2022-10-25 16:37:41 -05:00
parent 1f3f754c01
commit ad7a5ba333
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/afs/FBSD/osi_vnodeops.c
View File

@ -1096,7 +1096,7 @@ afs_vop_symlink(struct vop_symlink_args *ap)
newvp = NULL;
error =
afs_symlink(VTOAFS(dvp), name, ap->a_vap, ap->a_target, NULL,
afs_symlink(VTOAFS(dvp), name, ap->a_vap, (char*)ap->a_target, NULL,
cnp->cn_cred);
if (error == 0) {
error = afs_lookup(VTOAFS(dvp), name, &vcp, cnp->cn_cred);