From b604ee7add7be416bf20973422a041e913d20761 Mon Sep 17 00:00:00 2001 From: Mark Vitale Date: Tue, 26 Jun 2018 05:26:21 -0400 Subject: [PATCH] OPENAFS-SA-2018-002 kaserver: prevent KAM_ListEntry information leak KAM_ListEntry (kas list) does not initialize its output correctly. It leaks kaserver memory contents over the wire: struct kaindex - up to 64 bytes for member name - up to 64 bytes for member instance Initialize the buffer. [kaduk@mit.edu: move initialization to top of server routine] Change-Id: I5cc430fc996e7e89d38a384d092b9d4fad248fa4 --- src/kauth/kaprocs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/kauth/kaprocs.c b/src/kauth/kaprocs.c index 315096a461..1c6c68f972 100644 --- a/src/kauth/kaprocs.c +++ b/src/kauth/kaprocs.c @@ -1700,6 +1700,7 @@ kamListEntry(struct rx_call *call, afs_int32 caller; struct kaentry tentry; + memset(name, 0, sizeof(*name)); COUNT_REQ(ListEntry); if ((code = InitAuthServ(&tt, LOCKREAD, this_op))) return code;