From b7ed23f479e3b62f5b5005c0ab632333f311f12f Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 30 Mar 2012 19:39:51 +0100 Subject: [PATCH] rx: Remove needless braces Doing if ((a==b)) is unecessary. It's also potentially dangerous, as that's the syntax required to do assignment within an if statement. clang now issues warnings (errors in -Werror mode) when it encounters these. Remove pointless braces from the Unix CM to make clang happy. Reviewed-on: http://gerrit.openafs.org/7088 Tested-by: Simon Wilkinson Reviewed-by: Derrick Brashear (cherry picked from commit 5e107724f3661254cfdb693ae2d4d1c5238eba7d) Change-Id: I82833f58df0fa54234a04796bee8ae464e001ac6 Reviewed-on: http://gerrit.openafs.org/7158 Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/rx/rx_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rx/rx_user.c b/src/rx/rx_user.c index e54e15d731..2cc9c2d14a 100644 --- a/src/rx/rx_user.c +++ b/src/rx/rx_user.c @@ -609,7 +609,7 @@ rx_GetIFInfo(void) fudge_netmask(rxi_NetAddrs[rxi_numNetAddrs]); #ifdef SIOCGIFNETMASK res = ioctl(s, SIOCGIFNETMASK, ifr); - if ((res == 0)) { + if (res == 0) { a = (struct sockaddr_in *)&ifr->ifr_addr; myNetMasks[rxi_numNetAddrs] = ntohl(a->sin_addr.s_addr); /* fprintf(stderr, "if %s subnetmask=0x%x\n",