jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

afs: Avoid NatPing event on all connection

Browse Source 
Inside release_conns_user_server, connection vector is traversed and after
destroying a connection new eligible connection is found on which NatPing
event will be set. Ideally there should be only one connection on which
NatPing should be set but in current code while traversing all connection
of server a NatPing event is set on all connections to that server. In
cases where we have large number of connection to a server this can lead
to huge number of “RX_PACKET_TYPE_VERSION” packets sent to a server.
Since this happen during Garbage collection of user structs, to simulate
this issue below steps were tried

  - had one script which “cd” to a volume mount and then script sleeps for
    large time.
  - Ran one infinite while loop where above script was called using PAG
    based tokens (As new connection will be created for each PAG)
  - Instrumented the code, so that we hit above code segment where NatPing
    event is set. Mainly reduced NOTOKTIMEOUT to 60 sec.

To fix this issue set NatPing on one connection and once it is set break
from “for” loop traversing the server connection.

Change-Id: Ia38cec0403fde76cdd59aa664bd261481e2edee6
Reviewed-on: https://gerrit.openafs.org/14312
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
This commit is contained in:
Yadavendra Yadav 2020-08-21 01:54:00 +05:30 committed by Benjamin Kaduk
parent 291bad659e
commit b968875a34
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/afs/afs_conn.c
View File

@ -152,7 +152,10 @@ release_conns_user_server(struct unixuser *xu, struct server *xs)
if (sa->natping == tc) {
int cin;
struct afs_conn *tcn;
sa->natping = NULL;
for (tcvn = sa->conns; tcvn; tcvn = tcvn->next) {
if (sa->natping != NULL)
break;
if (tcvn == tcv)
continue;
for(cin = 0; cin < CVEC_LEN; ++cin) {