From ba51b43e3558058b949ccc5de1d4559e4caf9d9b Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Mon, 31 Jan 2011 15:00:09 -0600 Subject: [PATCH] Rx: Do not stop keepalives on ACKALL receipt We need to still keep sending periodic keepalives after receiving an ACKALL, since the call is not done yet. ACKALLs can be received when the peer has received all data from us, well before the call has finished. This is particularly noticeable for long-lived calls that have little data transfer, such as AFSVolForward and AFSVolForwardMultiple. This reverts commit b1549f29a9515de09d4a64bfb28bf5afdfee2615, which was intended to be part of a fix for RT 20727. FIXES 128848 Change-Id: I319e6e95d699ea87ecc72888452b5e1e6fcd88b0 Reviewed-on: http://gerrit.openafs.org/3876 Tested-by: Andrew Deason Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/rx/rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/rx/rx.c b/src/rx/rx.c index fa9c9a1f97..3d4d7be653 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -3419,7 +3419,6 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket, } #endif /* AFS_GLOBAL_RXLOCK_KERNEL */ rxi_ClearTransmitQueue(call, 0); - rxevent_Cancel(call->keepAliveEvent, call, RX_CALL_REFCOUNT_ALIVE); break; default: /* Should not reach here, unless the peer is broken: send an abort