From bbf92017b084a8ba8df81effe06d11421cdf4bb0 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Mon, 16 Jul 2012 16:53:32 -0400 Subject: [PATCH] rx: rxi_ReceiveDataPacket do not set rprev on drop In KERNEL builds if there are no available packet buffers the new packet is dropped on the floor. In that case, the call's rprev field should not be updated because the packet was never "received" for delivery to the application. Remove a dead comment from the same block of code. Change-Id: I12a2b1618a430880d18efee48e6348e6f9ba8119 Reviewed-on: http://gerrit.openafs.org/7784 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/rx/rx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/rx/rx.c b/src/rx/rx.c index 8691f96618..0fdeb5a227 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -3851,15 +3851,12 @@ rxi_ReceiveDataPacket(struct rx_call *call, MUTEX_EXIT(&rx_freePktQ_lock); if (rx_stats_active) rx_atomic_inc(&rx_stats.noPacketBuffersOnRead); - call->rprev = np->header.serial; rxi_calltrace(RX_TRACE_DROP, call); dpf(("packet %"AFS_PTR_FMT" dropped on receipt - quota problems\n", np)); /* We used to clear the receive queue here, in an attempt to free * packets. However this is unsafe if the queue has received a * soft ACK for the final packet */ rxi_PostDelayedAckEvent(call, &rx_softAckDelay); - - /* we've damaged this call already, might as well do it in. */ return np; } #endif /* KERNEL */