mirror of
https://git.openafs.org/openafs.git
synced 2025-01-18 15:00:12 +00:00
OPENAFS-SA-2018-002 butc: prevent TC_ReadLabel information leak
TC_ReadLabel (backup readlabel) does not initialize its output buffer completely. It leaks butc memory contents over the wire: struct tc_tapeLabel - up to 32 bytes from member afsname (TC_MAXTAPELEN 32) - up to 32 bytes from member pname (TC_MAXTAPELEN 32) Initialize the buffer. [kaduk@mit.edu: move initialization to the RPC stub] (cherry picked from commit52f4d63148
) (cherry picked from commitb7e53b9e97
) (cherry picked from commit3e0294543d
) Change-Id: I4e8ab1b94d36e9904a9505cd7f0e97cc6fb3a40f
This commit is contained in:
parent
5c6589b395
commit
bd86cbcfd9
@ -388,6 +388,7 @@ STC_ReadLabel(struct rx_call *acid, struct tc_tapeLabel *label, afs_uint32 *task
|
||||
{
|
||||
afs_int32 code;
|
||||
|
||||
memset(label, 0, sizeof(*label));
|
||||
#ifdef xbsa
|
||||
if (CONF_XBSA)
|
||||
return (TC_BADTASK); /* ReadLabel does not apply if XBSA */
|
||||
|
Loading…
Reference in New Issue
Block a user