jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

afs: Remove SRXAFSCB_FetchData/StoreData

Browse Source 
Commit 'client-64bit-file-size-support-20011031' (971b18bc42) introduced
the RPC functions SRXAFSCB_FetchData() and SRXAFSCB_StoreData with RPC
numbers of 65536 and 65537 respectively.

Commit 'more-64bit-file-size-support-20011031' (c5b1a3775f) removed the
references from afscbint.xg, but did not remove the actual code. The
65536 RPC number was reassigned to SRXAFSCB_GetCE64, and the commit:
'This is mostly a rewrite of src/afs/afs_cell.c, and associated changes'
(629d08065) assigned the 65537 RPC to SRXAFSCB_GetCellByNum.

Remove the 2 functions since there are no references other than the
prototype in afs_prototypes.h.

This function is flagged due to a missing prototype when building
against a Linux 6.8 kernel (which sets the -Wmissing-declarations and
-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:
 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).

Reviewed-on: https://gerrit.openafs.org/15639
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 379f7fc51d411990189ec28e48c91edc87d76120)

Change-Id: I1a3539227d22e6df89d78245634dfeb14943035a
Reviewed-on: https://gerrit.openafs.org/15688
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
This commit is contained in:
Cheyenne Wills 2024-02-08 12:22:13 -07:00 committed by Benjamin Kaduk
parent bb7eaafb2e
commit be8001f1d6
2 changed files with 0 additions and 72 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
src/afs/afs_callback.c
View File

@ -1472,71 +1472,6 @@ SRXAFSCB_GetCacheConfig(struct rx_call *a_call, afs_uint32 callerVersion,
return 0;
}
/*------------------------------------------------------------------------
* EXPORTED SRXAFSCB_FetchData
*
* Description:
* Routine to do third party move from a remioserver to the original
* issuer of an ArchiveData request. Presently supported only by the
* "fs" command, not by the AFS client.
*
* Arguments:
* rxcall: Ptr to Rx call on which this request came in.
* Fid: pointer to AFSFid structure.
* Fd: File descriptor inside fs command.
* Position: Offset in the file.
* Length: Data length to transfer.
* TotalLength: Pointer to total file length field
*
* Returns:
* 0 on success
*
* Environment:
* Nothing interesting.
*
* Side Effects:
*------------------------------------------------------------------------*/
int
SRXAFSCB_FetchData(struct rx_call *rxcall, struct AFSFid *Fid, afs_int32 Fd,
afs_int64 Position, afs_int64 Length,
afs_int64 * TotalLength)
{
return ENOSYS;
}
/*------------------------------------------------------------------------
* EXPORTED SRXAFSCB_StoreData
*
* Description:
* Routine to do third party move from a remioserver to the original
* issuer of a RetrieveData request. Presently supported only by the
* "fs" command, not by the AFS client.
*
* Arguments:
* rxcall: Ptr to Rx call on which this request came in.
* Fid: pointer to AFSFid structure.
* Fd: File descriptor inside fs command.
* Position: Offset in the file.
* Length: Data length to transfer.
* TotalLength: Pointer to total file length field
*
* Returns:
* 0 on success
*
* Environment:
* Nothing interesting.
*
* Side Effects:
* As advertised.
*------------------------------------------------------------------------*/
int
SRXAFSCB_StoreData(struct rx_call *rxcall, struct AFSFid *Fid, afs_int32 Fd,
afs_int64 Position, afs_int64 Length,
afs_int64 * TotalLength)
{
return ENOSYS;
}
/*------------------------------------------------------------------------
* EXPORTED SRXAFSCB_GetCellByNum
*

7
src/afs/afs_prototypes.h
View File

@ -103,13 +103,6 @@ extern int SRXAFSCB_GetCacheConfig(struct rx_call *a_call,
afs_uint32 * serverVersion,
afs_uint32 * configCount,
cacheConfig * config);
extern int SRXAFSCB_FetchData(struct rx_call *rxcall, struct AFSFid *Fid,
afs_int32 Fd, afs_int64 Position,
afs_int64 Length, afs_int64 * TotalLength);
extern int SRXAFSCB_StoreData(struct rx_call *rxcall, struct AFSFid *Fid,
afs_int32 Fd, afs_int64 Position,
afs_int64 Length, afs_int64 * TotalLength);
/* afs_cbqueue.c */
extern afs_rwlock_t afs_xcbhash;