jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Solaris: do not call VFS_RELE with GLOCK

Browse Source 
VFS_RELE can call afs_freevfs, which grabs GLOCK. Thus, don't call
VFS_RELE with GLOCK held or we can try to recursively acquire GLOCK
and panic.  This is currently unlikely to occur (sans vfs refcount
unbalances) without support for forced unmounts, since the last vfs
ref will usually come from the caller of afs_unmount(). But it still
may be possible.

Change-Id: I152bd13abc2e90f258f98194833c50c3a2846904
Reviewed-on: http://gerrit.openafs.org/1966
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Andrew Deason 2010-05-15 23:12:33 -05:00 committed by Derrick Brashear
parent 7e32fbea90
commit c0afd1419d
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/afs/SOLARIS/osi_vnodeops.c
View File

@ -1817,7 +1817,11 @@ afs_inactive(struct vcache *avc, afs_ucred_t *acred)
afs_InactiveVCache(avc, acred);
#ifdef AFS_SUN58_ENV
AFS_GUNLOCK();
/* VFS_RELE must be called outside of GLOCK, since it can potentially
* call afs_freevfs, which acquires GLOCK */
VFS_RELE(afs_globalVFS);
AFS_GLOCK();
#endif
return 0;