jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-20 16:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixes for signed char architectures

Browse Source 
"char" is unsigned on s390x, which causes a few warnings where we
test for negative values.

Add a signed modifier in a few cases, and in vos.c replace with an
int to match a similar section of code in the same file.

Mostly a warning fix, but in one case the variable could be used
to return a -1 error value, so it may have caused an actual bug.

Change-Id: I005fbcd7c573735df7403316ec0ced67ee81e559
Reviewed-on: http://gerrit.openafs.org/2602
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Marc Dionne 2010-08-20 16:37:56 -04:00 committed by Derrick Brashear
parent 850567f172
commit c2be1ee1d7
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/afs/afs.h
View File

@ -104,7 +104,7 @@ extern afs_int32 afs_rx_idledead;
struct sysname_info {
char *name;
short offset;
char index, allocked;
signed char index, allocked;
};
/* flags to use with AFSOP_CACHEINIT */

2
src/rxkad/rxkad.p.h
View File

@ -74,7 +74,7 @@ typedef char rxkad_type;
#define rxkad_client 1 /* bits definitions */
#define rxkad_server 2
typedef char rxkad_level;
typedef signed char rxkad_level;
#define rxkad_clear 0 /* send packets in the clear */
#define rxkad_auth 1 /* send encrypted sequence numbers */
#define rxkad_crypt 2 /* encrypt packet data */

2
src/volser/vos.c
View File

@ -5568,7 +5568,7 @@ ConvertRO(struct cmd_syndesc *as, void *arock)
afs_int32 ropartition = 0;
int force = 0;
struct rx_connection *aconn;
char c, dc;
int c, dc;
server = GetServer(as->parms[0].items->data);
if (!server) {