jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 13:38:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

windows-scache-ref-leak-20061010

Browse Source 
if cm_FindSCache is called the returned scache object
must be released.
This commit is contained in:
Jeffrey Altman 2006-10-10 16:55:49 +00:00
parent 3c13e5f0c0
commit c60736030b
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/WINNT/afsd/cm_buf.c
View File

@ -428,6 +428,8 @@ long buf_SetNBuffers(afs_uint64 nbuffers)
*/
void buf_WaitIO(cm_scache_t * scp, cm_buf_t *bp)
{
int release = 0;
if (scp)
osi_assert(scp->magic == CM_SCACHE_MAGIC);
osi_assert(bp->magic == CM_BUF_MAGIC);
@ -464,7 +466,8 @@ void buf_WaitIO(cm_scache_t * scp, cm_buf_t *bp)
}
if ( !scp ) {
scp = cm_FindSCache(&bp->fid);
if (scp = cm_FindSCache(&bp->fid))
release = 1;
}
if ( scp ) {
lock_ObtainMutex(&scp->mx);
@ -484,6 +487,9 @@ void buf_WaitIO(cm_scache_t * scp, cm_buf_t *bp)
osi_Wakeup((LONG_PTR) bp);
}
osi_Log1(buf_logp, "WaitIO finished wait for bp 0x%p", bp);
if (scp && release)
cm_ReleaseSCache(scp);
}
/* find a buffer, if any, for a particular file ID and offset. Assumes