From cec45d59440f55316097cfd6652d2ea26cd55233 Mon Sep 17 00:00:00 2001 From: Michael Meffie Date: Mon, 19 Feb 2018 13:57:16 -0500 Subject: [PATCH] butc: fix format overflow warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Recent versions of gcc generate an overflow warning in the butc DUMPNAME macro when copying values into the finishedMsg1 buffer. Increase the size of the destination buffer to avoid a possible buffer overflow. dump.c:88:24: error: ‘%s’ directive writing up to 63 bytes into a region of size 50 [-Werror=format-overflow=] sprintf(dumpname, "%s (DumpId %u)", name, dbDumpId); ^ dump.c:1294:5: note: in expansion of macro ‘DUMPNAME’ DUMPNAME(finishedMsg1, nodePtr->dumpSetName, dparams.databaseDumpId); ^~~~~~~~ dump.c:88:6: note: ‘sprintf’ output between 12 and 84 bytes into a destination of size 50 sprintf(dumpname, "%s (DumpId %u)", name, dbDumpId); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ dump.c:1294:5: note: in expansion of macro ‘DUMPNAME’ DUMPNAME(finishedMsg1, nodePtr->dumpSetName, dparams.databaseDumpId); ^~~~~~~~ Change-Id: Iadf87a308ab6c500a8407a269bc0fd443ff0c735 Reviewed-on: https://gerrit.openafs.org/12916 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- src/butc/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/butc/dump.c b/src/butc/dump.c index cd5d591938..28d69cf34e 100644 --- a/src/butc/dump.c +++ b/src/butc/dump.c @@ -1116,7 +1116,7 @@ Dumper(void *param) int nodumpvolumes = 0; char strlevel[5]; char msg[20]; - char finishedMsg1[50]; + char finishedMsg1[128]; char finishedMsg2[50]; time_t startTime = 0; time_t endTime = 0;