jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

afs: Update VCHash comments on not hashing on uniq

Browse Source 
The comments above VCHash claim that PFlush relies on the fid uniq not
being used in VCHash, but this doesn't appear to be true.

However, we do have some code that relies on VCHash not using uniq:
afs_GenFakeFid. Update the VCHash comment to point this out.

Change-Id: Ib1e0c1700c4cd13b95ac57522645ce73d2b24a08
Reviewed-on: https://gerrit.openafs.org/15042
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
This commit is contained in:
Andrew Deason 2022-06-20 13:07:44 -05:00
parent 91378d93b9
commit cff2a5b1af
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/afs/afs_vcache.c
View File

@ -88,12 +88,12 @@ static afs_int32 afs_QueueVCB(struct vcache *avc, int *slept);
/*
* The PFlush algorithm makes use of the fact that Fid.Unique is not used in
* below hash algorithms. Change it if need be so that flushing algorithm
* doesn't move things from one hash chain to another.
* Don't hash on the cell; our callback-breaking code sometimes fails to compute
* the cell correctly, and only scans one hash bucket.
*
* Don't hash on the uniq; afs_GenFakeFid looks through a single hash bucket to
* find the max possible uniq for a given fid.
*/
/* Don't hash on the cell; our callback-breaking code sometimes fails to compute
* the cell correctly, and only scans one hash bucket. */
int VCHash(struct VenusFid *fid)
{
return opr_jhash_int2(fid->Fid.Volume, fid->Fid.Vnode, 0) &