jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

make-release: Remove unused optional version argument

Browse Source 
The make-release help shows an optional version argument, but in fact
the version info is always generated from the git tag name argument,
which makes sense when creating releases.

Continue to throw away the second positional argument just in case
someone is still passing a second argument, but issue a warning if they
do.

Change-Id: Ie4c6e6efb7693e53a02fd009eecd64b47250c848
Reviewed-on: https://gerrit.openafs.org/14149
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: Benjamin Kaduk <kaduk@mit.edu>
This commit is contained in:
Michael Meffie 2020-04-16 07:21:51 -04:00 committed by Benjamin Kaduk
parent 46eb00ffa1
commit d20d392091
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
build-tools/make-release
View File

@ -25,9 +25,12 @@ pod2usage(1) if $help;
pod2usage(-exitstatus => 0, -verbose => 2) if $man;
my $tagName = shift;
my $version = shift;
my $notused = shift; # Used to be "version".
pod2usage(2) if !defined($tagName);
if (defined $notused) {
warn "Warning: argument '$notused' is ignored.\n";
}
# Tag the repository
@ -40,7 +43,7 @@ if ($tagPoint) {
or die "git push failed with : $!";
}
$version = `git describe --abbrev=4 $tagName`;
my $version = `git describe --abbrev=4 $tagName`;
chomp $version;
$version=~s/openafs-[^-]*-//;
$version=~s/_/./g;
@ -132,7 +135,7 @@ make-release - Make an OpenAFS release from git
=head1 SYNOPSIS
make-release [options] <tag> [<version>]
make-release [options] <tag>
Options:
--help brief help message