jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-02-01 05:57:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

viced-callback-lock-host-during-multi-breakcallback-20041011

Browse Source 
since it looks like CheckHost is using a gc'd client conn, this more or less has to be it.

====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================

since it looks like CheckHost is using a gc'd client conn, this more or less has
 to be it.

and don't deadlock.

====================

since it looks like CheckHost is using a gc'd client conn, this more or less has
 to be it.

and don't deadlock.

====================

since it looks like CheckHost is using a gc'd client conn, this more or less has
 to be it.

and don't deadlock.
This commit is contained in:
Derrick Brashear 2004-10-11 19:39:55 +00:00
parent 3b9cdc23b5
commit d98a0af85d
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/viced/callback.c
View File

@ -776,6 +776,7 @@ MultiBreakCallBack_r(struct cbstruct cba[], int ncbas,
if (!thishost || (thishost->hostFlags & HOSTDELETED)) { if (!thishost || (thishost->hostFlags & HOSTDELETED)) {
continue; continue;
} }
rx_GetConnection(thishost->callback_rxcon);
conns[j++] = thishost->callback_rxcon; conns[j++] = thishost->callback_rxcon;
#ifdef ADAPT_MTU #ifdef ADAPT_MTU
@ -832,14 +833,14 @@ MultiBreakCallBack_r(struct cbstruct cba[], int ncbas,
} }
H_LOCK; H_LOCK;
h_Lock_r(hp); h_Lock_r(hp);
hp->hostFlags |= VENUSDOWN; hp->hostFlags |= VENUSDOWN;
/** /**
* We always go into AddCallBack1_r with the host locked * We always go into AddCallBack1_r with the host locked
*/ */
AddCallBack1_r(hp, afidp->AFSCBFids_val, itot(idx), AddCallBack1_r(hp, afidp->AFSCBFids_val, itot(idx),
CB_DELAYED, 1); CB_DELAYED, 1);
h_Unlock_r(hp); h_Unlock_r(hp);
H_UNLOCK; H_UNLOCK;
} }
} }
@ -853,8 +854,10 @@ MultiBreakCallBack_r(struct cbstruct cba[], int ncbas,
for (i = 0; i < ncbas; i++) { for (i = 0; i < ncbas; i++) {
struct host *hp; struct host *hp;
hp = cba[i].hp; hp = cba[i].hp;
if (hp && xhost != hp) if (hp && xhost != hp) {
rx_PutConnection(hp->callback_rxcon);
h_Release_r(hp); h_Release_r(hp);
}
} }
return; return;