jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rmtsys: Don't overflow pathname buffer

Browse Source 
When we're constructing a homedirectory path to look for the
.AFSSERVER file in, we copy the HOME environment variable into a
static buffer, with a risk of overflowing that buffer.

Instead of using a static buffer, just allocate one with asprintf.

Caught by coverity (#985910)

Reviewed-on: http://gerrit.openafs.org/9392
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit f322b0ff1ec44d713c23d567f4d304e3dc65e702)

Change-Id: I588fecf4caee64915fc2e7730f68f051d6faa92a
Reviewed-on: http://gerrit.openafs.org/11043
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
This commit is contained in:
Simon Wilkinson 2013-03-02 10:15:10 +00:00 committed by Stephan Wiesand
parent 049e7650a8
commit da3dc59ce0
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/sys/rmtsysc.c
View File

@ -38,6 +38,7 @@
#include <grp.h>
#endif
#include <rx/xdr.h>
#include <afs/afsutil.h>
#include "rmtsys.h"
#include "sys_prototypes.h"
@ -84,10 +85,14 @@ GetAfsServerAddr(char *syscall)
fgets(server_name, 128, fp);
fclose(fp);
} else {
char pathname[256];
char *pathname;
sprintf(pathname, "%s/%s", home_dir, ".AFSSERVER");
afs_asprintf(&pathname, "%s/%s", home_dir, ".AFSSERVER");
if (pathname == NULL)
return 0;
fp = fopen(pathname, "r");
free(pathname);
if (fp == 0) {
/* Our last chance is the "/.AFSSERVER" file */
fp = fopen("/.AFSSERVER", "r");