jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 23:10:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

volser: Fix bad readlink usage

Browse Source 
readlink fills the buffer passed to it with a non-terminated string.
It can legitimately fill the whole of this buffer. So, if we require
a string to be NUL terminated, we must give readlink one less than
the string length so that the termination character can be safely
appended.

Caught by coverity (#985611)

Change-Id: Ie6c651a9c0fd94d83bd05395204341d71e353146
Reviewed-on: http://gerrit.openafs.org/9290
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
This commit is contained in:
Simon Wilkinson 2013-02-26 21:28:52 +00:00 committed by Jeffrey Altman
parent caabad9823
commit ddc3704335
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/volser/restorevol.c
View File

@ -720,7 +720,7 @@ ReadVNode(afs_int32 count)
*/
snprintf(linkname, sizeof linkname, "%s" OS_DIRSEP "%s%d",
parentdir, AFILE, vn.vnode);
len = readlink(linkname, fname, MAXNAMELEN);
len = readlink(linkname, fname, MAXNAMELEN - 1);
if (len < 0) {
snprintf(filename, sizeof filename, "%s" OS_DIRSEP "%s%d",
rootdir, OFILE, vn.vnode);