jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libadmin: Don't pass garbage to pts_UserCreate

Browse Source 
The libadmin pts_UserCreate function uses the value passed to
it in newUserId to control whether the user is being created
with a user supplied ID or not.

Initialise this value in the caller, so we don't end up creating
users with corrupt ids.

Caught by clang (#985979)

Reviewed-on: http://gerrit.openafs.org/9401
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 5cf4415c8ad400a92fc9c7f436ae52256db2ef09)

Change-Id: I0e91352a98f63b386185abf9860dc056cb775821
Reviewed-on: http://gerrit.openafs.org/11050
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
This commit is contained in:
Simon Wilkinson 2013-03-02 11:36:31 +00:00 committed by Stephan Wiesand
parent ce92308396
commit de7353838a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libadmin/test/pts.c
View File

@ -326,7 +326,7 @@ DoPtsUserCreate(struct cmd_syndesc *as, void *arock)
enum { USER }; enum { USER };
afs_status_t st = 0; afs_status_t st = 0;
char *user = as->parms[USER].items->data; char *user = as->parms[USER].items->data;
int new_user_id; int new_user_id = 0;
if (!pts_UserCreate(cellHandle, user, &new_user_id, &st)) { if (!pts_UserCreate(cellHandle, user, &new_user_id, &st)) {
ERR_ST_EXT("pts_UserCreate", st); ERR_ST_EXT("pts_UserCreate", st);