From e019429d4548348c6ab8674305d985feee040476 Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Wed, 17 Apr 2013 01:27:47 -0500 Subject: [PATCH] LINUX: Avoid duplicate mntget in afs_dentry_open Our caller already got a ref to 'mnt'; getting another one here will overcount refs on 'mnt'. This can make it impossible to unmount the filesystem the cache resides on (even after the client is stopped), since it's ref count will be very high. FIXES 131613 Change-Id: I3f0cd0fd6c0c2ced74f2d799ea0d8f8701a20141 Reviewed-on: http://gerrit.openafs.org/9790 Tested-by: BuildBot Reviewed-by: Stephan Wiesand Tested-by: Stephan Wiesand Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear --- src/afs/LINUX/osi_compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/afs/LINUX/osi_compat.h b/src/afs/LINUX/osi_compat.h index f729db53db..6087d4377e 100644 --- a/src/afs/LINUX/osi_compat.h +++ b/src/afs/LINUX/osi_compat.h @@ -529,7 +529,7 @@ afs_dentry_open(struct dentry *dp, struct vfsmount *mnt, int flags, const struct filp = dentry_open(&path, flags, creds); return filp; #else - return dentry_open(dp, mntget(mnt), flags, creds); + return dentry_open(dp, mnt, flags, creds); #endif } #endif