jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

openbsd-groups-20030624

Browse Source 
openbsd:
use the right creds in afs_xsetgroups
don't clobber the ucred pool by running off the end of the group list
don't over-hold creds
This commit is contained in:
Jim Rees 2003-06-24 20:24:18 +00:00
parent 7ac709c80b
commit e0306e8c05
1 changed files with 15 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/afs/OBSD/osi_groups.c
View File

@ -55,7 +55,7 @@ Afs_xsetgroups(p, args, retval)
AFS_STATCNT(afs_xsetgroups);
AFS_GLOCK();
code = afs_InitReq(&treq, osi_curcred());
code = afs_InitReq(&treq, p->p_rcred);
AFS_GUNLOCK();
if (code)
return code;
@ -65,7 +65,7 @@ Afs_xsetgroups(p, args, retval)
* Note that if there is a pag already in the new groups we don't
* overwrite it with the old pag.
*/
if (PagInCred(osi_curcred()) == NOPAG) {
if (PagInCred(p->p_rcred) == NOPAG) {
if (((treq.uid >> 24) & 0xff) == 'A') {
AFS_GLOCK();
/* we've already done a setpag, so now we redo it */
@ -130,26 +130,23 @@ afs_setgroups(
gid_t *gidset,
int change_parent)
{
gid_t *gp;
struct ucred *newcr, *cr;
struct ucred *cr = *cred;
int i;
AFS_STATCNT(afs_setgroups);
/*
* The real setgroups() call does this, so maybe we should too.
*/
if (ngroups > NGROUPS)
return EINVAL;
cr = *cred;
if (!change_parent)
newcr = crdup(cr);
else
newcr = cr;
newcr->cr_ngroups = ngroups;
gp = newcr->cr_groups;
while (ngroups--)
*gp++ = *gidset++;
for ( ; gp < &(*cred)->cr_groups[NGROUPS]; gp++)
*gp = NOGROUP;
*cred = newcr;
cr = crcopy(cr);
for (i = 0; i < ngroups; i++)
cr->cr_groups[i] = gidset[i];
for (i = ngroups; i < NGROUPS; i++)
cr->cr_groups[i] = NOGROUP;
cr->cr_ngroups = ngroups;
*cred = cr;
return(0);
}