jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

redhat: Add make to the dkms-openafs pre-requirements

Browse Source 
If `make` is not installed before dkms-openafs, the OpenAFS kernel
module is not built during the dkms-openafs package installation.

The failure happens in the "checking if linux kernel module build works"
configure step, which invokes `make` to check the linux buildsystem.
configure fails when `make` is not available, and gives the unhelpful
suggestion (in this case) of configuring with --disable-kernel module.

Running the configure.log in the dkms build directory shows:

    configure:7739: checking if linux kernel module build works
    make -C /lib/modules/4.18.0-193.6.3.el8_2.x86_64/build M=/var/lib/dkms/openafs/...
    ./configure: line 7771: make: command not found
    configure: failed using Makefile:

Avoid this build failure by adding `make` to the list of dkms-openafs
package pre-requirements.

Change-Id: I98b3508341eea1df4fa7b6f43e88add1bda9ee2c
Reviewed-on: https://gerrit.openafs.org/14266
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
This commit is contained in:
Michael Meffie 2020-07-01 21:50:09 -04:00 committed by Benjamin Kaduk
parent 2d01f35d05
commit e61ab9353e
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/packaging/RedHat/openafs.spec.in
View File

@ -229,8 +229,7 @@ Summary: DKMS-ready kernel source for AFS distributed filesystem
Group: Development/Kernel Group: Development/Kernel
Provides: openafs-kernel = %{version} Provides: openafs-kernel = %{version}
Provides: %{name}-kmod = %{version} Provides: %{name}-kmod = %{version}
Requires(pre): dkms Requires(pre): dkms, make, flex
Requires(pre): flex
Requires(post): dkms Requires(post): dkms
Requires: %{name}-kmod-common = %{version} Requires: %{name}-kmod-common = %{version}