From e76966e22ec234070157ef9179d96c2ccdb80075 Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Thu, 21 Feb 2013 22:15:11 +0000 Subject: [PATCH] Unix CM: Don't zero args on dcache failure Even if allocating the dcache fails, there's no point zeroing the parameters to the allocation function, as those changes aren't visible outside of that function. Caught by clang-analyzer Change-Id: Ieb91b525e818b73e38b8d78a55d170d36273177c Reviewed-on: http://gerrit.openafs.org/9234 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Derrick Brashear --- src/afs/afs_dcache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/afs/afs_dcache.c b/src/afs/afs_dcache.c index 0f53d5da4e..8833c394b8 100644 --- a/src/afs/afs_dcache.c +++ b/src/afs/afs_dcache.c @@ -3319,7 +3319,6 @@ afs_dcacheInit(int afiles, int ablocks, int aDentries, int achunk, int aflags) afs_warn("afsd: memory cache too large for available memory.\n"); afs_warn("afsd: AFS files cannot be accessed.\n\n"); dcacheDisabled = 1; - afiles = ablocks = 0; } else afs_warn("Memory cache: Allocating %d dcache entries...", aDentries);