From e99fac0e4caf6ddf6c393681a0c9744fa13c9b3e Mon Sep 17 00:00:00 2001 From: Michael Meffie Date: Thu, 12 Jan 2017 12:27:36 -0500 Subject: [PATCH] SOLARIS: fix for AFS_PAG_ONEGROUP_ENV for Solaris 11 Fix a bug introduced in commit aab1e71628e6a4ce68c5e59e2f815867438280d1 in which a pointer was incorrectly checked for a NULL value. Fixes a crash when a PAG is set on Solaris. # mdb unix.1 vmcore.1 > ::status ... panic message: BAD TRAP: type=e (#pf Page fault) rp=fffffffc802ba8f0 addr=0 occurred in module "afs" due to a NULL pointer dereference > ::stack pag_to_gidset+0x145() setpag+0xcc() AddPag+0x3a() afs_setpag+0x58() Afs_syscall+0x115() The crash occurs since gidslot is NULL during the assignment: *gidslot = pagvalue; Reviewed-on: https://gerrit.openafs.org/12508 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot (cherry picked from commit b146c2d54ff3bd99f2c4674eb88d5af417a194d7) Change-Id: Ia012d07a3dd063e759a4a50d38e37be710e96255 Reviewed-on: https://gerrit.openafs.org/12527 Tested-by: BuildBot Reviewed-by: Mark Vitale Reviewed-by: Michael Meffie Reviewed-by: Stephan Wiesand --- src/afs/SOLARIS/osi_groups.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/afs/SOLARIS/osi_groups.c b/src/afs/SOLARIS/osi_groups.c index a33736d8b4..527964b9f6 100644 --- a/src/afs/SOLARIS/osi_groups.c +++ b/src/afs/SOLARIS/osi_groups.c @@ -107,7 +107,7 @@ pag_to_gidset(afs_uint32 pagvalue, gid_t *gidset, int *a_ngroups, } } - if (gidslot != NULL) { + if (gidslot == NULL) { /* If we don't already have a PAG, grow the groups list by one, and put * our PAG in the new empty slot. */ if ((sizeof(gidset[0])) * (ngroups + 1) > gidset_sz) {