From ed50afe5fc2fed20be4843c677d3f545c7f3c0d8 Mon Sep 17 00:00:00 2001
From: Andrew Deason <adeason@sinenomine.net>
Date: Wed, 9 Aug 2017 20:06:28 -0500
Subject: [PATCH] SOLARIS: Modernize some function definitions

Fix a few functions that were declared without a return type, or were
using old-style declarations.

Change-Id: I1d19d06a588ba2d2e5005bfe8ca5dd267018ccdd
Reviewed-on: https://gerrit.openafs.org/12702
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Marcio Brito Barbosa <marciobritobarbosa@yahoo.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
---
 src/afs/SOLARIS/osi_vfsops.c | 15 +++++++++------
 src/afs/afs_syscall.c        |  1 +
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/afs/SOLARIS/osi_vfsops.c b/src/afs/SOLARIS/osi_vfsops.c
index ef59a567dc..98015a504d 100644
--- a/src/afs/SOLARIS/osi_vfsops.c
+++ b/src/afs/SOLARIS/osi_vfsops.c
@@ -273,6 +273,7 @@ afs_vget(struct vfs *afsp, struct vnode **avcp, struct fid *fidp)
  * Since we don't support diskless clients we shouldn't come here.
  */
 int afsmountroot = 0;
+int
 afs_mountroot(struct vfs *afsp, whymountroot_t why)
 {
     AFS_GLOCK();
@@ -286,6 +287,7 @@ afs_mountroot(struct vfs *afsp, whymountroot_t why)
  * Again not for us.
  */
 int afsswapvp = 0;
+int
 afs_swapvp(struct vfs *afsp, struct vnode **avpp, char *nm)
 {
     AFS_GLOCK();
@@ -367,8 +369,6 @@ int (*nfs_acldisptab_v3) ();
 int (*nfs_checkauth) ();
 #endif
 
-extern Afs_syscall();
-
 static void *
 do_mod_lookup(const char * mod, const char * sym)
 {
@@ -383,6 +383,7 @@ do_mod_lookup(const char * mod, const char * sym)
     return ptr;
 }
 
+int
 #ifdef AFS_SUN510_ENV
 afsinit(int fstype, char *dummy)
 #else
@@ -567,7 +568,8 @@ reset_sysent(void)
   * function in a module and calls it when modloading
   */
 
-_init()
+int
+_init(void)
 {
     char *sysn, *mod_getsysname();
     int code;
@@ -614,8 +616,8 @@ _init()
     return code;
 }
 
-_info(modp)
-     struct modinfo *modp;
+int
+_info(struct modinfo *modp)
 {
     int code;
 
@@ -623,7 +625,8 @@ _info(modp)
     return code;
 }
 
-_fini()
+int
+_fini(void)
 {
     int code;
 
diff --git a/src/afs/afs_syscall.c b/src/afs/afs_syscall.c
index 03a70da444..9d852e7f2b 100644
--- a/src/afs/afs_syscall.c
+++ b/src/afs/afs_syscall.c
@@ -378,6 +378,7 @@ copyin_iparam(caddr_t cmarg, struct iparam *dst)
 #ifdef	AFS_SUN5_ENV
 extern int afs_sinited;
 
+int
 Afs_syscall(struct afssysa *uap, rval_t * rvp)
 {
     int *retval = &rvp->r_val1;