jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 13:38:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows: AFSInvalidateVolume ObjectInfo refcnt decrement

Browse Source 
In AFSInvalidateVolume a reference count is obtained in order to
ensure that the object is valid throughout the invalidation request.
Although the refcnt is obtained while holding the TreeLock the refcnt
was not released while holding the TreeLock which could open the door
for another thread to race.

Change-Id: I5c7ee91b78a2ce5f03cdc5f835b15357ecbec443
Reviewed-on: http://gerrit.openafs.org/9782
Reviewed-by: Rod Widdowson <rdw@steadingsoftware.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
This commit is contained in:
Jeffrey Altman 2013-04-12 11:12:13 -04:00
parent a1aa06e82c
commit ed76e573ae
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/WINNT/afsrdr/kernel/lib/AFSGeneric.cpp
View File

@ -2759,6 +2759,9 @@ AFSInvalidateVolume( IN AFSVolumeCB *VolumeCB,
AFSInvalidateObject( &pCurrentObject,
Reason);
AFSAcquireShared( VolumeCB->ObjectInfoTree.TreeLock,
TRUE);
if ( pCurrentObject )
{
@ -2772,9 +2775,6 @@ AFSInvalidateVolume( IN AFSVolumeCB *VolumeCB,
lCount));
}
AFSAcquireShared( VolumeCB->ObjectInfoTree.TreeLock,
TRUE);
pCurrentObject = pNextObject;
}