From f16d40ad26df3ec871f8c73952594ad2e723c9b4 Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Wed, 1 Apr 2020 22:59:38 -0500 Subject: [PATCH] vos: Print "done" in non-verbose 'vos remsite' Currently, 'vos remsite' always prints the message "Deleting the replication site for volume %lu ...", and then calls VDONE if the operation is successful. VDONE prints the trailing "done", but only if -verbose is turned on, and so if -verbose is not specified, the output of 'vos remsite' looks broken: $ vos remsite fs1 vicepa vol.foo Deleting the replication site for volume 1234 ...Removed replication site fs1 /vicepa for volume vol.foo To fix this, unconditionally print the trailing "done", instead of going through VDONE, so 'vos remsite' output now looks like this: $ vos remsite fs1 vicepa vol.foo Deleting the replication site for volume 1234 ... done Removed replication site fs1 /vicepa for volume vol.foo Change-Id: I0b42f4cb9b695331bf047243bf6ae4a1cdbb89c4 Reviewed-on: https://gerrit.openafs.org/14127 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- src/volser/vsprocs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/volser/vsprocs.c b/src/volser/vsprocs.c index cddacac940..722701f39a 100644 --- a/src/volser/vsprocs.c +++ b/src/volser/vsprocs.c @@ -5172,7 +5172,8 @@ UV_RemoveSite(afs_uint32 server, afs_int32 part, afs_uint32 volid) LOCKREL_OPCODE | LOCKREL_AFSID | LOCKREL_TIMESTAMP); return (vcode); } - VDONE; + fprintf(STDOUT, " done\n"); + fflush(STDOUT); } return 0; }