jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rmtsys: Don't overflow pathname buffer

Browse Source 
When we're constructing a homedirectory path to look for the
.AFSSERVER file in, we copy the HOME environment variable into a
static buffer, with a risk of overflowing that buffer.

Instead of using a static buffer, just allocate one with asprintf.

Caught by coverity (#985910)

Change-Id: I2daa5613609f2c09712b12a7ce7e59b1c0028ef2
Reviewed-on: http://gerrit.openafs.org/9392
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
This commit is contained in:
Simon Wilkinson 2013-03-02 10:15:10 +00:00 committed by Jeffrey Altman
parent b32d92268f
commit f322b0ff1e
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/sys/rmtsysc.c
View File

@ -68,10 +68,14 @@ GetAfsServerAddr(char *syscall)
fgets(server_name, 128, fp);
fclose(fp);
} else {
char pathname[256];
char *pathname;
sprintf(pathname, "%s/%s", home_dir, ".AFSSERVER");
asprintf(&pathname, "%s/%s", home_dir, ".AFSSERVER");
if (pathname == NULL)
return 0;
fp = fopen(pathname, "r");
free(pathname);
if (fp == 0) {
/* Our last chance is the "/.AFSSERVER" file */
fp = fopen("/.AFSSERVER", "r");