jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-22 17:00:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows: Remove unused cleanup flag

Browse Source 
In AFSOpenTargetDirectory the flag bRemoveShare was initialized
FALSE and never set TRUE.  In teardown after failure some code
did listen to the flag, but the operation (IoRemoveShareAccess)
was not protected by the FCB mainlock which it should have been.

Rather than get the locking correct, just remove the flag entirely.

Change-Id: I097f15bb0903f3c0889b62427d2169cf84aa04a0
Reviewed-on: http://gerrit.openafs.org/5649
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
This commit is contained in:
Rod Widdowson 2011-10-22 14:27:41 +01:00 committed by Jeffrey Altman
parent 4b817cbb52
commit f715ebaee4
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp
View File

@ -2061,7 +2061,6 @@ AFSOpenTargetDirectory( IN PIRP Irp,
PIO_STACK_LOCATION pIrpSp = IoGetCurrentIrpStackLocation( Irp);
PACCESS_MASK pDesiredAccess = NULL;
USHORT usShareAccess;
BOOLEAN bRemoveAccess = FALSE;
BOOLEAN bAllocatedCcb = FALSE;
BOOLEAN bReleaseFcb = FALSE, bAllocatedFcb = FALSE;
AFSObjectInfoCB *pParentObject = NULL, *pTargetObject = NULL;
@ -2298,13 +2297,6 @@ try_exit:
*Ccb = NULL;
if( bRemoveAccess)
{
IoRemoveShareAccess( pFileObject,
&pParentObject->Fcb->ShareAccess);
}
if( bAllocatedFcb)
{