jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-21 00:10:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

windows-del-symlink-20071021

Browse Source 
The cmd.exe "del" command operates by opening a file and then setting
the file disposition to delete on close followed by closing the file.

When the filename is a symlink, the smb_fid_t scp refers to the final
destination object and not the symlink.  In smb_CloseFid() the correct
object would be removed from the directory by name, but the wrong cm_scache_t
would be marked deleted.  This would result in subsequent references to
the target file being considered invalid.

Fix it by looking up the cm_scache_t of the symlink prior to performing
the deletion.
This commit is contained in:
Jeffrey Altman 2007-10-22 04:27:14 +00:00
parent 20cfc16e3d
commit f90153625e
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/WINNT/afsd/smb.c
View File

@ -5766,6 +5766,7 @@ long smb_CloseFID(smb_vc_t *vcp, smb_fid_t *fidp, cm_user_t *userp,
cm_scache_t *dscp = NULL;
char *pathp = NULL;
cm_scache_t * scp = NULL;
cm_scache_t *delscp = NULL;
int deleted = 0;
int nullcreator = 0;
@ -5873,8 +5874,14 @@ long smb_CloseFID(smb_vc_t *vcp, smb_fid_t *fidp, cm_user_t *userp,
char *fullPathp;
lock_ReleaseMutex(&fidp->mx);
smb_FullName(dscp, scp, pathp, &fullPathp, userp, &req);
if (scp->fileType == CM_SCACHETYPE_DIRECTORY) {
code = cm_Lookup(dscp, pathp, CM_FLAG_NOMOUNTCHASE, userp, &req, &delscp);
if (code) {
cm_HoldSCache(scp);
delscp = scp;
}
smb_FullName(dscp, delscp, pathp, &fullPathp, userp, &req);
if (delscp->fileType == CM_SCACHETYPE_DIRECTORY) {
code = cm_RemoveDir(dscp, fullPathp, userp, &req);
if (code == 0) {
deleted = 1;
@ -5930,16 +5937,20 @@ long smb_CloseFID(smb_vc_t *vcp, smb_fid_t *fidp, cm_user_t *userp,
if (dscp)
cm_ReleaseSCache(dscp);
if (scp) {
if (deleted || nullcreator) {
lock_ObtainMutex(&scp->mx);
if (nullcreator && scp->creator == userp)
scp->creator = NULL;
if (delscp) {
if (deleted) {
lock_ObtainMutex(&delscp->mx);
if (deleted)
scp->flags |= CM_SCACHEFLAG_DELETED;
lock_ReleaseMutex(&scp->mx);
delscp->flags |= CM_SCACHEFLAG_DELETED;
lock_ReleaseMutex(&delscp->mx);
}
cm_ReleaseSCache(delscp);
}
if (scp) {
lock_ObtainMutex(&scp->mx);
if (nullcreator && scp->creator == userp)
scp->creator = NULL;
scp->flags &= ~CM_SCACHEFLAG_SMB_FID;
lock_ReleaseMutex(&scp->mx);
cm_ReleaseSCache(scp);