jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 15:00:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

LINUX: Update to Linux struct iattr->ia_ctime to timespec64 with 4.18

Browse Source 
With 4.18+ Linux kernels we see a transition to 64-bit time stamps by
default.

current_kernel_time() returns the 32-bit struct timespec.
current_kernel_time64() returns the 64-bit struct timespec64.

struct iattr->ia_ctime expects struct timespec64 as of 4.18+.

Timestamps greater than 31-bit rollover after 2147483647 or
January 19, 2038 03:14:07 UTC. This is the same approach taken by
the Linux developers for converting between timepsec64 and timespec.

Reviewed-on: https://gerrit.openafs.org/13241
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 0bc5c15029)

Reviewed-on: https://gerrit.openafs.org/13268
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 554176bd23)

Change-Id: I0804e05f2a0004669b8b089e4f2f23d1df6c9133
Reviewed-on: https://gerrit.openafs.org/13269
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
This commit is contained in:
Joe Gorse 2018-07-02 20:36:04 +00:00 committed by Stephan Wiesand
parent 38f6a2243c
commit f9ae26d3d1
3 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/afs/LINUX/osi_file.c
View File

@ -23,7 +23,11 @@
#include "osi_compat.h"
#ifndef CURRENT_TIME
#define CURRENT_TIME (current_kernel_time())
# ifdef IATTR_TAKES_64BIT_TIME
# define CURRENT_TIME (current_kernel_time64())
# else
# define CURRENT_TIME (current_kernel_time())
# endif
#endif
int cache_fh_type = -1;

1
src/cf/linux-kernel-assorted.m4
View File

@ -9,6 +9,7 @@ LINUX_KMEM_CACHE_CREATE_CTOR_TAKES_VOID
LINUX_D_PATH_TAKES_STRUCT_PATH
LINUX_NEW_EXPORT_OPS
LINUX_INODE_SETATTR_RETURN_TYPE
LINUX_IATTR_64BIT_TIME
LINUX_IOP_I_CREATE_TAKES_NAMEIDATA
LINUX_IOP_I_LOOKUP_TAKES_NAMEIDATA
LINUX_IOP_I_PERMISSION_TAKES_FLAGS

12
src/cf/linux-test4.m4
View File

@ -197,7 +197,17 @@ AC_DEFUN([LINUX_INODE_SETATTR_RETURN_TYPE], [
[])
])
AC_DEFUN([LINUX_IATTR_64BIT_TIME], [
AC_CHECK_LINUX_BUILD([whether struct iattr->ia_ctime takes struct timespec64 or 32-bit struct timespec],
[ac_cv_linux_func_iattr_ctime_takes_timespec64],
[#include <linux/fs.h>
#include <linux/timekeeping.h>],
[struct iattr _attrs;
_attrs.ia_ctime = current_kernel_time64();],
[IATTR_TAKES_64BIT_TIME],
[define if struct iattr->ia_ctime takes struct timespec64],
[])
])
AC_DEFUN([LINUX_AOP_WRITEBACK_CONTROL], [
AC_CHECK_LINUX_BUILD([whether aop.writepage takes a writeback_control],