9185 Commits

Author SHA1 Message Date
Jeffrey Altman
9b63f04eff Windows: handle KRB5KRB_AP_ERR_REPEAT errors
This patchset adds logic to handle a KRB5KRB_AP_ERR_REPEAT error
sent by a KDC for the Windows aklog and the afskfw library.  The
KRB5KRB_AP_ERR_REPEAT is sent when the KDC detects a replay.
However, the KDC replay detection is known to generate many false
positives.  If KRB5KRB_AP_ERR_REPEAT is received, wait one second
and retry the request.

This patchset does not apply to 'master' due to Kerberos
Compatibility SDK conversion.

Reviewed-on: http://gerrit.openafs.org/8772
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit c23664aff7a78010ba462317087e84f7ae3c8518)

Change-Id: I806a3ede5f0fa6794f3ccaf8f2d514b0c8443ec1
Reviewed-on: http://gerrit.openafs.org/8775
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 09:55:31 -08:00
Derrick Brashear
5cfb72022a linux: update spec requirements
don't require things which don't exist on el5. do require them
in el6. require kernel-devel if building modules
don't do anything involving the kernel if not building modules
if we can figure out that we don't have 2.4 based on the version,
avoiding the need to depend on kernel-devel just to build an srpm.

Reviewed-on: http://gerrit.openafs.org/6985
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 72f5d88acc752ff447a9e63327c135473326a34d)

Change-Id: Ibcc53eb6a742de2101a054070e9b48607d0bce1d
Reviewed-on: http://gerrit.openafs.org/8787
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 03:06:22 -08:00
Michael Meffie
9cf0b0dcc6 LINUX: make d_automount work properly on rhel5 kernels
Recent centos/rhel 5 kernels (2.6.18-308.*) started providing the
d_automount operation, but renamed the DCACHE_NEED_AUTOMOUNT flag to
DMANAGED_AUTOMOUNT.

Reviewed-on: http://gerrit.openafs.org/8006
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 5daa08ea263b2a82b4a85abd61d72d4d1f48bbb6)

Change-Id: I1ebc2a3cab52ff7294b03e1e82680a99d62013fc
Reviewed-on: http://gerrit.openafs.org/8790
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:15:55 -08:00
Andrew Deason
7ca9875197 LINUX: Use struct vfs_path on RHEL5
Some revisions of the kernel from RHEL5 (2.6.18-308.* and possibly
others) renamed 'struct path' to 'struct vfs_path'. So, use
'struct vfs_path' when it exists.

This introduces the afs_linux_path_t typedef, which is defined as
either a struct path, or struct vfs_path.

Reviewed-on: http://gerrit.openafs.org/8019
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 74c1881dff1593f4a8920ba8d8a2400760899fa5)

Change-Id: I6eaf17ebe9a35b345c1fd5cebd490f8095a1b22b
Reviewed-on: http://gerrit.openafs.org/8789
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:14:55 -08:00
Andrew Deason
716cca7ed8 autoconf: add AC_CHECK_LINUX_TYPE macro
add a macro which looks for a given type in a given linux kernel
header file

Reviewed-on: http://gerrit.openafs.org/8021
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit f87d49cd17fbf6aa9465faadac823ed8d0510a16)

Change-Id: Idc6cc79d9410149f6faeb867f878724beaa30793
Reviewed-on: http://gerrit.openafs.org/8788
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:13:43 -08:00
Arne Wiebalck
cf59993d50 Update 'vos shadow' man page
Change the 'vos shadow' man page to say that updating the
VLDB with shadow volumes does only work if the VLDB entries
for the corresponding source volumes are deleted first.

Reviewed-on: http://gerrit.openafs.org/8652
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Dan van der Ster <daniel.vanderster@cern.ch>
Tested-by: Dan van der Ster <daniel.vanderster@cern.ch>
Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
(cherry picked from commit 83ccb62012d7b3b696dd48e05feb8adeb203463a)

Change-Id: I59eacb7406e8bec9e5736afe32564a04be7ff72a
Reviewed-on: http://gerrit.openafs.org/8786
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:12:46 -08:00
Derrick Brashear
cddc0c4669 macos: fix growlagent icon handling
the whole of the api used for icon handling when you steal it
from a resource fork is deprecated in new macos. fine. we'll just make
an app bundle by cheating, move andy into a standalone icns file,
install him into the "bundle" and open it the macos way.

Reviewed-on: http://gerrit.openafs.org/7786
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 3dd230e8595e2b9635d6ec412a145ae3be229b7a)

Change-Id: I9a439601058a4c2f32cbe687865a9143d56b92bf
Reviewed-on: http://gerrit.openafs.org/8781
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:11:53 -08:00
Derrick Brashear
b64c45535b macos: native apps need 64 bit support
the installer bundle, prefs pane and backgrounder all need to be 64 bit
mode since the system uses them as plugins

Reviewed-on: http://gerrit.openafs.org/7787
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 50009267bb6deaa431042dc99ac6e5d913b1412a)

Change-Id: I7b6f8b011380f1ce8284f5c44656422405490dc7
Reviewed-on: http://gerrit.openafs.org/8780
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:11:08 -08:00
Derrick Brashear
8445c07524 macos: next version support
support things beyond 10.7

Reviewed-on: http://gerrit.openafs.org/7763
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: Derrick Brashear <shadow@dementix.org>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 73ff09513013ae3c6b29b1b7b0a6e76b4fd260f7)

Change-Id: I0bbef00747b01b387989398557fb82be93fe28f9
Reviewed-on: http://gerrit.openafs.org/8785
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:10:05 -08:00
Derrick Brashear
64f1ed16c8 macos: next version header
add header for next macos

Reviewed-on: http://gerrit.openafs.org/7868
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 3638ef30d0de7d82d919b046ec87986ad09442d3)

Change-Id: Ia4ad32e66566c8d822a32ca51fae784293f7ac24
Reviewed-on: http://gerrit.openafs.org/8779
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-21 02:09:49 -08:00
Stephan Wiesand
58c2a08b73 make openafs 1.6.2pre1
prerelease for 1.6.2

Change-Id: I22fad3411c09644578c717c06cd7cb6b3469fe57
Reviewed-on: http://gerrit.openafs.org/8738
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
openafs-stable-1_6_2pre1
2012-12-10 07:38:50 -08:00
Simon Wilkinson
463e0d2049 rxperf: -S takes an argument
The -S option to rxperf (which permits the maximum number of server
threads to be set) takes a parameter. Update the getopt string so
that we can give it one.

Reviewed-on: http://gerrit.openafs.org/4801
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit 80b3648e6d8fd96bdb57d47e56b28b30e42eb303)

Change-Id: Ic1a8264d0471e9458ade11af00ed78871b390b34
Reviewed-on: http://gerrit.openafs.org/8423
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-10 05:53:39 -08:00
Jeffrey Altman
4c084a67e6 rxperf: use parallel connections
When the number of threads exceeds RX_MAXCALLS allocate additional
rx connection objects.

Reviewed-on: http://gerrit.openafs.org/3285
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit df682aa34170d285247c5486050db3ee7d3774f0)

Change-Id: Ia699fe0230e6dde2bc1f270d766f512f2693c94f
Reviewed-on: http://gerrit.openafs.org/8421
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
2012-12-10 05:53:08 -08:00
Jeffrey Altman
fb95823877 NetIdMgr: Krb4 is optional
32-bit builds should not require the krb4 library.

Reviewed-on: http://gerrit.openafs.org/8414
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 51021ac306c7b3b355c64c978a029537e3341a25)

Change-Id: I8664140cd8e5d159789be94628a726e8c7ee5cb7
Reviewed-on: http://gerrit.openafs.org/8727
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 22:02:33 -08:00
Jeffrey Altman
2c1ba63df3 Windows: Make krb4v32.dll and krb524.dll optional
Permit afskfw.dll to be built with USE_KRB4 and USE_KRB524 without
the requisite DLLs being available on the target machine.

Reviewed-on: http://gerrit.openafs.org/8413
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 3764cbfbc9f26738b5e6693e8729e79dbb0092c6)

Change-Id: Ib546aa45a57bba40de02dc9499dd1ce6c2ef9d73
Reviewed-on: http://gerrit.openafs.org/8726
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 22:02:21 -08:00
Jeffrey Altman
4061aa47f1 Windows: cm_RecycleSCache remove from hash table
Remove the cm_scache_t object from the hash table during recycling.
This step is performed on master and on 1_7_x.  Did not get pulled
onto 1.6.x previously.

Change-Id: I2c50a08b8f0b191bd558ce344cb0ce594e13661c
Reviewed-on: http://gerrit.openafs.org/8725
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 22:02:07 -08:00
Jeffrey Altman
ad7cfa94e6 Windows: buf_CleanLocked protect against NULL bp->userp
The cm_buf_t.userp field should never be NULL if the CM_BUF_DIRTY
flag is set but apparently it sometimes is.  cm_BufWrite() requires
that the userp parameter be non-NULL.  Otherwise, an assertion fails
and afsd_service.exe panics.  If bp->userp is NULL, use cm_rootUserp.
The worst that will happen is the write will fail due to an access
denied error.

Reviewed-on: http://gerrit.openafs.org/8475
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit f436fe03c80e21b6a58a6de962070841e00791ef)

Change-Id: I33f5e73509cc2c6517ae4bf4214011383a341411
Reviewed-on: http://gerrit.openafs.org/8649
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:19:31 -08:00
Jeffrey Altman
c95d1aee53 Windows: do not adjust deleted scache LRU ordering
Instead of moving deleted scache objects so that they are next
in line to be recycled, do not move them at all.  Making them
next to be recycled results in the CM_SCACHEFLAG_DELETED flag
value being lost.

Reviewed-on: http://gerrit.openafs.org/8474
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 887cff5b0f84ad3b758bc4258b1f1302401c2c1d)

Change-Id: I7a9377fdd1546f6e555afa4b2f714d8b74b26e87
Reviewed-on: http://gerrit.openafs.org/8648
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:19:17 -08:00
Jeffrey Altman
d23b655e78 Windows: Do not reset cm_buf.offset on error
When an error occurs the cm_buf_t is not removed from the
hash tables.  Since the scacheHashTable hash is built from
the fid and the offset it is not safe to reset the offset field.
Resetting the offset field results in an assertion failure
during buffer recycling.

Reviewed-on: http://gerrit.openafs.org/8452
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit f56c01d313140b625b4342feddfe464342d1ced4)

Change-Id: I888e56c8c34bcae58c51ba965fd59e5539e1bab5
Reviewed-on: http://gerrit.openafs.org/8647
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:19:05 -08:00
Jeffrey Altman
907e2f148f Windows: Prevent SMB unitialized variable access
smb_ReceiveNTTranCreate would make use of 'fidp' before it was
allocated.

Reviewed-on: http://gerrit.openafs.org/8411
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 6f79eb36593a2b20e712cf7e828e987e12f8e99f)

Change-Id: Ifedf7887c76698ecb32a1c0fa9f4c01e3df74817
Reviewed-on: http://gerrit.openafs.org/8646
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:18:39 -08:00
Jeffrey Altman
6efa862c41 Windows: call MIDL_user_allocate instead of calloc
In the RPC service routines do not call calloc() directly.
All memory will be deallocated by a call to MIDL_user_free()
so use MIDL_user_allocate() to perform the allocation.

Modify MIDL_user_allocate() to call calloc() instead of malloc()
to ensure that the memory is initialized to NUL bytes.

Reviewed-on: http://gerrit.openafs.org/8365
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 8c7846f4e1dd89db4ff3b03c558d97cd13cbb205)

Change-Id: I5562dbac4977a5d23407cd62c3deb743e629c48c
Reviewed-on: http://gerrit.openafs.org/8645
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:18:26 -08:00
Jeffrey Altman
39da28383a Windows: mark server reference offline for VOFFLINE
cm_Analyze() was not marking the cm_ServerRef_t reference to
a volume instance as srv_offline in response to a VOFFLINE error.
As a result the same volume instance is tried again and again.

Reviewed-on: http://gerrit.openafs.org/8326
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit e59cf940ce1cb2ed72ccf05ce39f73019547d9b1)

Change-Id: Iab79c0b2e0c885a0d9180c000f9cc9574fab11dc
Reviewed-on: http://gerrit.openafs.org/8644
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:18:15 -08:00
Jeffrey Altman
a30a4dc211 Windows: Fix memory leak SRXAFSCB_GetCellServ
In commit 19f1e0f7cf40c3da1d49c789358bd814f7e3b3eb strdup()
was replaced by xdr_alloc() and memcpy().  Unfortunately,
the patch was wrong and the pointer to which the result of
xdr_alloc() was assigned was overwritten with zero.

Reviewed-on: http://gerrit.openafs.org/8162
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 137ea396dbbcf302bce8200e3da7d4693b464ca7)

Change-Id: Ia15bcbeec4ad3ff411fd599e2d57f1ead4c3be23
Reviewed-on: http://gerrit.openafs.org/8643
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:17:57 -08:00
Jeffrey Altman
d9b7f61546 Windows: remove sdk sample token.c
The sdk sample is no longer applicable.

Reviewed-on: http://gerrit.openafs.org/7932
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 5a707645b7d14f37f3d7fd8d06685f3940631a44)

Change-Id: Ic811e8b13c9ab5c3eef9e36ffb0cc38c896a7e89
Reviewed-on: http://gerrit.openafs.org/8642
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:17:37 -08:00
Jeffrey Altman
441e6fc771 Windows: cm_MergeStatus unknown interface numbers
Ignore status information if the interface number is unknown.
Currently only version 1 is recognized.

Reviewed-on: http://gerrit.openafs.org/7743
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 8115841e2fc9d827a7207ddc18e5c84e466ed7e7)

Change-Id: Iaa3eb3aae931ee65c991e2786d80a9a62eff76c6
Reviewed-on: http://gerrit.openafs.org/8641
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:17:26 -08:00
Jeffrey Altman
1cc48eeda9 Windows: cm_ConnByServer hold userp->mx only while necessary
The cm_userp_t does not need to be locked while the cm_conn_t
force new connection processing is taking place.

Reviewed-on: http://gerrit.openafs.org/7718
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 5b9e9265a0df707e9fb79842ab5aa94b59b8e88e)

Change-Id: I0fb0f5b7ede676b4513e33fa664e66cafed18e01
Reviewed-on: http://gerrit.openafs.org/8640
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:17:11 -08:00
Jeffrey Altman
e6171f3e2f Windows: cm_ConnByServer add conn to list after init
Do not add a newly created cm_conn_t to the cm_server_t connsp
list until after the object is fully initialized.

Reviewed-on: http://gerrit.openafs.org/7717
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit c3ce54e6b7be8c2996a0fda2d7ad9780fca2f0ef)

Change-Id: I0209a82765b31ccc8a93316438ef12864dbc5339
Reviewed-on: http://gerrit.openafs.org/8639
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:16:41 -08:00
Jeffrey Altman
d5001acddd Windows: cm_HaveCallback optimize .readonly
If the cm_scache_t has a registered callback, there is no reason
to obtain a volume reference for a .readonly.  Just use the
callback.

Reviewed-on: http://gerrit.openafs.org/7716
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit f73aebbe8772e62bf8930d70e9edab2f82ff8984)

Change-Id: Ibacb272fade3aa24beb0b7c9a966b9e769385669
Reviewed-on: http://gerrit.openafs.org/8638
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:16:25 -08:00
Jeffrey Altman
431792e515 Windows: HaveCallback vs OfflineRO Is Valid
commit f716962ab41847af4450d0a361f5de9195b32ed0
inadvertently broke the offline .readonly is valid functionality
when readonly volume versioning is disabled.  Restore it.

Reviewed-on: http://gerrit.openafs.org/7679
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit c3485a35b7a548d850d55dde4634ba78e5330aa9)

Change-Id: Ie7b4758fe14a0a695d7db1b04fc5039050891908
Reviewed-on: http://gerrit.openafs.org/8637
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:16:02 -08:00
Jeffrey Altman
2498cbbce8 Windows: afslogon cast away warnings
cast away size_t to int warnings in 64-bit builds.

Reviewed-on: http://gerrit.openafs.org/7634
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 76ae0f01b32d3e87273ff6d2c9c20eec59e22e16)

Change-Id: I81ba08a273aedb412642c345cd4a2762fcf1edb7
Reviewed-on: http://gerrit.openafs.org/8636
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-08 08:15:39 -08:00
Jeffrey Altman
6ed24963f7 rx: set abort client_initiated flag to match direction
In a recent incident involving packet reflection back to the
file server, aborts were being sent by the file server in response
to a server sent packet.  The aborts sent in response also failed
to set the CLIENT_INITIATED flag in the header which permitted the
the actual client to confuse the Abort as applying to its client
initiated connection.

in rxi_SendRawAbort, set the CLIENT_INITIATED flag to the opposite
of the packet the abort is being sent in response to.

Thanks to Chaskiel Grundman for the suggestion.

Reviewed-on: http://gerrit.openafs.org/8513
Reviewed-by: Chaskiel Grundman <cg2v@andrew.cmu.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 8e68e08901b0ad003ad1e5114a155bfac83bdd83)

Change-Id: Id34b50e91c54f6f984c67ed18fad58ebe225c635
Reviewed-on: http://gerrit.openafs.org/8609
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
2012-12-08 04:45:53 -08:00
Michael Meffie
795a22793f configure: solariscc check update
Add checks for recent versions of sunstudio for solaris.  The
installation paths are documented in the release notes of versions
12.1, 12.2, and 12.3.

Reviewed-on: http://gerrit.openafs.org/7253
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit fbc9599484850f7f9fc41a98d3bd2105001fd802)

Change-Id: If63638bb9b88f0024156fc5547540837b665b301
Reviewed-on: http://gerrit.openafs.org/8654
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
2012-12-08 03:43:01 -08:00
Michael Meffie
b30ed5d2ca Build: error if solariscc is not found
Fail configure if the solariscc is not found and give the builder
a message to cope with non-standard installation paths for
sunstudio.

Reviewed-on: http://gerrit.openafs.org/7204
Reviewed-by: Simon Wilkinson <simonxwilkinson@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit c11d1c031940f298e96def822024d2857f603268)

Change-Id: I123b887a66e8f9bad87144934e9cea62f63f2180
Reviewed-on: http://gerrit.openafs.org/8653
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
2012-12-08 03:42:49 -08:00
Marc Dionne
026f73a032 cache bypass: fix afs_bypass_copy_page memcpy oops
The two memory copy cases were inverted when the code was
refactored, causing an oops when cache bypass is enabled.

Reviewed-on: http://gerrit.openafs.org/8617
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 5b2cc290f8e991b152411168cabd1c9e7f31deb4)

Change-Id: Ia5eb577046895a2b38a6be5c4794db9a65893530
Reviewed-on: http://gerrit.openafs.org/8715
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Paul Smeddle <paul.smeddle@gmail.com>
2012-12-07 04:44:43 -08:00
Jeffrey Altman
75af57b38f Windows: cm_UpdateVolumeLocation misplaced lock
The volume->mx was obtained in the wrong place which resulted
in the potential of a panic caused by obtaining the mutex when
it was already held.

Reviewed-on: http://gerrit.openafs.org/7654
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 4707174938b92df189697a2b7e463438c37c1ed0)

Change-Id: I151547ec9f90f17ae28397c77337b92ea7919754
Reviewed-on: http://gerrit.openafs.org/8635
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:42:10 -08:00
Jeffrey Altman
b24b7e0f68 Windows: Freelance Short circuit all vol updates
As long as the cell is the Freelance Cell ID the volume updates
should be short circuited.  There is no benefit to performing
the extra work.

Reviewed-on: http://gerrit.openafs.org/7636
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit e0b9b89dd98d0bf449556e3f28b479dd61e7eb95)

Change-Id: I95ffc34b9846cba82872aa2d1e308742cddb4727
Reviewed-on: http://gerrit.openafs.org/8634
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:41:38 -08:00
Jeffrey Altman
2b92fe44b8 Windows: AFS_Startup_Event must query Debug value
For proper debugging to be performed within the AFS_Startup_Event
processing, the "Debug" value must be queried from the registry.

Reviewed-on: http://gerrit.openafs.org/7633
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 7fd1dc6c887c3bf786632901bc72b8250298a98f)

Change-Id: I0a58b45890a505ba9ddab24582deaf0c70571a66
Reviewed-on: http://gerrit.openafs.org/8633
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:41:24 -08:00
Jeffrey Altman
bff302b604 Windows: NPLogonNotify secure erase password
The user's password is copied during the NPLogonNotify
processing, be sure to erase it from the stack before the
function completes.

Reviewed-on: http://gerrit.openafs.org/7632
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 187af8d11350c2ff509244f216c72bdd4b88451a)

Change-Id: I40f52324067597e4eb96bfd7ed19f18e154ef8ee
Reviewed-on: http://gerrit.openafs.org/8632
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:41:12 -08:00
Jeffrey Altman
b5f45f313e Windows: afslogon make error dialog system modal
Prevent error dialogs from getting lost behind the desktop
during logon.  Make them system modal.  Add a warning icon
as well.

Reviewed-on: http://gerrit.openafs.org/7630
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit ae5aba17cc5d45805f7d263fd645fba0d3bb5116)

Change-Id: If5031c21b008306f1179cb460b39fc7d3662fbd0
Reviewed-on: http://gerrit.openafs.org/8630
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:40:57 -08:00
Jeffrey Altman
2c18559dcd Windows: afslogon MapAuthError
return WN_NET_ERROR (ERROR_UNEXP_NET_ERR) to indicate a problem
with this network provider when an error occurs instead of
returning WN_NET_SUCCESS.

Reviewed-on: http://gerrit.openafs.org/7629
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 7adb93cf51d56936d51b70758a959342728fea56)

Change-Id: I35f455ff1068418336c4ac11cf57027f3afe4787
Reviewed-on: http://gerrit.openafs.org/8629
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:40:42 -08:00
Jeffrey Altman
fe623b97e1 Windows: afslogon OutputDebugString
If the NetworkProvider "Debug" value has the 1th bit set (2),
generate all debug values to the debugger via OutputDebugString().

Reviewed-on: http://gerrit.openafs.org/7628
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 43d53bed6f591257fee55c343699ee1d3b223ff6)

Change-Id: I91610d3de7d176b8d237887a8eae4be77e185f00
Reviewed-on: http://gerrit.openafs.org/8628
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:40:31 -08:00
Jeffrey Altman
7c665f4e1b Windows: smb_ReceiveTran2QFileInfo Pioctl support
Similar to the QueryPathInfo support for _._AFS_IOCTL_._ the
QueryFileInfo interface must respond to pioctl queries.  When
GetFileAttributes() on XP is called from the afslogon.dll the
QFileInfo path is used instead of the QPathInfo path.

Reviewed-on: http://gerrit.openafs.org/8491
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit 42e812c7abf5fafbbfeebd40828978e8b4639860)

Change-Id: I66d4b001f8f07b75cedb5cce9a80b1639546a45c
Reviewed-on: http://gerrit.openafs.org/8627
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:40:18 -08:00
Jeffrey Altman
4408f4d413 Windows: Fix smb_ReceiveTran2QPathInfo Pioctl support
The path check should needs to include the root directory slash
when comparing to the \_._AFS_IOCTL_._ path to detect a pioctl
request.

Reviewed-on: http://gerrit.openafs.org/8488
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
(cherry picked from commit eca3d56436c16e4634afe1954a2a15424b4ad5f1)

Change-Id: I201179644168cbc09a194612b2faf5bd3a812796
Reviewed-on: http://gerrit.openafs.org/8626
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:40:05 -08:00
Jeffrey Altman
b1e196e23e Windows: SMB GetFileAttributes support
commit 56a2cbb5fbdcab51bd5f4720e610796abbce5c41 added a
GetFileAttributes query to the pioctl interface to protect
against printing pages on printers with a broken smb protocol
implementation.   This patchset adds support for GetFileAttribute
on _._AFS_IOCTL_._ files to the SMB implementation.

Reviewed-on: http://gerrit.openafs.org/7524
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit 371af87a23b61187ca9d54c8e6819f2121fbf1db)

Change-Id: Id25d124a3c1f70c6506ebe8a1af6a4bad55f2b7f
Reviewed-on: http://gerrit.openafs.org/8625
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:39:50 -08:00
Jeffrey Altman
636312c905 Windows: cm_SetServerBusyState use cm_ServerEqual
When the busy state of a server is set it must apply to all
server references if the server is multi-homed.  Use cm_ServerEqual()
to do so.

Reviewed-on: http://gerrit.openafs.org/7355
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit 345d643729ed588c4e49e69607bee5793809b01d)

Change-Id: Ibd96cecce936353ef639de3f0dafb32abb7b29af
Reviewed-on: http://gerrit.openafs.org/8624
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:39:36 -08:00
Jeffrey Altman
c568b57c96 Windows: Make CM resilient to transient VNOVOL
The 1.6.0 and 1.6.1 file servers send transient VNOVOL errors which
are no indicative of the volume not being present.  For example,
VNOVOL can be sent during a transition to a VBUSY state prior to
salvaging or when cloning a .backup volume instance.  As a result
the cache manager must attempt at least one retry when a VNOVOL is
receive but there are no changes to the volume location information.

This patchset records the VNOVOL error in the cm_req_t structure
If the volume is replicated, the volume's server reference into a busy state.
If the volume is not replicated, the thread is paused for two seconds.
In both cases, the request is retried.  If the VNOVOL error is received
a second time from the same server, the volume server reference is
deleted as before.  This is done to prevent repeated requests to the
VLDB server and the file server that are expected to fail.  The server
reference will be restored to the volume on the next volume location
update.

Reviewed-on: http://gerrit.openafs.org/7353
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit 1af906799b2de90d41139dadaf2dd654e4fd2df3)

Change-Id: Ib8ce6dc389be92c00e9519efb253be0ca9cec05f
Reviewed-on: http://gerrit.openafs.org/8623
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:39:23 -08:00
Jeffrey Altman
d2614e3465 Windows: VNOSERVICE error translation
Translate VNOSERVICE as CM_ERROR_RETRY and not CM_ERROR_OFFLINE.

Reviewed-on: http://gerrit.openafs.org/7307
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Tested-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit f70a12adef9a915ada728350e0b9e1e5104f7ea7)

Change-Id: I3f01144863c25a2081f7ea2890299bb509a10a4a
Reviewed-on: http://gerrit.openafs.org/8622
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:39:09 -08:00
Jeffrey Altman
e6843414c8 Windows: VNOSERVICE message text
correct message text to indicate that an rpc has not been serviced.

Reviewed-on: http://gerrit.openafs.org/7306
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit c87fe04a61a97d61859684d53bb2d3ef7ee65da8)

Change-Id: I71fdb47e2ff0f1632b6534f890eed185d8b32ea4
Reviewed-on: http://gerrit.openafs.org/8621
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:38:57 -08:00
Jeffrey Altman
82ba509321 Windows: correct cm_Analyze log message
A VNOSERVICE log message takes three parameters and not one.
Use the correct log macro.

Reviewed-on: http://gerrit.openafs.org/7293
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit cf0d53b06a42a21238f13d65feb8e5ebf602da4d)

Change-Id: I71851a8b82eb28be2338a127f777a3e432945a78
Reviewed-on: http://gerrit.openafs.org/8620
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:38:46 -08:00
Jeffrey Altman
c0968b334e Windows FindACLCache must hold scp write locked
In the SMB modules, calls to cm_FindACLCache() were not
holding the cm_scache_t rwlock writed locked as required.

Reviewed-on: http://gerrit.openafs.org/7015
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
(cherry picked from commit 0896602f6e7c409990fcae40dd54f84260312472)

Change-Id: I29313f479ae2487a615b065d601ee5d0ef994ccf
Reviewed-on: http://gerrit.openafs.org/8619
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
2012-12-06 16:38:28 -08:00