LICENSE MIT
FIXES 124293
As evident in a crash dump, there is a race surrounding access to the
scp field of the smb_fid_t object. Not all access was protected by
the smb_fid_t mx and the cm_scache_t object was not always being
reference counted within the accessing function.
This patch ensures that all initial references to the scp object
are performed under the smb_fid_t mx mutex and that the cm_scache_t
is prevented from being recycled by obtaining a local reference.
Finally, CM_ERROR_BADFD is returned as an error if a request begins
after the smb_fid_t scp field has already been cleared by a smb_CloseFID()
call as part of a concurrent request.
LICENSE MIT
FIXES 124276
A readonly volume with multiple instances was being marked alldown
when one of the instances resulted in VNOVOL because the vldb and
the indicated file server were out of sync. The cache manager would
then attempt to re-obtain the volume location info from the vldb
for the entire timeout period.
This patch:
adds trace logging to cm_Analyze indicating which server references
are being deleted and which remain in response to a VNOVOL/VMOVED error.
adds trace logging to cm_UpdateVolumeStatusInt showing how the
new volume status value is determined.
corrects cm_Analyze() so that it doesn't corrupt the server reference
list during cm_FreeServerList() calls; doesn't orphan the server reference
list by setting *serverpp to NULL; and only re-obtains the volume info
list once per request.
LICENSE BSD
In rxi_WritevProc the queueScan that sets RX_PKTFLAG_TQ on the packet
really needs to cast the queue objects to rx_packet instead of rx_call.
Trashing random fields is not a good idea.
LICENSE BSD
Fix the -parallel example in the main description text: "5all" should be
"all5". Reword the description a bit to hopefully make it clearer that
there are two separate values set here. Note under the option description
of -parallel that multiple partitions on the same device are normally
processed serially.
LICENSE BSD
change nb_qpathinfo() 'Flag' to a thread local storage variable
'EnforcePathInfoErrors'.
Add new 'Type' values that permit the enforcement to be turned on and off
as needed by the test script.
Populate the IoBuffer with the low byte of the pid value.
====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
LICENSE BSD
Verified the state of every file's existence at every Query Path Info
call in the script. Added 'Type' == 1 (Does not Exist) as needed.
Removed the use of 'Type' == 1111 to disable enforcement part way through.
LICENSE MIT
Do not unload afsrpc.dll as it cannot clean up after itself and
become safe to reload.
Instead of reporting that the AFS client is off-line, report the
path that is unreachable.
LICENSE MIT
rename torture.exe to wintorture.exe to match the name expected by stress.exe
increase length of "Locker" to permit longer paths
do not strip \\afs unc server name. treat all unc paths equal
add GetLastError values to logged error messages
clarify error messages when missing input params
print all errors on a single line. quote paths and command strings
fix the initialization of the IoBuffer for writes. initialize the
whole buffer not just the sizeof(pointer)
remove the static declaration of Flag in nb_qpathinfo()
obtain real HANDLEs for directories. Do not fake them.
LICENSE BSD
A test application that produces verifiable random test files.
====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
LICENSE BSD
make it build in the openafs build tree
LICENSE BSD
adds macros to support accessing some variables as atomics, when atomic
support is available; otherwise falls back to mutex-protected access.
LICENSE MIT
separate rx debugging from cache manager debugging.
assign bit 5 of the TraceOption registry value to activation of
rx debug output via DebugOutputString().
LICENSE MIT
confirmed that rx_ReadvProc, rx_WritevProc, and rx_WritevAlloc are
properly implemented for Windows. Add them to the public export list.
Add rx_ReadProc32 and rx_WriteProc32 to the public export list.
LICENSE MIT
The WinSock API does not include the Posix recvmsg/sendmsg interfaces.
Beginning with XP/2003 Microsoft began to support WSARecvMsg which is
a mostly compatible implementation of recvmsg. In Vista/2008 Microsoft
began to support WSASendMsg a mostly compatible implementation of sendmsg.
Neither are part of the WinSock API and therefore they must be loaded
at runtime via a WSAIoctl() call to obtain the function pointers.
When the functions are available it is now possible to avoid a large
number of memcpy() calls.
This patch also enables UDP port unreachable messages on XP and above.
LICENSE MIT
In rx_SlowWritePacket the use of RX_MAXWVECS was incorrect. The
niovecs field is allocated as [RX_MAXWVECS+1] with the 0th element
reserved for the rx header. niovecs[RX_MAXWVECS] is therefore a
valid data buffer and the comparison should be (i <= RX_MAXWVECS).
This error has most likely not been noticed previously because
nothing in the OpenAFS source tree uses this function.
LICENSE MIT
Modify the cm_BPlusDirEnum interface:
* add the cm_scache_t * of the directory being enumerated to the
cm_direnum_t object
* remove the cm_scache_t * from the cm_BPlusDirEnumBulkStat call
now that it is part of the cm_direnum_t object
* maintain a reference to the cm_scache_t for the life of the
cm_direnum_t object. This ensures that the object cannot be
recycled while the enumeration is in use.
