Commit Graph

5210 Commits

Author SHA1 Message Date
Jeffrey Altman
4274e854c5 windows-build-20080815
LICENSE MIT

remove duplicate rules for man-pages
2008-08-16 18:39:33 +00:00
Jeffrey Altman
dbd98583d3 windows-rx-extra-packets-20080816
LICENSE MIT

Make the default number of pre-allocated rx packets equal to the number
of threads times the rx window size.
2008-08-16 18:00:50 +00:00
Jeffrey Altman
ffbee95174 windows-pioctl-getdrivetype-20080816
LICENSE MIT

Use GetDriveType() to check if the current path is a local disk.
If it is, fail the pioctl attempt immediately.  This should avoid
the reported 30 second delay in the AFS Shell Extension.
2008-08-16 17:48:17 +00:00
Jeffrey Altman
20d38bc268 windows-freelance-deadlock-20080815
LICENSE MIT

avoid a deadlock in cm_reInitLockMountPoints() and make the function
useful again by actually using the index value in the construction
of the FIDs
2008-08-15 21:17:02 +00:00
Jeffrey Altman
aa011cc0d8 windows-shlibafsauthent-20080814
LICENSE MIT

export pioctl_utf8
2008-08-15 00:37:20 +00:00
Jeffrey Altman
357223aefd windows-server-dereference-null-two-20080814
LICENSE MIT

protect against a potential null pointer dereference of a cm_server_t
object
2008-08-14 21:22:49 +00:00
Jeffrey Altman
90fe95e994 windows-server-dereference-null-20080814
LICENSE MIT

protect against a null pointer dereference of a cm_server_t object
2008-08-14 21:19:34 +00:00
Jeffrey Altman
f430aee67c windows-memdump-20080814
LICENSE MIT

add locks, waiting lock requests, smb user, smb tid, and cell expiration
to the memory dump output (fs memdump)
2008-08-14 18:23:28 +00:00
Jeffrey Altman
06b5006517 windows-free-server-deadlock-20080813
LICENSE MIT

avoid a deadloc when freeing servers.  cm_serverLock must be released
around cm_GCConnections()
2008-08-14 03:36:43 +00:00
Jeffrey Altman
4e7e66d4dc windows-search-cell-file-20080813
LICENSE MIT

if a cell has been found with addresses and the next cell name
is reached before the EOF, return success.

If the cell has been found and there are no addresses, return -6
2008-08-14 03:32:54 +00:00
Jeffrey Altman
919fb5e14b rx-buffer-allocation-corrected-20080813
LICENSE MIT

a corrected version of delta rx-buffer-allocation-20080812
2008-08-14 03:27:36 +00:00
Jeffrey Altman
844d7e5707 windows-build-man-pages-20080813
LICENSE MIT

move building of man pages to installer phase
2008-08-14 03:15:34 +00:00
Derrick Brashear
04a25e0a40 nfstrans-extra-protection-20080813
LICENSE IPL10

ensure, at least, that there is a filehandle for everything we check
2008-08-14 00:49:15 +00:00
Rainer Toebbicke
e5bf9b91ea salvager-dont-corrupt-dir-lengths-20080812
LICENSE IPL10
FIXES 111585

make the int64 macros work when the "64 bit" number to fill isn't.
use the correct variable type for length in salvager
2008-08-14 00:44:16 +00:00
Jeffrey Altman
156b13f74d rx-buffer-allocation-pulled-20080813
LICENSE MIT

remove delta rx-buffer-allocation-20080812 as it leads to data corruption
2008-08-13 15:10:42 +00:00
Jeffrey Altman
643a632a38 rx-buffer-allocation-20080812
LICENSE MIT

Prevent rxi_MorePacketsNoLock() from dereferencing a NULL pointer if
the requested allocation size cannot be satsified.  In that case back
off the number of packets until osi_Alloc() succeeds or panic if no
packets can be allocated at all.

In AllocPacketBufs() do not transfer more than rx_TSFPQGlobSize packets.

Modify RX_TS_FPQ_GTOL2() macro to protect against transfering more packets
that are actually free.

Modify RX_TS_FPQ_COMPUTE_LIMITS() to enforce a rx_TSFPQGlobSize maximum
value of 64 packets to prevent ever increasing allocation sizes within
AllocPacketBufs()
2008-08-12 19:39:59 +00:00
Jeffrey Altman
c19c4b3ebb windows-stack-overruns-20080811
LICENSE MIT

prevent stack overruns
2008-08-12 05:29:52 +00:00
Jeffrey Altman
1f6c7ca14a windows-fs-mkmount-20080811
LICENSE MIT

fix volume name validity test.  strip trailing '.' from volume name
2008-08-12 00:54:48 +00:00
Jeffrey Altman
eaf2843a81 windows-make-nls-win2000-compat-20080809
LICENSE MIT

make the nls module compatible with windows 2000.
cannot use LOCALE_INVARIANT instead must lie and
say everyone is US English.  windows 2000 does not
have normalization functions and now doesn't have
case insensitive string comparison functions either
for languages other than English.

====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
LICENSE MIT

not all applications that link to cm_nls perform initialization.
Call initialization if it has not already been done explicitly.
2008-08-10 01:00:59 +00:00
Jeffrey Altman
d5af3b4236 windows-freelance-deadlock-20080809
LICENSE MIT

avoid a deadlock between cm_freelanceLock and cm_scacheLock
2008-08-09 23:31:09 +00:00
Jeffrey Altman
cd316ff51c windows-rx-udpbufsize-20080809
LICENSE MIT

Set UdpBufSize to 256K.  Add RxUdpBufSize registry value to permit
runtime configuration.
2008-08-09 05:52:36 +00:00
Jeffrey Altman
4eea9caac3 windows-smb-skip-nuls-20080809
LICENSE MIT

rename SMB_STF_IGNORENULL to SMB_STF_IGNORENUL

apply SMB_STR_IGNORENUL when copying length tagged strings into
the smb response packets.
2008-08-09 05:48:10 +00:00
Jeffrey Altman
423cdb708f windows-lock-corrections-20080808
LICENSE MIT

Derrick helped identify a few locations where rw or mx locks where
not properly being tracked.  As a result there were some locations
in which an assertion could be thrown due to releasing the wrong
type of lock.

Also added lock_AssertXXX calls to some locations to ensure that
the correct lock type is being held when the calls are made.  volume
location updates, cm_SyncOp, cm_SyncOpDone.
2008-08-08 17:43:37 +00:00
Jeffrey Altman
425d6e2e15 windows-max-cell-name-20080807
LICENSE MIT

Anywhere cm_GetCell_Gen() is called CELL_MAXNAMELEN must be used
otherwise there will be a stack overflow error.
2008-08-07 14:46:11 +00:00
Jeffrey Altman
467ac5e32d windows-misc-20080806
LICENSE MIT

Return CM_ERROR_READONLY if the caller wants PRSFS_DELETE and the
volume is readonly.

In cm_CheckNTDelete() do not call cm_SyncOpDone if cm_SyncOp failed

Do not force the use of fake directory data if the user does not
have PRSFS_READ on the directory.  Let the bulkstatus call take
place now that it is actually being used efficiently.

In ApplyV3SearchDirPatches, use cm_SyncOp(CM_SCACHESYNC_GETSTATUS)
to obtain the status info for Freelance entries instead of the
bulkstatus call.

Fix the truncation of 8.3 names in directory search responses.
2008-08-07 06:35:36 +00:00
Jeffrey Altman
d0ed34baa0 windows-cell-name-length-consistency-two-20080806
LICENSE MIT

fix what I broke
2008-08-06 21:25:43 +00:00
Jeffrey Altman
d44f1a17e4 windows-afssw-20080806
LICENSE MIT

prevent buffer underrun and overrun errors
2008-08-06 06:10:14 +00:00
Jeffrey Altman
255d055e61 windows-cell-name-length-consistency-20080806
LICENSE MIT

make all cell name lengths consistent so that safer string copy/cat
functions can be used to prevent buffer overruns
2008-08-06 06:09:34 +00:00
Jeffrey Altman
aab4b2b32f windows-getaccessrights-20080805
LICENSE MIT

Do not permit GetAccessRights() to be called multiple times within
cm_SyncOp for the same rights check.  If the GetAccessRights() succeeded
and in the next loop the rights check fails, the user simply doesn't
have the rights.

Move a call to cm_SyncOpDone(FETCHSTATUS) from GetBuffer() to MergeStatus().
Anytime an RPC completes successfully we get updated status info for
the object.  Might as well allow threads waiting for status info to us
it.
2008-08-05 16:45:35 +00:00
Jeffrey Altman
a021b79556 windows-ioctl-make-submount-20080802
LICENSE MIT
FIXES 109951

Restore the ascii version of cm_NormalizeAfsPathAscii() so that it
can be used by cm_IoctlMakeSubmount().
2008-08-03 04:28:32 +00:00
Jeffrey Altman
1fbbaaa878 windows-afsconfig-header-20080802
LICENSE MIT

Enable Bos Restricted mode for Windows
2008-08-02 20:46:14 +00:00
Jeffrey Altman
cc8e39872e windows-smb-dir-search-20080802
LICENSE MIT

Apply the bulk stat improvements to smb_ApplyDirListPatches() and
smb_ReceiveCoreSearchDir() for consistency even though
smb_ReceiveCoreSearchDir() is no longer called by any of the platforms
we support.

====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
LICENSE MIT

Only return 50 items at a time to the caller.
Do not apply patches based on buffer boundaries.  Instead
apply patches when AFSCBMAX entries are ready to be processed
in order to minimize the number of RPCs.
2008-08-05 15:29:14 +00:00
Jeffrey Altman
b9e0ab9f5b windows-smb-dir-search-20080801
LICENSE MIT

minimize the number of RPCs sent to the file server. only request
status for objects that we are actually reporting on and only if
we do not already have status for the object
and then make sure that we return as much as we can at once but
not so much that it exceeds the RDR timeout
2008-08-02 05:56:57 +00:00
Jeffrey Altman
807a9aa7b2 windows-scache-deadlock-20080801
LICENSE MIT

do not recycle a deleted scache object unless the refcount is 0
2008-08-01 22:35:06 +00:00
Jeffrey Altman
0c0b89e046 windows-smb-dumpvars-20080801
LICENSE MIT

When dumping the smb data structs, report flags in hex and
paths are now wchar_t strings.
2008-08-01 22:01:49 +00:00
Jeffrey Altman
005077a7e4 windows-smb-warnings-20080801
LICENSE MIT

cast away a number of compile time data size warnings
2008-08-01 14:36:54 +00:00
Jeffrey Altman
1f7ab13b6f windows-smb-vc-refcount-debugging-20080801
LICENSE MIT

define DEBUG_SMB_REFCOUNT in smb.h to activate refcount debugging
versions of the functions that log the file and line number as
well as object and refcount.  This is for use in debugging refcount
leaks.

rename GetPacket and GetNCB to smb_GetPacket and smb_GetNCB, etc.,
to enforce the name space.  Do not confuse with similar Win32 API
functions.

restructure some code that refers to smb_vc_t references in order
to clarify where the refcount is dropped.
2008-08-01 14:30:21 +00:00
Jeffrey Altman
ebf66eff4b windows-smb-dead-vc-gc-on-head-20080801
LICENSE MIT

deltas windows-smb-dead-vc-gc-20080627 and
windows-dead-vc-cleanup-take-two-20080703 attempted to
protect against an infinite recursion when cleaning up
dead smb virtual circuits.  they failed to address the
incrementing of the vc refcount in smb_ReleaseVCInternal
when it is about to call smb_CleanupDeadVC.  If the vc
is already being cleaned, then smb_ReleaseVCInternal
should not increment the refCount and should not call
smb_CleanupDeadVC.

(This commit was committed incorrectly to the 1-5
branch first.  delta name on the head was modified
to avoid the delta name collision.)
2008-08-01 14:14:50 +00:00
Jeffrey Altman
c38036761e windows-osilog-20080731
LICENSE MIT

increase the number of parms from 4 to 5 for osi_Log
2008-08-01 05:22:08 +00:00
Jeffrey Altman
91d1501be5 windows-ioctl-create-mount-point-validate-volume-20080731
LICENSE MIT

validate the specified volume to make sure it exists before permitting
the mount point to be created.   This will catch many instances in which
the user swaps the parameters to "fs mkmount".
2008-07-31 18:01:12 +00:00
Jeffrey Altman
14e516f1d5 windows-wix-custom-20080731
LICENSE MIT

in c++, arrays allocated with new[] must be deallocated with delete[]
2008-07-31 13:43:00 +00:00
Jeffrey Altman
a46b1879dc windows-handle-vl_badname-20080731
LICENSE MIT

Process VL_BADNAME so that when a user creates an mount point with
an invalid volume name we will do something sane.
2008-07-31 13:37:29 +00:00
Jeffrey Altman
b61ac7dc6f windows-volume-recycling-race-condition-20080731
LICENSE MIT

When recycling cm_volume_t objects, avoid a race condition that could
result in the same cm_volume_t object being recycling simultaneously
in two threads.  The end result would be a reference count miscount
and an undercount assertion being thrown.
2008-07-31 05:45:44 +00:00
Jeffrey Altman
aa24715f06 windows-buf-clean-error-handling-20080731
LICENSE MIT

When an error such as access denied, out of space, out of quota,
invalid fid, etc. is received while writing a dirty buffer to the
file server, apply that error code to all outstanding dirty buffers
immediately instead of attempting to write each buffer to the file
server only to obtain the same error.
2008-07-31 05:39:29 +00:00
Jeffrey Altman
24fd571c52 windows-remove-unnecessary-malloc-include-20080731
LICENSE MIT

remove unnecessary #include <malloc.h>
2008-07-31 05:32:57 +00:00
Jeffrey Altman
8c22d2388a windows-stat-resource-files-20080730
LICENSE MIT

Add version resource info to xstat_cm_test.exe and xstat_fs_test.exe
2008-07-30 23:16:24 +00:00
Jeffrey Altman
34923419b3 viced-write-perm-grants-read-lock-20080730
LICENSE MIT

Remove extra return(EACCES) added by delta
viced-write-perm-grants-read-lock-20070423 on head and 1.5 branch.
2008-07-30 21:00:21 +00:00
Jeffrey Altman
8cce5d2a61 windows-buf-overquota-20080728
LICENSE MIT

propagate overquota errors through buf_Write() and cm_FSync().
2008-07-29 03:54:34 +00:00
Jeffrey Altman
b45b059ed9 windows-large-files-20080728
LICENSE MIT

as part of the restructuring of code to separate the smb layer
from the cm layer, large file support was broken.   Define AFS_LARGEFILES
in the right place so that it will be used in the cm.
2008-07-28 23:57:24 +00:00
Hartmut Reuter
674e94b29c salvager-avoid-directory-issues-and-mark-volumes-busy-20080728
LICENSE IPL10
FIXES 107767

avoid corrupting length in vnodeds when salvaging directories.
avoid tag reuse leaving data behind (not verified)
avoid not marking something busy during salvage
2008-07-28 13:58:30 +00:00