5511 Commits

Author SHA1 Message Date
Jeffrey Altman
41695e42e8 DEVEL15-windows-buf-shutdown-20080829
LICENSE MIT

During buf_Shutdown() all dirty buffers should be written to the file
server if they can be.


(cherry picked from commit ccdf50ade371de595abe20f5a6b0ff149ce9ae79)
2008-08-30 03:15:07 +00:00
Jeffrey Altman
665f1b9a01 DEVEL15-windows-afsd-shutdown-20080829
LICENSE MIT

reorganize the service shutdown order to permit dirty buffers to be
flushed to the file server without competition from incoming requests.


(cherry picked from commit 2da64d02a2707a3c9220951a30b5cea8464b9ef9)
2008-08-30 03:06:28 +00:00
Jeffrey Altman
54a0f07111 DEVEL15-windows-check-servers-20080828
LICENSE MIT

if the server count is zero, don't both trying


(cherry picked from commit 00fee5efee68f1647fa810dffa7ad991235d01c5)
2008-08-28 10:47:41 +00:00
Jeffrey Altman
64b8b64495 DEVEL15-windows-check-server-heap-overwrite2-20080827
LICENSE MIT

the incorporation of nconns into the foo incremental was a mistake


(cherry picked from commit 43eb87a916b87c6037841ea38cde616014d892a8)
2008-08-28 00:44:03 +00:00
Jeffrey Altman
60a3670e19 DEVEL15-windows-check-server-heap-overwrite-20080827
LICENSE MIT

Protect against a heap overwrite that could occur is the number of file
servers or vldb servers grows while the maximum number of connections
is computed and when the connection list is populated.


(cherry picked from commit e68255c12c444e36b7ca7f1864d964cd3a0bcda8)
2008-08-27 23:09:56 +00:00
Jeffrey Altman
c96303577a DEVEL15-windows-callback-lock-order-20080827
LICENSE MIT

do not hold cm_server_t mutex when calling cm_FindVolumeByID because
the cm_volume_t lock must be obtained ahead of the cm_server_t mutex


(cherry picked from commit 0affa4b86a08c3be9cb4edc4c9f680ae02a2fcd8)
2008-08-27 23:03:19 +00:00
Jeffrey Altman
d090881286 DEVEL15-windows-lock-order-20080827
LICENSE MIT

do not hold cm_scacheLock while obtaining cm_scache_t->rw


(cherry picked from commit c50857b05e6636bef864c9418b21d1bf3c63494a)
2008-08-27 13:18:04 +00:00
Jeffrey Altman
32ad8285cd DEVEL15-windows-short-names-20080827
LICENSE MIT

plus and equal are not valid characters in short names.
we replace them with left and right brace in order to
minimize the instability in the file names.


(cherry picked from commit bef68684fd7bb4e58e621766a0f2abbdfd15af80)
2008-08-27 12:49:20 +00:00
Matt Benjamin
8703e7f1a5 DEVEL15-freebsd-70-client-20080826
LICENSE IPL10

FreeBSD 7.0 client support (and 8.0 support but that's a moving target)


(cherry picked from commit a123bd8ccde0d6baf04401201b1672b19e9778db)
2008-08-26 15:59:52 +00:00
Tom Keiser
be677d800b DEVEL15-studio12-solaris-updates-20080826
LICENSE IPL10
FIXES 113671

update so we build with studio 12 on solaris


(cherry picked from commit 4d245c6a19394d54a241bd612016b10d1113ee7b)
2008-08-26 15:11:46 +00:00
Derrick Brashear
b9cabc6477 DEVEL15-linux-rpm-make-dkms-remove-work-20080826
LICENSE IPL10

rpm -e failed because of a typo here when removing our dkms rpm


(cherry picked from commit 82c62ae0e3b6366c9cdef0569e5be4637127e586)
2008-08-26 14:44:43 +00:00
Jeffrey Altman
740bb7a7b2 DEVEL15-windows-scache-lock-20080825
LICENSE MIT

restore a missing obtain write lock


(cherry picked from commit e16c4f8a96f0568d5f7155c88f9b877baa500b7d)
2008-08-26 05:56:42 +00:00
Jeffrey Altman
23b2990d35 DEVEL15-windows-misc-20080825
LICENSE MIT

avoid a deadlock in cm_GiveUpAllCallbacks

log UAEEXIST / EEXIST in cm_Analyze


(cherry picked from commit e0380d54bad50582b6bc39e2b41e78d72117ec79)
2008-08-26 05:38:44 +00:00
Jeffrey Altman
cd99ca3b39 DEVEL15-windows-client-osi-20080825
LICENSE MIT

add more asserts to attempt to catch locks released in threads other
than the one that obtained them.


(cherry picked from commit cb455744d49f250c236ab24cdcfffda104ef3774)
2008-08-26 05:16:02 +00:00
Derrick Brashear
dfc6d001f1 DEVEL15-server-argument-consistency-and-jumbograms-off-20080824
LICENSE IPL10
FIXES 108703

go through and make servers able to take debug log level on command line;
add -jumbo; default to -nojumbo


(cherry picked from commit 12c8abc69030d3368194b148c692215c61b5da9c)
2008-08-25 02:14:59 +00:00
Jeffrey Altman
15418516cc DEVEL15-windows-smb-more-check-open-done-20080824
LICENSE MIT

call cm_CheckNTOpenDone() in error conditions as well


(cherry picked from commit a88d12746a9e7e8e79a80c5bcafda449810b4e22)
2008-08-24 22:46:42 +00:00
Jeffrey Altman
1cdb4d92f9 DEVEL15-windows-prefetch-lock-order-20080824
LICENSE MIT

lock order violation between cm_daemonLock and cm_scache_t rw lock


(cherry picked from commit 82741251b1f444a1f18e3b9816f8cadac3e168b5)
2008-08-24 18:47:43 +00:00
Jeffrey Altman
a330485dee DEVEL15-windows-smb-locks-20080224
LICENSE MIT

smb_dirSearch_t refCount field is protected by smb_globalLock not the
smb_dirSearch_t mutex.

Do not hold the smb_fid_t mutex across calls to smb_NotifyChange()


(cherry picked from commit 24f8b1b4c327c3fb01a575ccb46d5ae6bf7edd36)
2008-08-24 17:33:06 +00:00
Jeffrey Altman
15467848df DEVEL15-windows-check-nt-open-lock-sync-20080224
LICENSE MIT

Move cm_SyncOpDone(CM_SCACHESYNC_LOCK) from cm_CheckNTOpen to
cm_CheckNTOpenDone.  This is necessary to synchronize lock operations.


(cherry picked from commit cc48a5a3b4d328127ca56c1a5845ec6cac136548)
2008-08-24 17:27:24 +00:00
Derrick Brashear
0f0725dcdc DEVEL15-darwin-fake-afs-bigger-20080822
LICENSE IPL10
FIXES 112564

set up max uint64 "free" in afs so finder isn't dumb.


(cherry picked from commit 186f707378ce0c04705170743cbc67ff44e1c93f)
2008-08-22 20:26:48 +00:00
Derrick Brashear
96431d61b2 DEVEL15-analyze-srvr-safety-check-20080822
LICENSE IPL10
FIXES 112681

safety check to make sure a conn's srvr is set before dereferencing it


(cherry picked from commit ea81e608bae42ea84d7bc85d289bfe6f24d8d383)
2008-08-22 19:52:57 +00:00
Jeffrey Altman
629ec8b276 DEVEL15-windows-misc-20080822
LICENSE MIT

1. In multi-threaded applications deadlocking is always a problem.
Deadlock avoidance requires a strict adherence to a documented
hierarchy.  The lock hierarchy for OAFW is described in a file
called locks.txt.  There are two problems.  First, some of the
locks are not included in locks.txt.  Second, it is nearly
impossible given the depth of function calls for any programmer
 to identify all of the locks that are held at any given time
a function is called.  This patch implements a new locking order
verification mechanism.  Each lock is assigned a lock level at
initialization.  Each thread maintains a queue of held locks.
Each time a lock is acquired the queue is checked to ensure that
no locks with a higher level than the requested lock has already
been acquired.  If a violation occurs, the service panics.

2. When the service panics ensure that a minidump will always be generated.

3. Remove unused lock cm_bufGetMutex.

4. The lock order verifier identified approximately a dozen
lock order violations that are corrected.

5. A race condition within the function path cm_GetSCache() ->
cm_GetNewSCache() -> cm_RecycleSCache() permitted a cm_scache_t
object to be issued simultaneously to two threads.  This would
eventually result in a panic due to the resulting under count.

6. Fix interpretation of the empty string as the ioctl path to
mean the current directory.   "fs lsm", "symlink list", etc.
now return a "not a ..." error instead of "does not exist".

7. Add SMB_STRF_SRCNULTERM flag to smb_ParseStringXXX functions
to indicate that the input string is a nul terminated string.
Assign it when input strings are nul terminated.

8. The CIFS protocol specification for handling NT_TRANSACT_CREATE
does not match the observed behavior.  The 'nameLength' is specified
in bytes not in characters.  Fix the implementation to match.

9. The cm_HaveAccessRights() attempt at deadlock avoidance by calling
lock_TryRead() on the parent directory cm_scache_t rw-lock does not
avoid the deadlock.  Avoid the deadlock by enforcing the lock order
of lowest vnode first.  Then remove the infinite loop avoidance in
cm_SyncOp() that was returning an unwarranted access denied error.


(cherry picked from commit ef10390e12ffd697f9eaaacd1d7291e05d16c835)
2008-08-22 19:10:00 +00:00
Derrick Brashear
e4c9c47cd1 DEVEL15-rx-allow-jumbogram-disabling-really-20080822
LICENSE IPL10

right now, jumbograms can still be sent when -nojumbo is specified. make the
current macro a default and override when we're supposed to.


(cherry picked from commit 46dbd678714110002a36269beca8961e013650ac)
2008-08-22 05:31:48 +00:00
Jeffrey Altman
d26c86abe6 DEVEL15-windows-list-symlink-20080820
LICENSE MIT

Another casaulty of the Unicode transition, the return value of the
ListLink operation was not being convered from wchar to char before
it was copied into the output buffer.


(cherry picked from commit a00f706eb67c257af9892557cfb6ad35594144cf)
2008-08-20 20:46:16 +00:00
Jeffrey Altman
b2030e2942 DEVEL15-windows-afsd-service-20080820
LICENSE MIT

When afsd_service.exe is not running as a service do not call the
Service Manager functions.  Doing so causes invalid access exceptions
to be thrown in the kernel and can corrupt the heap.


(cherry picked from commit 9488898fdb22e8c999ad4f713bd656caba91fe1c)
2008-08-20 20:42:47 +00:00
Derrick Brashear
18398383f9 DEVEL15-redhat-spec-default-build-authlibs-20080820
LICENSE IPL10
FIXES 101879

make build_authlibs default usefully


(cherry picked from commit 651f25b9c84b57cb88e2066c91c5234399673164)
2008-08-20 19:45:28 +00:00
Jeffrey Altman
c8fd90bc45 DEVEL15-windows-notes-20080816
LICENSE MIT

1.5.52
2008-08-16 22:01:15 +00:00
Jeffrey Altman
69245d9427 DEVEL15-windows-des-20080816
LICENSE MIT

codesign binaries
2008-08-16 20:19:02 +00:00
Derrick Brashear
8b5faafec6 DEVEL15-namei-by-default-on-sol10-20080816
LICENSE IPL10

default to namei, not inode, on solaris 10 except by request


(cherry picked from commit 03982bd54839f81cdc691ad83e946fac8f8789b7)
openafs-devel-1_5_52
2008-08-16 22:37:39 +00:00
Dan Hyde
2ca7bc4dbc DEVEL15-volser-initialize-volume-updatedate-20080816
LICENSE IPL10
FIXES 110943

right now this isn't set until a vnode update happens. technically creating
the root directory is an update, so let's set it to now.


(cherry picked from commit b080c5d82ba5c7641afeb6836961cacf283e4902)
2008-08-16 21:07:45 +00:00
Tracy Di Marco White
7cea963d18 DEVEL15-netbsd-sigwait-broken-til-nbsd5-20080816
LICENSE IPL10
FIXES 111404

work around netbsd sigwait brokenness


(cherry picked from commit 8190e75b38a7cd136ce70050fdd71b1d62888055)
2008-08-16 20:46:55 +00:00
Marc Dionne
64ae64e972 DEVEL15-linux-2-6-27-20080816
LICENSE IPL10
FIXES 111634

add support for 2.6.27, which removes asm/semaphore.h


(cherry picked from commit d7a5619e5bd8241dd13611a4be37f04f3aa4ed27)
2008-08-16 20:42:56 +00:00
Jeffrey Altman
352a43e8d3 DEVEL15-windows-build-20080815
LICENSE MIT

remove duplicate rules for man-pages


(cherry picked from commit 4274e854c58655ae2d1142ec3e08d62aebb07be0)
2008-08-16 18:59:03 +00:00
Jeffrey Altman
73238231d3 DEVEL15-no-more-win95-20080816
LICENSE MIT

remove win95 pthread dll from the build
2008-08-16 18:49:42 +00:00
Jeffrey Altman
2845970e5c DEVEL15-windows-version-20080816
LICENSE MIT

1.5.5200.0 == 1.5.52
2008-08-16 18:15:51 +00:00
Jeffrey Altman
11b6b00e0e DEVEL15-windows-rx-extra-packets-20080816
LICENSE MIT

Make the default number of pre-allocated rx packets equal to the number
of threads times the rx window size.


(cherry picked from commit dbd98583d35d6aea57cb4d9c46790479dc1a137e)
2008-08-16 18:11:01 +00:00
Jeffrey Altman
a879900469 DEVEL15-windows-pioctl-getdrivetype-20080816
LICENSE MIT

Use GetDriveType() to check if the current path is a local disk.
If it is, fail the pioctl attempt immediately.  This should avoid
the reported 30 second delay in the AFS Shell Extension.


(cherry picked from commit ffbee95174ad1fffecff2889e80e168cea60a531)
2008-08-16 17:50:06 +00:00
Jeffrey Altman
7d3578448c DEVEL15-windows-freelance-deadlock-20080815
LICENSE MIT

avoid a deadlock in cm_reInitLockMountPoints() and make the function
useful again by actually using the index value in the construction
of the FIDs


(cherry picked from commit 20d38bc268b13258e2358591756824d712cdb403)
2008-08-15 21:19:06 +00:00
Jeffrey Altman
a41fa0ac3e DEVEL15-windows-shlibafsauthent-20080814
LICENSE MIT

export pioctl_utf8


(cherry picked from commit aa011cc0d8bbff96d5772d0069520b41826c3857)
2008-08-15 00:39:12 +00:00
Jeffrey Altman
cd679c0f77 DEVEL15-windows-server-dereference-null-two-20080814
LICENSE MIT

protect against a potential null pointer dereference of a cm_server_t
object


(cherry picked from commit 357223aefd86c007987333b2a8859faa33f21424)
2008-08-14 21:24:03 +00:00
Jeffrey Altman
e97f32c493 DEVEL15-windows-server-dereference-null-20080814
LICENSE MIT

protect against a null pointer dereference of a cm_server_t object


(cherry picked from commit 90fe95e994efe62175959aab95c276898f1ff54c)
2008-08-14 21:21:27 +00:00
Jeffrey Altman
97e1874be5 DEVEL15-windows-memdump-20080814
LICENSE MIT

add locks, waiting lock requests, smb user, smb tid, and cell expiration
to the memory dump output (fs memdump)


(cherry picked from commit f430aee67c4f3d1f3c644f97c30db081d2a9880f)
2008-08-14 18:25:04 +00:00
Jeffrey Altman
a25496c930 DEVEL15-windows-release-notes-20080813
LICENSE MIT

1.5.52
2008-08-14 04:18:07 +00:00
Jeffrey Altman
dd5c58676d DEVEL15-windows-notes-20080813
LICENSE MIT

1.5.52
2008-08-14 03:55:30 +00:00
Jeffrey Altman
ae47334e2b DEVEL15-windows-free-server-deadlock-20080813
LICENSE MIT

avoid a deadloc when freeing servers.  cm_serverLock must be released
around cm_GCConnections()


(cherry picked from commit 06b5006517c77767a246df2b6d66a344a44cbea1)
2008-08-14 03:37:59 +00:00
Jeffrey Altman
48b4da2140 DEVEL15-windows-search-cell-file-20080813
LICENSE MIT

if a cell has been found with addresses and the next cell name
is reached before the EOF, return success.

If the cell has been found and there are no addresses, return -6


(cherry picked from commit 4e7e66d4dc14513e1beed465fc5180429571921b)
2008-08-14 03:34:32 +00:00
Jeffrey Altman
5eeeb68765 DEVEL15-rx-buffer-allocation-corrected-20080813
LICENSE MIT

a corrected version of delta rx-buffer-allocation-20080812


(cherry picked from commit 919fb5e14bdcde66218e64cfdd7fecccab67d8f5)
2008-08-14 03:29:02 +00:00
Jeffrey Altman
43159c0b24 DEVEL15-windows-build-man-pages-20080813
LICENSE MIT

move building of man pages to installer phase


(cherry picked from commit 844d7e570772ab2bdbfa2d59ac0f48afff37d8b7)
2008-08-14 03:21:42 +00:00
Derrick Brashear
3857273bf5 DEVEL15-nfstrans-extra-protection-20080813
LICENSE IPL10

ensure, at least, that there is a filehandle for everything we check


(cherry picked from commit 04a25e0a4057b63cf7c700b17b1a6ab28e469547)
2008-08-14 00:49:26 +00:00
Rainer Toebbicke
4bd0a52beb DEVEL15-salvager-dont-corrupt-dir-lengths-20080812
LICENSE IPL10
FIXES 111585

make the int64 macros work when the "64 bit" number to fill isn't.
use the correct variable type for length in salvager


(cherry picked from commit e5bf9b91eaf8cb930c6cf70419983901907db84d)
2008-08-14 00:44:29 +00:00