includes updated instructions for updating.
note that gen_glue.c in lib/asn1 has a bug which omits
a needed newline in the "const struct units * asn1_%s_units(void);",
line.
FIXES 127554
Change-Id: Ibc880bf51419d51de40b33d8c43122e592971b0b
Reviewed-on: http://gerrit.openafs.org/2306
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
For the case where the cached vp->header can be re-used by
GetVolumeHeader(), we have not been re-setting the VOL_HDR_IN_LRU
state bit. Although this has not affected correctness (this
bit is merely used to aid in debugging), we should be resetting
it in all relevant cases...
Change-Id: I2ad2b8c5070470beb067efdcda6f76f6b72c006c
Reviewed-on: http://gerrit.openafs.org/2308
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Commit e59a0ff993 generated a warning
since we try to assign NULL into a character. Just remove this code,
since removing trailing whitespace was already handled by commit
df18c9e895.
Change-Id: I915c0678a2f6893e09cf049bf71c519be554369f
Reviewed-on: http://gerrit.openafs.org/2303
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
The kernel has been compiled with -mno-red-zone since at least
FreeBSD 5.0; when we compile libafs.ko with red zones enabled
and interact with the red-zone-less kernel, we get occasional
stack corruption, which manifests itself in a variety of
unpleasant ways.
The flags we pass to gcc for our module build currently differ
substantially from those used during a kernel build (or modules
built with the kernel); I hope to transition to a module build
process involving bsd.kmod.mk in the relatively near future.
Change-Id: I406e264c1f96e1d893b9d12b561f48a3cbfdf57c
Reviewed-on: http://gerrit.openafs.org/2297
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This patch adds a -human option to fs df, which causes it to printout
all of its values in "human-readable" form (i.e. rounded to roughly
the nearest power of 1024).
FIXES 124529
Change-Id: I98e4c872abec5784c6ec600d5d977c36f4a8b0ac
Reviewed-on: http://gerrit.openafs.org/2301
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Corrects an EOL bug in vlclient and adds a more user-friendly
handling of request for help (i.e., '-help' now works)
FIXES 125036
Change-Id: I70f6523d538e34a02536e482f99916293a195df5
Reviewed-on: http://gerrit.openafs.org/2300
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Fix VLog() so that it actually uses the loglevels and does not set
all log messages to level 5.
FIXES 125035
Change-Id: Ia9f42a814be182215cedadb6a4837347ace32f41
Reviewed-on: http://gerrit.openafs.org/2299
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
If we fail to flush a vnode, in addition to printing a diagnostic
message, also print information about the vnode; fs getfid can
frequently confirm which vnode(s) are problematic, which may be
useful in debugging the failure.
Change-Id: Ia6e93f436f9dcd2d634c46856ede5effbf79e9cb
Reviewed-on: http://gerrit.openafs.org/2296
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Chaskiel added a commented-out call to vinvalbuf() in
revision bd707fb7e6 back in 2002; adding in what the
current call should be does not seem to cause any problems
for me.
Change-Id: I2450fbaaa51b5baf2781e8a6572065e5f69b44ed
Reviewed-on: http://gerrit.openafs.org/2295
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
We need to hold the interlock when we check v_flags, so do so.
TryToSmush is sometimes called with the vnode already locked,
as the current code appears to hold the vnode lock for the
current working directory (which is probably a bug). Check if
the lock is already held (panic if someone else has it!), and
unlock as appropriate when we're done.
Change-Id: Id09ef1e10632c7f63b590271a6339a069176deac
Reviewed-on: http://gerrit.openafs.org/2294
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
I'm about to touch this, and the whitespace was bothering me.
Change the six-space indentations to match the rest of the code.
Change-Id: I35a12c82f8b2b4644e58cf1f19f021282e43dc77
Reviewed-on: http://gerrit.openafs.org/2293
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
The locking around some interfaces has changed with time.
Make our preprocessor checks match the reality of when
the changes were made.
Change-Id: If933dd636bb908af27852897e9c77ed600759674
Reviewed-on: http://gerrit.openafs.org/2292
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Checkin http://gerrit.openafs.org/#change,2027 appears to have caused
issues with the checked build for vldb_check.
This fixed is by reflecting the structure change into vldb_check
Change-Id: I12343be8a3a31cb2f6474115a8d9137dadd4ae2d
Reviewed-on: http://gerrit.openafs.org/2280
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This patch makes the configure and build system use the output
from 'git describe' to determine the version of the software being
built. This means that all that is necessary to create a new release
is to tag the repository - removing the double sources of version
information.
There are a couple of fallbacks for systems which do not have git
available for builds. Firstly, if a file called '.version' exists
in the top level of the repository, then the version information is
pulled from this file. The intention is that those packaging up
git checkouts for onwards distribution will use
'git describe > .version' before producing their tarballs.
Secondly, if we cannot find any version information then the version
will default to 'UNKNOWN'
This all mirrors the way that many others have integrated git with
automake and friends - although the implementation is independent.
Change-Id: I7fa4605e52181d60657ad794ca8efdb5a9fb1449
Reviewed-on: http://gerrit.openafs.org/1824
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Russ Allbery <rra@stanford.edu>
The client background readahead code and 'readpages' implementation
were only written for 2.6 kernels and used 2.6-specific constructs.
Remove them, along with references to the 'pagecopy' code, and some
other 2.6-only cruft in osi_vnodeops.c.
Change-Id: I2e939e98bd72cd7b275b0f7a389607ee5dc94efa
Reviewed-on: http://gerrit.openafs.org/2271
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
afs_osi_proc2cred contained a 2.4 implementation; remove it, since we
can assume at least 2.6.
Change-Id: I605856e920508cf49a975e5375ade87e00598763
Reviewed-on: http://gerrit.openafs.org/2274
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
afs_backing_dev_info was still referenced in a couple of places in the
LINUX24 code. Although they are properly ifdef-guarded, these lines
were never getting built, so remove them.
Change-Id: I55ffca5dad99124b9d451925c9fcf15b7060bb9b
Reviewed-on: http://gerrit.openafs.org/2273
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
The NEED_IOCTL32 symbol needs to protect the entire if block, not just
the conditionals.
Change-Id: Ie33860b1d5677cec19ed19aa1ccc1ce0a26824ff
Reviewed-on: http://gerrit.openafs.org/2270
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
cr_ref is a regular integer, not an atomic_t, so we need to just
assign '1' to it directly.
Change-Id: I3533c79a67f7be35724cc81553d24bfecb7b81d3
Reviewed-on: http://gerrit.openafs.org/2269
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
The LINUX24 code has a macro and a function abstracting
'struct group_info' access. But 'struct group_info' does not exist in
2.4, and nothing calls these, so get rid of them.
Change-Id: Ic38f5be27d55da9fdf6ce7889d4df6afd1464c0f
Reviewed-on: http://gerrit.openafs.org/2268
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
vlserver.h has a few cases where links through the vldb are being
stored as afs_int32s. These are file offsets and should be unsigned.
This commit fixes just these declarations. The code still compiles
(because they are silently cast all over the shop), but it starts
the tidy effort.
Change-Id: Iba14bd28cb43a6ca6401be4252bb45135d8b3a55
Reviewed-on: http://gerrit.openafs.org/2027
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Turn on the perl use strict and use warnings options in the
make_libafs_tree script to better catch programming bugs.
Change-Id: Ide358d40eda3cde9dd0261af11993560da71143a
Reviewed-on: http://gerrit.openafs.org/2266
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This generalizes the use of the exportfs API and file handles
to open disk cache files for all 2.6 kernels.
Code outside of src/afs/LINUX (ex: afsd) can assume that file
handles are used for all 2.6 kernels and can use AFS_LINUX26_ENV
to check.
Within src/afs/LINUX/osi_file.c, NEW_EXPORT_OPS can be used to
determine if the old exportfs API (pre 2.6.24) or the new one
applies.
All traces of the LINUX_USE_FH define are removed.
FIXES 127530
Change-Id: I6803101c56981f9f674cef581f7299656723fdf3
Reviewed-on: http://gerrit.openafs.org/2260
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
The export_reqhandler function pointer takes an afs_int32*, not an
afs_int32 as the fourth argument.
Change-Id: I89ef9cfd23a5b673cbbb29fc710236cfe1e3c7cf
Reviewed-on: http://gerrit.openafs.org/2257
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Use unsigned IP addresses in the NFS exporter code in libafs. This
modifies the distributed headers exporter.h and nfsclient.h.
Change-Id: Ieaddf21e487ae416d7b003223566c999c64279aa
Reviewed-on: http://gerrit.openafs.org/2256
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Use unsigned IP addresss in bubasics, bucoord, and butc code. This
alters the public tcdata.p.h, but stays away from wire RPCs or
variables used directly with those RPCs.
Change-Id: Ica96172399cafbc2c347f725a966cf1db7ff1128
Reviewed-on: http://gerrit.openafs.org/2255
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Use unsigned IP addresses in vlserver code. This alters some
structures in the public cnvldb.h header.
Change-Id: I62725ad98d2c4e8bfe610ae9a6132fd0f54cc4aa
Reviewed-on: http://gerrit.openafs.org/2254
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Remove some code that will never be compiled or used in the
afs/LINUX24 directory.
This includes code depending on AFS_LINUX26_ENV, and on
LINUX_USE_FH which is never set in 2.4 and is going away
soon anyway.
Change-Id: I972262b45d3518d996756b5dc9f6e6c01450e5cc
Reviewed-on: http://gerrit.openafs.org/2259
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Update the way that we use the AC_INIT macro to match current
autoconf conventions
Change-Id: Ib1ce2acd879683ff8ff178cfbd9776277ba7460f
Reviewed-on: http://gerrit.openafs.org/2265
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Make it clear that makesrpm.pl takes the bz2, rather than gzip'd,
versions of the OpenAFS distribution.
Change-Id: Ifb99448df5c7060186da1f13ee9c38ba95373376
Reviewed-on: http://gerrit.openafs.org/2264
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
We can't build against any of the recent Fedora debug kernels, because
they have options enabled that make criticial symbols GPL-only. Just
skip all debug kernel variants, rather than having to explicitly list
each new Fedora release as it comes out.
Change-Id: I8ed4c04b10facc79fd5a68888ddb10b368b49bef
Reviewed-on: http://gerrit.openafs.org/2263
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Add support for building for Fedora 12 and 13, both i386 and x86_64
Change-Id: I2bb6e86ac81eeae720b8dbf185927f6e55be826c
Reviewed-on: http://gerrit.openafs.org/2262
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Skip comments in the configure.in file, so we don't end up using the
commented out version information.
Change-Id: I14bef1d448b77c915aa04b3fe555b270ce20ac67
Reviewed-on: http://gerrit.openafs.org/2261
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
AFS_NORETURN had a trailing semicolon, which will confuse potential
future additional attribute markers, if used after AFS_NORETURN.
Remove it.
Change-Id: I21fd6b874728b8ca74d0e8abd783cd5015f63e97
Reviewed-on: http://gerrit.openafs.org/2258
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
ptserver defined the symbol IP_WILDCARDS to enable the use of
wildcarding in machine entries. It is always enabled, so just remove
the symbol and always use the wildcard code.
Change-Id: I7d45de5ef1bb0d2c95f1e1ea86fd4418cf3ddd62
Reviewed-on: http://gerrit.openafs.org/2253
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Use unsigned IP addresses in ptserver code. This alters some
prototypes in the public ptuser.h header.
Change-Id: Id121f32cb0b6acd575822d37bbd814636023e9ae
Reviewed-on: http://gerrit.openafs.org/2252
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
RX sometimes uses afs_int32 to represent IP addresses; make it use
afs_uint32. This alters some structures in rx.h and some prototypes in
rx_prototypes.h.
Change-Id: I97df8a5de8f5e0355ab2056825de68bb7122e439
Reviewed-on: http://gerrit.openafs.org/2251
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Fix code and header files in src/volser that use afs_int32 for server
IP addresses instead of afs_uint32 (the worst offenders being UV_*
functions). Also fix an instance of afs_int32 being used for a volume
ID, and remove 'struct volser_dest' instead of fixing it, since it is
completely unused.
Change-Id: I1008ed158855c2a22b4605b5a037f5e68731529e
Reviewed-on: http://gerrit.openafs.org/2249
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Add rx_GetServiceSpecific and rx_SetServiceSpecific to afsrpc.def
using the next available ordinals (267 and 268).
Change-Id: I31af43e9706b922ef765a51f50f583f492ce375a
Reviewed-on: http://gerrit.openafs.org/2245
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
afs_linux_mmap wasn't doing anything with the return code
from afs_linux_VerifyVCache. Change the code so that it matches
the other callers of afs_linux_VerifyVCache
Change-Id: I83b949bf3b9579e5dd2e20b487862566c1d7c730
Reviewed-on: http://gerrit.openafs.org/2247
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
butc/dump.c and ubik/beacon.c have had their warnings fixed and their
suppressions removed. Remove the warning suppression for tbutc/dump.c
and tubik/beacon.c, as well.
Change-Id: Ie3cae93932797ef5a55403f3548518af6da267f0
Reviewed-on: http://gerrit.openafs.org/2242
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/config/NTMakefile had the following issues:
* duplicate entries for headers in $(INCFILES)
* no clean: rule for $(INCFILES)
* no clean: rule for $(DESTDIR)\util_cr.exe
* $(INCTOOLS) dependent upon $(INCFILES) but the order is reversed
in the install: rule
Change-Id: I2707009d60b303ab897ed25d9245d893fa342a8e
Reviewed-on: http://gerrit.openafs.org/2238
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Matt Benjamin <matt@linuxbox.com>
Tested-by: Matt Benjamin <matt@linuxbox.com>
Don't include afsconfig.h and afs/param.h in util_cr.c, nor
assert.h. The assert was included but was in fact not used in
the file, and can be ommitted, per jaltman. The OpenAFS
includes are then not needed. An incorrect cast is also changed,
due to jaltman.
Change-Id: I3e1ad7a1d24473d6ad3ce2e401133b25b0a4c795
Reviewed-on: http://gerrit.openafs.org/2234
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
