The rxi_ReceiveAckPacket() change makes sure we have two extra fields
(the max and recommended packet sizes) hanging off the packet, rather
than just one.
The PKTFLAG_FREE stuff in rx_packet.c just initialized flags in case
PKTFLAG_ACKED somehow didn't get cleared there.
The wirevec changes are off-by-1 errors: there's p->niovecs iovecs
in a packet, from 0 (header) to p->niovecs-1, so p->niovecs doesn't
refer to a meaningful iovec.
1) Removal of unused variables
2) some NT ifdef cleanup
3) use of size_t rather than int to store the result of strlen()
4) some bugs that really only occured when errors occured.
5) some functions were implicitly declared as 'int' but doing a
"return;" Some I declared as 'void' and prototyped them; some I
just returned a value.
====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
put symbol in an ifndef for winnt
====================
change erroneous void to int
====================
technically the cmdprocs return int
====================
update function to be void
according to jeff:
- Renames the top-level 'install' target to 'build'. This should be
transparent, since no one should be using that.
- Improves on Sam's dirpath patches, by splitting out server binaries
into separate bin, sbin, and libexec directories in GCS mode (these
are all /usr/afs/bin in Transarc mode).
- Updates the top-level 'all' target so that it builds the software
but does not generate a dest tree. Top-level 'lib' and 'include'
directories are generated to hold the intermediate libraries and headers
used during the build.
- Adds a new top-level 'install' target, which installs things in the
appropriate directories under ${DESTDIR}, based on configure's install
directories plus the extras added by Sam's patch.
- Adds a new top-level 'dest' target, which creates an old-style dest
directory under ${DEST}. The ${DEST} variable defaults to the
traditional value of ${SRCDIR_PARENT}/${SYS_NAME}/dest. Note that
this variable used to be called ${DESTDIR}; it was renamed to avoid
conflicts with the de facto standard usage of ${DESTDIR}.
====================
This delta was composed from multiple commits as part of the CVS->Git migration.
The checkin message with each commit was inconsistent.
The following are the additional commit messages.
====================
fix missed makefile
====================
update another missed file
====================
eliminate bogus escaping
====================
get rid of another bogus escape
====================
remove unused include directory
====================
get rid of no longer used libdir
====================
remove unused incdir
====================
fix up some problems for make compatibility and missing trailing /
====================
put afs.exp in the right place
====================
remove bogus afssrvdir reference
====================
update dest version of output
====================
update ref to libexecdir
====================
kill refs to afssrvdir
====================
convert missed LIBDIR to TOP_LIBDIR
====================
remove explicit INSTALL and use makefile.@sys value instead
====================
except it's helpful to actually include makefile.@sys
====================
convert LIBDIR to TOP_LIBDIR
add ignore_uid (like ignore_root) plus set_token (set token in auth step instead of setcred), refresh_token (no new pag), use_klog (fork a klog child), no_unlog, remainlifetime (sleep before deleting creds at logout)
Sam's notes:
"Here is a patch that supports directory paths, documentation for the
above and decanonicalization of of supplied paths. Here are tests I
have run:
* Build with both transarc and non-transarc paths and examined
dirpath.o
* Build with roughly FHS-style paths and tested on Debian
* confirmed that bos salvage works even when salvager not in
/usr/afs/bin
(it gets the log correctly too)
* confirms that bos getlog can get logs from /usr/afs/logs even when
/ur/afs/logs
is /var/lib/openafs/logs
* confirmed that bos getlog can get /etc/motd
"
